* [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by default
@ 2016-12-23 8:41 Jiaxin Wu
2016-12-26 2:35 ` Ye, Ting
0 siblings, 1 reply; 2+ messages in thread
From: Jiaxin Wu @ 2016-12-23 8:41 UTC (permalink / raw)
To: edk2-devel; +Cc: Ni Ruiyu, Ye Ting, Long Qin, Fu Siyuan, Wu Jiaxin
TLS feature highly depends on the OpenSSL building. To avoid
the default Nt32 platform build failure, we should change the
default value of TLS_ENABLE to FALSE.
The notes are also provided for Secure Boot and TLS features.
Cc: Ni Ruiyu <ruiyu.ni@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Long Qin <qin.long@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
Nt32Pkg/Nt32Pkg.dsc | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc
index 0a59e46..134afb8 100644
--- a/Nt32Pkg/Nt32Pkg.dsc
+++ b/Nt32Pkg/Nt32Pkg.dsc
@@ -42,18 +42,26 @@
#
# Defines for default states. These can be changed on the command line.
# -D FLAG=VALUE
#
+ # Note: Secure Boot feature highly depends on the OpenSSL building. To enable this
+ # feature, please follow the instructions found in the file "Patch-HOWTO.txt"
+ # located in CryptoPkg\Library\OpensslLib to enable the OpenSSL building first.
+ #
DEFINE SECURE_BOOT_ENABLE = FALSE
#
# This flag is to enable or disable TLS feature.
# These can be changed on the command line.
# -D FLAG=VALUE
#
- DEFINE TLS_ENABLE = TRUE
+ # Note: TLS feature highly depends on the OpenSSL building. To enable this
+ # feature, please follow the instructions found in the file "Patch-HOWTO.txt"
+ # located in CryptoPkg\Library\OpensslLib to enable the OpenSSL building first.
+ #
+ DEFINE TLS_ENABLE = FALSE
################################################################################
#
# SKU Identification section - list of all SKU IDs supported by this
# Platform.
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by default
2016-12-23 8:41 [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by default Jiaxin Wu
@ 2016-12-26 2:35 ` Ye, Ting
0 siblings, 0 replies; 2+ messages in thread
From: Ye, Ting @ 2016-12-26 2:35 UTC (permalink / raw)
To: Wu, Jiaxin, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu, Long, Qin, Fu, Siyuan
Reviewed-by: Ye Ting <ting.ye@intel.com>
-----Original Message-----
From: Wu, Jiaxin
Sent: Friday, December 23, 2016 4:41 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Ye, Ting <ting.ye@intel.com>; Long, Qin <qin.long@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by default
TLS feature highly depends on the OpenSSL building. To avoid the default Nt32 platform build failure, we should change the default value of TLS_ENABLE to FALSE.
The notes are also provided for Secure Boot and TLS features.
Cc: Ni Ruiyu <ruiyu.ni@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Long Qin <qin.long@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
Nt32Pkg/Nt32Pkg.dsc | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc index 0a59e46..134afb8 100644
--- a/Nt32Pkg/Nt32Pkg.dsc
+++ b/Nt32Pkg/Nt32Pkg.dsc
@@ -42,18 +42,26 @@
#
# Defines for default states. These can be changed on the command line.
# -D FLAG=VALUE
#
+ # Note: Secure Boot feature highly depends on the OpenSSL building. To enable this
+ # feature, please follow the instructions found in the file "Patch-HOWTO.txt"
+ # located in CryptoPkg\Library\OpensslLib to enable the OpenSSL building first.
+ #
DEFINE SECURE_BOOT_ENABLE = FALSE
#
# This flag is to enable or disable TLS feature.
# These can be changed on the command line.
# -D FLAG=VALUE
#
- DEFINE TLS_ENABLE = TRUE
+ # Note: TLS feature highly depends on the OpenSSL building. To enable this
+ # feature, please follow the instructions found in the file "Patch-HOWTO.txt"
+ # located in CryptoPkg\Library\OpensslLib to enable the OpenSSL building first.
+ #
+ DEFINE TLS_ENABLE = FALSE
################################################################################
#
# SKU Identification section - list of all SKU IDs supported by this
# Platform.
--
1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-26 2:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-23 8:41 [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by default Jiaxin Wu
2016-12-26 2:35 ` Ye, Ting
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox