From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 24120818BA for ; Sun, 25 Dec 2016 18:35:15 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP; 25 Dec 2016 18:35:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,404,1477983600"; d="scan'208";a="1086618733" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 25 Dec 2016 18:35:14 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 25 Dec 2016 18:35:14 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 25 Dec 2016 18:35:14 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Mon, 26 Dec 2016 10:35:12 +0800 From: "Ye, Ting" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Long, Qin" , "Fu, Siyuan" Thread-Topic: [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by default Thread-Index: AQHSXPhh6NgCSXrMH0i/rVDomChnw6EZh11Q Date: Mon, 26 Dec 2016 02:35:12 +0000 Message-ID: References: <1482482484-344648-1-git-send-email-jiaxin.wu@intel.com> In-Reply-To: <1482482484-344648-1-git-send-email-jiaxin.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by default X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2016 02:35:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ye Ting =20 -----Original Message----- From: Wu, Jiaxin=20 Sent: Friday, December 23, 2016 4:41 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Ye, Ting ; Long, Qin= ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by de= fault TLS feature highly depends on the OpenSSL building. To avoid the default Nt= 32 platform build failure, we should change the default value of TLS_ENABLE= to FALSE. The notes are also provided for Secure Boot and TLS features. Cc: Ni Ruiyu Cc: Ye Ting Cc: Long Qin Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- Nt32Pkg/Nt32Pkg.dsc | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc index 0a59e46..134af= b8 100644 --- a/Nt32Pkg/Nt32Pkg.dsc +++ b/Nt32Pkg/Nt32Pkg.dsc @@ -42,18 +42,26 @@ =20 # # Defines for default states. These can be changed on the command line. # -D FLAG=3DVALUE # + # Note: Secure Boot feature highly depends on the OpenSSL building. To e= nable this=20 + # feature, please follow the instructions found in the file "Patch= -HOWTO.txt"=20 + # located in CryptoPkg\Library\OpensslLib to enable the OpenSSL bu= ilding first. + # DEFINE SECURE_BOOT_ENABLE =3D FALSE =20 # # This flag is to enable or disable TLS feature. =20 # These can be changed on the command line. # -D FLAG=3DVALUE # - DEFINE TLS_ENABLE =3D TRUE + # Note: TLS feature highly depends on the OpenSSL building. To enable th= is=20 + # feature, please follow the instructions found in the file "Patch= -HOWTO.txt"=20 + # located in CryptoPkg\Library\OpensslLib to enable the OpenSSL bu= ilding first. + # + DEFINE TLS_ENABLE =3D FALSE =20 ##########################################################################= ###### # # SKU Identification section - list of all SKU IDs supported by this # Platform. -- 1.9.5.msysgit.1