From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 53C9C21DFA8FE for ; Thu, 30 Mar 2017 00:56:34 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 30 Mar 2017 00:56:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,245,1486454400"; d="scan'208";a="1113563114" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 30 Mar 2017 00:56:33 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Mar 2017 00:56:33 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Mar 2017 00:56:32 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.253]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.46]) with mapi id 14.03.0248.002; Thu, 30 Mar 2017 15:56:31 +0800 From: "Ye, Ting" To: "Long, Qin" , "Dong, Eric" , "Wu, Hao A" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module Thread-Index: AQHSqSnX/9Omw5oFvUiM8rSDPGA+Q6GtA+Lg Date: Thu, 30 Mar 2017 07:56:30 +0000 Message-ID: References: <20170330074644.10580-1-qin.long@intel.com> In-Reply-To: <20170330074644.10580-1-qin.long@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 07:56:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ye Ting =20 -----Original Message----- From: Long, Qin=20 Sent: Thursday, March 30, 2017 3:47 PM To: Ye, Ting ; Dong, Eric ; Wu, Hao= A ; edk2-devel@lists.01.org Subject: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Mod= ule The memory free operation is empty function in PEI. The compiler optimizati= on will bring the build warning in openssl/crypto/mem.c: warning C4718: 'CRYPTO_free': recursive call has no side effects, deleting This patch uses '/wd4718' to silence the build warning for PEI module build= ing. Cc: Ting Ye Cc: Eric Dong Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qin Long --- CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf b/CryptoPkg/Lib= rary/BaseCryptLib/PeiCryptLib.inf index fdcd8b95f5..34e18971c8 100644 --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf @@ -89,8 +89,9 @@ # # suppress the following warnings so we do not break the build with warn= ings-as-errors: # C4090: 'function' : different 'const' qualifiers + # C4717: 'function call' : recursive call has no side effects,=20 + deleting # - MSFT:*_*_*_CC_FLAGS =3D /wd4090 + MSFT:*_*_*_CC_FLAGS =3D /wd4090 /wd4718 =20 GCC:*_GCC44_IA32_CC_FLAGS =3D "-D__cdecl=3D__attribute__((cdecl))" "-D__= declspec(t)=3D__attribute__((t))" =20 -- 2.12.2.windows.1