From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 659682195406F for ; Thu, 20 Apr 2017 19:02:34 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Apr 2017 19:02:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,228,1488873600"; d="scan'208";a="79397742" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 20 Apr 2017 19:02:33 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 20 Apr 2017 19:02:33 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 20 Apr 2017 19:02:33 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002; Fri, 21 Apr 2017 10:02:32 +0800 From: "Ye, Ting" To: "Fu, Siyuan" , "edk2-devel@lists.01.org" CC: "Wu, Jiaxin" Thread-Topic: [Patch] OptionRomPkg: Fix calling convention issue for UndiRuntiumeDxe driver. Thread-Index: AQHSuj8v4iZsVhHGWE6nnCoPoaC2M6HPEh3g Date: Fri, 21 Apr 2017 02:02:31 +0000 Message-ID: References: <1492738354-14220-1-git-send-email-siyuan.fu@intel.com> In-Reply-To: <1492738354-14220-1-git-send-email-siyuan.fu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] OptionRomPkg: Fix calling convention issue for UndiRuntiumeDxe driver. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Apr 2017 02:02:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ye Ting =20 -----Original Message----- From: Fu, Siyuan=20 Sent: Friday, April 21, 2017 9:33 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin Subject: [Patch] OptionRomPkg: Fix calling convention issue for UndiRuntium= eDxe driver. Add "EFIAPI" to UNDI command entry point function according to UEFI calling= convention. Cc: Ye Ting Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan --- OptionRomPkg/UndiRuntimeDxe/Decode.c | 3 ++- OptionRomPkg/UndiRuntimeDxe/= Undi32.h | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/OptionRomPkg/UndiRuntimeDxe/Decode.c b/OptionRomPkg/UndiRuntim= eDxe/Decode.c index 5f85347..cff6942 100644 --- a/OptionRomPkg/UndiRuntimeDxe/Decode.c +++ b/OptionRomPkg/UndiRuntimeDxe/Decode.c @@ -1,7 +1,7 @@ /** @file Provides the basic UNID functions. =20 -Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at @@ -1276,6 +1= 276,7 @@ UNDI_Receive ( **/ // TODO: cdb - add argument and description to function comment VOID +EFIAPI UNDI_APIEntry_new ( IN UINT64 cdb ) diff --git a/OptionRomPkg/UndiRuntimeDxe/Undi32.h b/OptionRomPkg/UndiRuntim= eDxe/Undi32.h index 18341dd..00b48f6 100644 --- a/OptionRomPkg/UndiRuntimeDxe/Undi32.h +++ b/OptionRomPkg/UndiRuntimeDxe/Undi32.h @@ -1,7 +1,7 @@ /** @file EFI internal structures for the EFI UNDI driver. =20 -Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at @@ -338,7 +33= 8,7 @@ UNDI_Receive ( IN NIC_DATA_INSTANCE *AdapterInfo ); =20 -VOID UNDI_APIEntry_new(UINT64); +VOID EFIAPI UNDI_APIEntry_new(UINT64); VOID UNDI_APIEntry_Common(UINT64); =20 PXE_IPV4 convert_mcip(PXE_MAC_ADDR *); -- 2.7.4.windows.1