From: "Ye, Ting" <ting.ye@intel.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
Paulo Alcantara <pcacjr@gmail.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Dong, Eric" <eric.dong@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v2] MdeModulePkg/DxeHttpLib: Fix potential memory leaks
Date: Mon, 5 Jun 2017 07:15:43 +0000 [thread overview]
Message-ID: <BC0C045B0E2A584CA4575E779FA2C12A1A9044CC@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: 20170522115211.7133-1-pcacjr@gmail.com
Reviewed-by: Ye Ting <ting.ye@intel.com>
-----Original Message-----
From: Wu, Jiaxin
Sent: Tuesday, May 23, 2017 10:11 AM
To: Paulo Alcantara <pcacjr@gmail.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [edk2] [PATCH v2] MdeModulePkg/DxeHttpLib: Fix potential memory leaks
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Paulo Alcantara
> Sent: Monday, May 22, 2017 7:52 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH v2] MdeModulePkg/DxeHttpLib: Fix potential
> memory leaks
>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Paulo Alcantara <pcacjr@gmail.com>
> ---
> MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> index 8421caa..2929238 100644
> --- a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> +++ b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> @@ -523,6 +523,7 @@ HttpUrlGetHostName (
> &ResultLength
> );
> if (EFI_ERROR (Status)) {
> + FreePool (Name);
> return Status;
> }
>
> @@ -582,6 +583,7 @@ HttpUrlGetIp4 (
> &ResultLength
> );
> if (EFI_ERROR (Status)) {
> + FreePool (Ip4String);
> return Status;
> }
>
> @@ -657,6 +659,7 @@ HttpUrlGetIp6 (
> &ResultLength
> );
> if (EFI_ERROR (Status)) {
> + FreePool (Ip6String);
> return Status;
> }
>
> @@ -722,14 +725,15 @@ HttpUrlGetPort (
> &ResultLength
> );
> if (EFI_ERROR (Status)) {
> - return Status;
> + goto ON_EXIT;
> }
>
> PortString[ResultLength] = '\0';
>
> while (Index < ResultLength) {
> if (!NET_IS_DIGIT (PortString[Index])) {
> - return EFI_INVALID_PARAMETER;
> + Status = EFI_INVALID_PARAMETER;
> + goto ON_EXIT;
> }
> Index ++;
> }
> @@ -737,10 +741,14 @@ HttpUrlGetPort (
> Status = AsciiStrDecimalToUintnS (Url + Parser-
> >FieldData[HTTP_URI_FIELD_PORT].Offset, (CHAR8 **) NULL, &Data);
>
> if (Data > HTTP_URI_PORT_MAX_NUM) {
> - return EFI_INVALID_PARAMETER;
> + Status = EFI_INVALID_PARAMETER;
> + goto ON_EXIT;
> }
>
> *Port = (UINT16) Data;
> +
> +ON_EXIT:
> + FreePool (PortString);
> return Status;
> }
>
> @@ -795,6 +803,7 @@ HttpUrlGetPath (
> &ResultLength
> );
> if (EFI_ERROR (Status)) {
> + FreePool (PathStr);
> return Status;
> }
>
> --
> 2.9.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-06-05 7:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 13:42 [PATCH] MdeModulePkg/DxeHttpLib: Fix potential memory leaks Paulo Alcantara
2017-05-22 2:55 ` Wu, Jiaxin
2017-05-22 11:52 ` [PATCH v2] " Paulo Alcantara
2017-05-23 2:10 ` Wu, Jiaxin
2017-06-05 7:15 ` Ye, Ting [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BC0C045B0E2A584CA4575E779FA2C12A1A9044CC@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox