From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 77F5E21A16EC4 for ; Mon, 5 Jun 2017 00:38:07 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 05 Jun 2017 00:39:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,300,1493708400"; d="scan'208";a="1178346292" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 05 Jun 2017 00:39:12 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 5 Jun 2017 00:39:12 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 5 Jun 2017 00:39:12 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Mon, 5 Jun 2017 15:39:10 +0800 From: "Ye, Ting" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Fu, Siyuan" Thread-Topic: [Patch 1/2] MdeModulePkg/UefiPxeBcDxe: Fix the PXE BootMenu selection issue Thread-Index: AQHS0s4oNFD1c4HJdUmTj5sY9Koj1qIV9/DQ Date: Mon, 5 Jun 2017 07:39:09 +0000 Message-ID: References: <1495438575-9900-1-git-send-email-jiaxin.wu@intel.com> <1495438575-9900-2-git-send-email-jiaxin.wu@intel.com> In-Reply-To: <1495438575-9900-2-git-send-email-jiaxin.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 1/2] MdeModulePkg/UefiPxeBcDxe: Fix the PXE BootMenu selection issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jun 2017 07:38:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ye Ting =20 -----Original Message----- From: Wu, Jiaxin=20 Sent: Monday, May 22, 2017 3:36 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jia= xin Subject: [Patch 1/2] MdeModulePkg/UefiPxeBcDxe: Fix the PXE BootMenu select= ion issue Currently implementation doesn't accept the input during the user is trying= to select the PXE BootMenu from option 43. This path is to fix that proble= m. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c b/MdeM= odulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c index f0720e5..c5f3437 100644 --- a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c +++ b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c @@ -1,10 +1,10 @@ /** @file Support for PxeBc dhcp functions. =20 Copyright (c) 2013, Red Hat, Inc. -Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at http://opens= ource.org/licenses/bsd-license.php =20 @@ -1843,11 +1843,11 @@ PxeBcSelectBootMenu ( CHAR8 Blank[70]; PXEBC_BOOT_MENU_ENTRY *MenuItem; PXEBC_BOOT_MENU_ENTRY *MenuArray[PXEBC_MAX_MENU_NUM]; =20 Finish =3D FALSE; - Select =3D 1; + Select =3D 0; Index =3D 0; *Type =3D 0; =20 if (Private->PxeBc.Mode->ProxyOfferReceived) { =20 @@ -1912,11 +1912,11 @@ PxeBcSelectBootMenu ( =20 while (gST->ConIn->ReadKeyStroke (gST->ConIn, &InputKey) =3D=3D EFI_NO= T_READY) { gBS->Stall (10 * TICKS_PER_MS); } =20 - if (InputKey.ScanCode !=3D 0) { + if (InputKey.ScanCode =3D=3D 0) { switch (InputKey.UnicodeChar) { case CTRL ('c'): InputKey.ScanCode =3D SCAN_ESC; break; =20 -- 1.9.5.msysgit.1