From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=ting.ye@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D74B5221C192C for ; Tue, 19 Dec 2017 00:30:20 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2017 00:35:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,425,1508828400"; d="scan'208,217";a="185413037" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 19 Dec 2017 00:35:06 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 19 Dec 2017 00:35:06 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 19 Dec 2017 00:35:05 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Tue, 19 Dec 2017 16:35:03 +0800 From: "Ye, Ting" To: Karunakar P , "'edk2-devel@lists.01.org'" CC: "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: Syntax error in EFI iSCSI Initiator Name Protocol in UEFI2.7 Spec Thread-Index: AdN4oyptCl1Rs6DyS7Go/gwMWuby6wAAM0MA Date: Tue, 19 Dec 2017 08:35:03 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: Syntax error in EFI iSCSI Initiator Name Protocol in UEFI2.7 Spec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 08:30:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Karunakar, Thanks for capturing the issue. We will raise it to spec group soon. Hopefu= lly we can fix it in the next version of UEFI specification. Best Regards, Ting From: Karunakar P [mailto:karunakarp@amiindia.co.in] Sent: Tuesday, December 19, 2017 4:29 PM To: 'edk2-devel@lists.01.org' Cc: Fu, Siyuan ; Ye, Ting ; Wu, Jia= xin Subject: Syntax error in EFI iSCSI Initiator Name Protocol in UEFI2.7 Spec Hello All, There is a typing mistake in EFI_ISCSI_INITIATOR_NAME_PROTOCOL Get() and Se= t() Prototypes UEFI2.7 16.2 Page 921,922 EFI_ISCSI_INITIATOR_NAME_PROTOCOL. Get() Summary Retrieves the current set value of iSCSI Initiator Name. Prototype typedef EFI_STATUS (EFIAPI *EFI_ISCSI_INITIATOR_NAME_GET) { IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This IN OUT UINTN *BufferSize OUT VOID *Buffer } EFI_ISCSI_INITIATOR_NAME_PROTOCOL.Set() Summary Sets the iSCSI Initiator Name. Prototype typedef EFI_STATUS (EFIAPI *EFI_ISCSI_INITIATOR_NAME_SET) { IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This IN OUT UINTN *BufferSize IN VOID *Buffer } The Prototypes should be like below typedef EFI_STATUS (EFIAPI *EFI_ISCSI_INITIATOR_NAME_GET) ( IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This IN OUT UINTN *BufferSize OUT VOID *Buffer ); typedef EFI_STATUS (EFIAPI *EFI_ISCSI_INITIATOR_NAME_SET) ( IN EFI_ISCSI_INITIATOR_NAME_PROTOCOL *This IN OUT UINTN *BufferSize IN VOID *Buffer ); Thanks, Karunakar