From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=ting.ye@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D37B821107164 for ; Wed, 6 Jun 2018 17:40:30 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2018 17:40:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,485,1520924400"; d="scan'208";a="57172000" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 06 Jun 2018 17:40:29 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Jun 2018 17:40:29 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Jun 2018 17:40:29 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by shsmsx102.ccr.corp.intel.com ([169.254.2.223]) with mapi id 14.03.0319.002; Thu, 7 Jun 2018 08:40:27 +0800 From: "Ye, Ting" To: Sivaraman Nainar , Omkar K , "edk2-devel@lists.01.org" CC: "Madhan B. Santharam" Thread-Topic: reg: ISCSI Aborted attempt entry in IBFT Table Thread-Index: AdP42UDlkFChXFAfQSSCa5fOzOTx6QDB0jOQADK8eZAAMUWyIAAAkYmwACDz2sA= Date: Thu, 7 Jun 2018 00:40:27 +0000 Message-ID: References: <0A1D4EFB13BE094CAC182DD1FADDCFE601C5D56AC2@VENUS1.in.megatrends.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: reg: ISCSI Aborted attempt entry in IBFT Table X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 00:40:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Siva, Per design, all successful attempts will be published to iBFT, no matter it= is currently used or aborted. Only failed attempts are not published.=20 I don't think the current behavior is wrong according to iBFT specification= , see http://download.microsoft.com/download/7/E/7/7E7662CF-CBEA-470B-A97E-= CE7CE0D98DC2/iBFT.docx. Thanks, Ting=09 -----Original Message----- From: Sivaraman Nainar [mailto:sivaramann@amiindia.co.in]=20 Sent: Wednesday, June 6, 2018 5:01 PM To: Ye, Ting ; Omkar K ; edk2-dev= el@lists.01.org Cc: Madhan B. Santharam Subject: RE: reg: ISCSI Aborted attempt entry in IBFT Table Hello Ting, Yes. In the use case we said: NIC 1 - Target 1 : Login success NIC 1 - Target 2 : Login success NIC 2 - Target 1 : Login success But iSCSI Driver will choose the first login session and abort the other in= the same NIC. But even it is aborted it is Published to IBFT. As you said the ESXi and SLES not able to proceed installation assuming mor= e than one IBFT for the same NIC as illegal. So what the clarification we are asking is since it's an aborted attempt ca= n we skip adding IBFT entry for the aborted attempt. Please refer the ticket already created for this has the proposed solution. https://bugzilla.tianocore.org/show_bug.cgi?id=3D968 -Siva -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ye, = Ting Sent: Wednesday, June 06, 2018 2:04 PM To: Omkar K; edk2-devel@lists.01.org Cc: Madhan B. Santharam Subject: Re: [edk2] reg: ISCSI Aborted attempt entry in IBFT Table Hi Omkar, If not MPIO, current iSCSI driver will try the configured attempts and only= publish the successful entries in iBFT. The failed attempts will be remove= d. In your case, it looks the ESXi and SLES OS treat the multiple entries on o= ne NIC (different targets) are illegal.=20 Thanks, Ting -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Omka= r K Sent: Tuesday, June 5, 2018 5:01 PM To: Ye, Ting ; edk2-devel@lists.01.org Cc: Madhan B. Santharam Subject: Re: [edk2] reg: ISCSI Aborted attempt entry in IBFT Table Hello Ting, 1. We did not enable MPIO. 2. in IScsiStart(), at this point // // Select the first login session. Abort others. // if (Private->Session =3D=3D NULL) { Private->Session =3D Session; BootSelected =3D AttemptConfigData->AttemptConfigIndex; // // Don't validate other attempt in multipath mode if one is success. // if (mPrivate->EnableMpio) { break; } } else { IScsiSessionAbort (Session); FreePool (Session); } other than one attempt per Nic, other sessions are aborted. Still, all the = attempts are published in IBFT. We can observe the issue when different targets are configured on one NIC w= here all the attempts are published in IBFT. But, the issue disappeared when the aborted attempts are not published in I= BFT. Thanks, Omkar -----Original Message----- From: Ye, Ting [mailto:ting.ye@intel.com]=20 Sent: Monday, June 04, 2018 2:26 PM To: Sivaraman Nainar; edk2-devel@lists.01.org Cc: Omkar K; Madhan B. Santharam Subject: RE: reg: ISCSI Aborted attempt entry in IBFT Table Hi Siva, Per design, the iSCSI multipath I/O will publish all configured attempts to= IBFT, no matter the connection is success or fail currently. Did you enable the MPIO when you configure the attempts?=20 I am not clear what do you mean "aborted attempt". Thanks, Ting -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Siva= raman Nainar Sent: Thursday, May 31, 2018 8:18 PM To: edk2-devel@lists.01.org Cc: Omkar K ; Madhan B. Santharam Subject: [edk2] reg: ISCSI Aborted attempt entry in IBFT Table Hello all: Here is the issue which requires clarification. Issue Synopsis: When there are more than one iSCSI target configured and Ibft table publish= ed with the connected and aborted attempt details, all the targets are not = seen in ESXi and SLES OS. But in Windows it can see the targets connected. Use case: Target 1: IP : 192.xx.xx.31 Target 2 : IP : 192.xx.xx.1 NIC 1 configured with attempts Target 1 & Target 2 NIC 2 configured with at= tempts Target 1 Connection Login Ibft Block Device in UEFI Shell SLES / Esx OS Windows NIC1 Target1 Success Published Mounted Target Seen NIC1 Target2 Success Published Mounted Target Seen NIC1 Target1 NIC1 Target2 NIC2 Target1 Individual Login success Published for all attempts (3) NIC1 Target 1 NIC2 Target 1 None Seen NIC1 Target 1 NIC2 Target 1 When the attempts which are login success but Aborted by ISCSI Driver are p= resent in ibft table SLES and ESX not able to see the targets during Instal= lation. If the ISCSI Driver not adding the ibft entry for the aborted attempts then= the targets are seen in Esx and SLES. So it requires clarification that If the driver need to SKIP adding the abo= rted attempt entry to ibft or its OS responsibility to handle the invalid e= ntries in ibft. -Siva _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel