From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ting.ye@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B618C21A09130 for ; Tue, 25 Sep 2018 01:41:16 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 01:41:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,301,1534834800"; d="scan'208";a="77071702" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 25 Sep 2018 01:40:53 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Sep 2018 01:40:52 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Sep 2018 01:40:52 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.245]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.220]) with mapi id 14.03.0319.002; Tue, 25 Sep 2018 16:40:49 +0800 From: "Ye, Ting" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Fu, Siyuan" , "Carsey, Jaben" , "Shao, Ming" , Laszlo Ersek Thread-Topic: [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download performance. Thread-Index: AQHUVGzXKiD+FC1MH0KTgFcEF6mUq6UArgFw Date: Tue, 25 Sep 2018 08:40:49 +0000 Message-ID: References: <20180925011145.14316-1-Jiaxin.wu@intel.com> In-Reply-To: <20180925011145.14316-1-Jiaxin.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download performance. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 08:41:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ye Ting =20 -----Original Message----- From: Wu, Jiaxin=20 Sent: Tuesday, September 25, 2018 9:12 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Carsey,= Jaben ; Shao, Ming ; Laszlo E= rsek ; Wu, Jiaxin Subject: [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download per= formance. *v2: The first three patches(1/2/3) are the same with version 1, just updat= e the last two patches (4/5): I) This patch has been discarded since we rename and redefine the= PCD in NetworkPkg instead of MdeModulePkg. The replacement is:=20 [PATCH v2 4/5] NetworkPkg: Define one PCD for PXE to specify MTFTP windowsi= ze. II) Since th= e new PCD (PcdPxeTftpWindowSize) was renamed/defined in NetworkPkg instead = of MdeModulePkg, we udpate the consuming PXE driver. The new version patch = is: [PATCH v2 5/5] NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D886 The series patches are to support the TFTP windowsize option described in R= FC 7440. TFTP shell command and UEFI PXE driver will use the feature to benefit the = download performance. Cc: Ye Ting Cc: Fu Siyuan Cc: Carsey Jaben Cc: Shao Ming Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin Jiaxin Wu (5): MdeModulePke/Mtftp4Dxe: Support windowsize in read request operation. NetworkPkg/Mtftp6Dxe: Support windowsize in read request operation. ShellPkg/TftpDynamicCommand: Add one option for tftp command to specify windowsize. NetworkPkg: Define one PCD for PXE to specify MTFTP windowsize. NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize. .../Universal/Network/Mtftp4Dxe/Mtftp4Impl.c | 5 + .../Universal/Network/Mtftp4Dxe/Mtftp4Impl.h | 10 ++ .../Network/Mtftp4Dxe/Mtftp4Option.c | 25 +++- .../Network/Mtftp4Dxe/Mtftp4Option.h | 8 +- .../Universal/Network/Mtftp4Dxe/Mtftp4Rrq.c | 55 +++++-- .../Network/Mtftp4Dxe/Mtftp4Support.c | 8 +- .../Network/Mtftp4Dxe/Mtftp4Support.h | 13 -- .../Universal/Network/Mtftp4Dxe/Mtftp4Wrq.c | 2 +- NetworkPkg/Mtftp6Dxe/Mtftp6Impl.h | 13 +- NetworkPkg/Mtftp6Dxe/Mtftp6Option.c | 22 ++- NetworkPkg/Mtftp6Dxe/Mtftp6Option.h | 14 +- NetworkPkg/Mtftp6Dxe/Mtftp6Rrq.c | 53 +++++-- NetworkPkg/Mtftp6Dxe/Mtftp6Support.c | 10 ++ NetworkPkg/Mtftp6Dxe/Mtftp6Wrq.c | 2 +- NetworkPkg/NetworkPkg.dec | 6 + NetworkPkg/NetworkPkg.uni | 6 + NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c | 10 +- NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 137 +++++++++++++----- NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 6 +- NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 3 + .../DynamicCommand/TftpDynamicCommand/Tftp.c | 65 +++++++-- .../TftpDynamicCommand/Tftp.uni | 6 +- 22 files changed, 371 insertions(+), 108 deletions(-) -- 2.17.1.windows.2