From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=rangasai.v.chaganty@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4786D201B0387 for ; Mon, 18 Feb 2019 16:49:23 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2019 16:49:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,385,1544515200"; d="scan'208";a="135326234" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga002.jf.intel.com with ESMTP; 18 Feb 2019 16:49:22 -0800 Received: from orsmsx122.amr.corp.intel.com (10.22.225.227) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Feb 2019 16:49:22 -0800 Received: from orsmsx108.amr.corp.intel.com ([169.254.2.157]) by ORSMSX122.amr.corp.intel.com ([169.254.11.48]) with mapi id 14.03.0415.000; Mon, 18 Feb 2019 16:49:21 -0800 From: "Chaganty, Rangasai V" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] IntelSiliconPkg/MicrocodeUpdateDxe: Error message enhancement Thread-Index: AQHUx1pRU3hGyco2dUKHqGp4IE1FsKXmSrlg Date: Tue, 19 Feb 2019 00:49:20 +0000 Message-ID: References: <20190218071916.11252-1-shenglei.zhang@intel.com> In-Reply-To: <20190218071916.11252-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGJmY2IxNWItNjk4MS00ZTIyLWI5Y2UtY2NmYWFhZThjODRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid2tVQVFuTTgzcG0xYjFoVlhuM3JQVjRjMnRlbXlcLzA1cmVaTm0yVEJnOFwvNHlMTUhMQWtmcFpJdDhtcWZ2a0lnIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH] IntelSiliconPkg/MicrocodeUpdateDxe: Error message enhancement X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Feb 2019 00:49:23 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chaganty, Rangasai V =20 -----Original Message----- From: Zhang, Shenglei=20 Sent: Sunday, February 17, 2019 11:19 PM To: edk2-devel@lists.01.org Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [PATCH] IntelSiliconPkg/MicrocodeUpdateDxe: Error message enhancem= ent The error message of ExtendedTableCount is not clear. Add the count number = into the debug message. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1500 Cc: Ray Ni Cc: Rangasai V Chaganty Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUp= date.c b/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate= .c index 9098712c2f..9b5757da71 100644 --- a/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate.c +++ b/IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdate +++ .c @@ -518,7 +518,7 @@ VerifyMicrocode ( // ExtendedTableCount =3D ExtendedTableHeader->ExtendedSignatureCou= nt; if (ExtendedTableCount > (ExtendedTableLength - sizeof(CPU_MICRO= CODE_EXTENDED_TABLE_HEADER)) / sizeof(CPU_MICROCODE_EXTENDED_TABLE)) { - DEBUG((DEBUG_ERROR, "VerifyMicrocode - ExtendedTableCount too = big\n")); + DEBUG((DEBUG_ERROR, "VerifyMicrocode - ExtendedTableCount=20 + %d is too big\n", ExtendedTableCount)); } else { ExtendedTable =3D (CPU_MICROCODE_EXTENDED_TABLE *)(ExtendedTab= leHeader + 1); for (Index =3D 0; Index < ExtendedTableCount; Index++) { -- 2.18.0.windows.1