Re: [edk2-platforms][PATCH V1 37/37] Add WhiskeylakeOpenBoardPkg to global build config and documentation

["Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>]

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Kubacki, Michael A 
Sent: Friday, August 16, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Gao, Liming <liming.gao@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>
Subject: [edk2-platforms][PATCH V1 37/37] Add WhiskeylakeOpenBoardPkg to global build config and documentation

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2083

* Adds the WhiskeylakeURvp board as a build option in build.cfg so it
  it is listed as a valid build target.
* Updates relevant Readme.md files to include instructions for
  WhiskeylakeOpenBoardPkg.
* Adds the maintainers for WhiskeylakeOpenBoardPkg to maintainers.txt.

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
 Maintainers.txt          |  5 +++
 Platform/Intel/Readme.md | 44 +++++++++++++-------  Platform/Intel/build.cfg |  4 +-
 Readme.md                |  1 +
 4 files changed, 38 insertions(+), 16 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt index bc8cbd6458..b16432bf87 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -98,6 +98,11 @@ M: Shifei A Lu <shifei.a.lu@intel.com>
 M: Xiaohu Zhou <bowen.zhou@intel.com>
 M: Isaac W Oram <isaac.w.oram@intel.com>
 
+Platform/Intel/WhiskeylakeOpenBoardPkg
+M: Chasel Chiu <chasel.chiu@intel.com>
+M: Michael Kubacki <michael.a.kubacki@intel.com>
+M: Nate DeSimone <nathaniel.l.desimone@intel.com>
+
 Platform/Intel/Tools
 M: Bob Feng <bob.c.feng@intel.com>
 M: Liming Gao <liming.gao@intel.com>
diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index 00f42985a2..aaf6ef4d3e 100644
--- a/Platform/Intel/Readme.md
+++ b/Platform/Intel/Readme.md
@@ -53,9 +53,10 @@ A UEFI firmware implementation using MinPlatformPkg is constructed using the fol
 
 
 ## Board Support
+* The `ClevoOpenBoardPkg` contains board implementations for Clevo systems.
 * The `KabylakeOpenBoardPkg` contains board implementations for Kaby Lake systems.
 * The `PurleyOpenBoardPkg` contains board implementations for Purley systems.
-* The `ClevoOpenBoardPkg` contains board implementations for Clevo systems.
+* The `WhiskeylakeOpenBoardPkg` contains board implementations for Whiskey Lake systems.
 
 ## Board Package Organization
 The board package follows the standard EDK II package structure with the following additional elements and guidelines:
@@ -189,7 +190,12 @@ return back to the minimum platform caller.
           |       |        |                |---build_config.cfg: BoardMtOlympus specific
           |       |        |                |                     build settings, environment variables.
           |       |        |                |---build_board.py: Optional board-specific pre-build,
-          |       |        |                |                   build, post-build and clean functions.
+          |       |        |                                    build, post-build and clean functions.
+          |       |        |
+          |       |        |------WhiskeylakeOpenBoardPkg
+          |       |        |        |------WhiskeylakeURvp
+          |       |        |                |---build_config.cfg: WhiskeylakeURvp specific build
+          |       |        |                                      settings environment variables.
           |------FSP
   </pre>
 
@@ -222,19 +228,6 @@ Users can also flash the UEFI firmware image to the highest area of the flash re
 
 ### **Known limitations**
 
-**KabylakeOpenBoardPkg**
-1. This firmware project has only been tested on the Intel KabylakeRvp3 board.
-2. This firmware project has only been tested booting to Microsoft Windows 10 x64 with AHCI mode and Integrated Graphic
-  Device.
-3. The Windows build was tested on Windows 10 with Microsoft Visual Studio 2015.
-4. The Linux build was tested on Ubuntu 16.04.5 LTS with GCC version 5.4.0.
-5. The build was tested with NASM version 2.11.08.
-
-**PurleyOpenBoardPkg**
-1. This firmware project has only been tested on the Microsoft MtOlympus board.
-2. This firmware project has only been tested booting to Microsoft Windows Server 2016 with NVME on M.2 slot.
-3. This firmware project build has only been tested using the Microsoft Visual Studio 2015 compiler.
-
 **ClevoOpenBoardPkg**
 1. Currently, support is only being added for the N1xxWU series of boards.
 2. The Windows build was tested on Windows 10 with Microsoft Visual Studio 2015 compiler.
@@ -244,6 +237,27 @@ Users can also flash the UEFI firmware image to the highest area of the flash re  6. The firmware project applies to all Clevo supported board configurations but is only being tested on System 76 Galago
   Pro devices.
 
+**KabylakeOpenBoardPkg**
+1. This firmware project has only been tested on the Intel KabylakeRvp3 board.
+2. This firmware project has only been tested booting to Microsoft 
+Windows 10 x64 with AHCI mode and Integrated Graphic
+  Device.
+3. The Windows build was tested on Windows 10 with Microsoft Visual Studio 2015.
+4. The Linux build was tested on Ubuntu 16.04.5 LTS with GCC version 5.4.0.
+5. The build was tested with NASM version 2.11.08.
+
+**PurleyOpenBoardPkg**
+1. This firmware project has only been tested on the Microsoft MtOlympus board.
+2. This firmware project has only been tested booting to Microsoft Windows Server 2016 with NVME on M.2 slot.
+3. This firmware project build has only been tested using the Microsoft Visual Studio 2015 compiler.
+
+**WhiskeylakeOpenBoardPkg**
+1. This firmware project has only been tested on the Intel WhiskeylakeURvp board.
+2. This firmware project has only been tested booting to Microsoft 
+Windows 10 x64 with AHCI mode and Integrated Graphic
+  Device.
+3. The Windows build was tested on Windows 10 with Microsoft Visual Studio 2015.
+4. The Linux build was tested on Ubuntu 16.04.5 LTS with GCC version 5.4.0.
+5. The build was tested with NASM version 2.11.08.
+
 ### **Planned Activities**
 * Replace the batch build scripts with cross-platform Python build scripts.
 * Publish a Minimum Platform specification to describe the architecture and interfaces in more detail.
diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index fc6e4fe824..b6d32ada49 100644
--- a/Platform/Intel/build.cfg
+++ b/Platform/Intel/build.cfg
@@ -51,6 +51,8 @@ NUMBER_OF_PROCESSORS = 0
 
 [PLATFORMS]
 # board_name = path_to_board_build_config.cfg
+BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg
 KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
 N1xxWU = ClevoOpenBoardPkg/N1xxWU/build_config.cfg
-BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg
+WhiskeylakeURvp = 
+WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
+
diff --git a/Readme.md b/Readme.md
index 1befd0b544..e4f211eee6 100644
--- a/Readme.md
+++ b/Readme.md
@@ -228,6 +228,7 @@ they will be documented with the platform.
 * [Clevo](Platform/Intel/ClevoOpenBoardPkg)
 * [Kaby Lake](Platform/Intel/KabylakeOpenBoardPkg)
 * [Purley](Platform/Intel/PurleyOpenBoardPkg)
+* [Whiskey Lake](Platform/Intel/WhiskeylakeOpenBoardPkg)
 
 For more information, see the
 [EDK II Minimum Platform Specification](https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification).
--
2.16.2.windows.1