From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: rangasai.v.chaganty@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Thu, 19 Sep 2019 14:45:31 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2019 14:45:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,526,1559545200"; d="scan'208";a="338794006" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 19 Sep 2019 14:45:31 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 19 Sep 2019 14:45:30 -0700 Received: from fmsmsx104.amr.corp.intel.com ([169.254.3.101]) by FMSMSX151.amr.corp.intel.com ([169.254.7.148]) with mapi id 14.03.0439.000; Thu, 19 Sep 2019 14:45:30 -0700 From: "Chaganty, Rangasai V" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" Subject: Re: [edk2-platforms][PATCH V1 1/1] AdvancedFeaturePkg/Ipmi: Fix X64 GCC Build Failures Thread-Topic: [edk2-platforms][PATCH V1 1/1] AdvancedFeaturePkg/Ipmi: Fix X64 GCC Build Failures Thread-Index: AQHVbxNRszPFww86bUWrOAW0bGbu/qcziN7Q Date: Thu, 19 Sep 2019 21:45:30 +0000 Message-ID: References: <20190919175419.23204-1-michael.a.kubacki@intel.com> In-Reply-To: <20190919175419.23204-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjk4MzljMjctNWQ0MC00Y2M3LWJkZjctYTA0M2EwYTJiYTcyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYU1pc1JESnRIcVpKNFZPQ29wdWd3dnJLWXR4TWM0V2JcL3h4UlFpZlNiYytIa2hVY1JIYjByUCtTZkdNQ09TeUwifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Return-Path: rangasai.v.chaganty@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Kubacki, Michael A=20 Sent: Thursday, September 19, 2019 10:54 AM To: devel@edk2.groups.io Cc: Bi, Dandan ; Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-platforms][PATCH V1 1/1] AdvancedFeaturePkg/Ipmi: Fix X64 GC= C Build Failures REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2204 These build failures can be reproduced simply by building the AdvancedFeatu= rePkg.dsc file in GCC5 for X64 architecture. To build the whole package DSC= (not pull individual features into other packages), set the WORKSPACE vari= able to the edk2 directory in the workspace as is done by executing edksetu= p.sh then create the PACKAGES_PATH variable and add the Platform/Intel and = Silicon/Intel directories to the variable value. Then start the build of Ad= vancedFeaturePkg.dsc: 'build -p AdvancedFeaturePkg/AdvancedFeaturePkg.dsc -a X64' This change adds EFIAPI to the following function declarations so they are = consistent with the declaration for module entry points. * BmcElog.c - InitializeBmcElogLayer () * FrbPei.c - InitializeFrbPei () * IpmiFru.c - InitializeFru () All future contributions to AdvancedFeaturePkg must successfully build in G= CC after this change. Cc: Dandan Bi Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c | 3 ++- Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c | 3 ++- Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c b/Pla= tform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c index e214f1a18b..a6d075b19c 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c @@ -1,7 +1,7 @@ /** @file BMC Event Log functions. =20 -Copyright (c) 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -171,6 +171,7 @@ Returns: } =20 EFI_STATUS +EFIAPI InitializeBmcElogLayer ( IN EFI_HANDLE ImageHandle, IN EFI_SYSTEM_TABLE *SystemTable diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c b/Platform= /Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c index 962cd7cc9b..5d33df0103 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c @@ -1,7 +1,7 @@ /** @file IPMI FRB PEIM. =20 -Copyright (c) 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -51,6 +51,7 @@ SetWatchDogTimer ( } =20 EFI_STATUS +EFIAPI InitializeFrbPei ( IN EFI_PEI_FILE_HANDLE FileHandle, IN CONST EFI_PEI_SERVICES **PeiServices diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c b/Pla= tform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c index 663983fd68..58e1fb4d7e 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c @@ -1,7 +1,7 @@ /** @file IPMI FRU Driver. =20 -Copyright (c) 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -15,6 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include =20 EFI_STATUS +EFIAPI InitializeFru ( IN EFI_HANDLE ImageHandle, IN EFI_SYSTEM_TABLE *SystemTable -- 2.16.2.windows.1