From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.339.1571160033912619206 for ; Tue, 15 Oct 2019 10:20:33 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: rangasai.v.chaganty@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2019 10:20:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,300,1566889200"; d="scan'208";a="185878744" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 15 Oct 2019 10:20:27 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 15 Oct 2019 10:20:26 -0700 Received: from fmsmsx104.amr.corp.intel.com ([169.254.3.133]) by FMSMSX126.amr.corp.intel.com ([169.254.1.167]) with mapi id 14.03.0439.000; Tue, 15 Oct 2019 10:20:26 -0700 From: "Chaganty, Rangasai V" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [edk2-platforms][PATCH V1 1/1] IntelSiliconPkg/BootMediaLib: Reduce library API Thread-Topic: [edk2-platforms][PATCH V1 1/1] IntelSiliconPkg/BootMediaLib: Reduce library API Thread-Index: AQHVgtYHaB0iT51dwk+pv5eZKOhk+6db80Ew Date: Tue, 15 Oct 2019 17:20:25 +0000 Message-ID: References: <20191014212616.18376-1-michael.a.kubacki@intel.com> In-Reply-To: <20191014212616.18376-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmQzYTM5YmUtMDQ1Yi00YTI5LTlkYzgtZTI2NGNiNzJhMzBhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK3hRSE9iR1wvWUlXSFNjR3dVTlwvRWZlZ2xabWlwTDZMNXlIOEVyS1ZnNUhHYlMzQlZSQW5TMnc5Wnp6RGJvVGJUIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Return-Path: rangasai.v.chaganty@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for reducing the redundant APIs. Reviewed-by: Sai Chaganty -----Original Message----- From: Kubacki, Michael A=20 Sent: Monday, October 14, 2019 2:26 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Ni, Ray Subject: [edk2-platforms][PATCH V1 1/1] IntelSiliconPkg/BootMediaLib: Reduc= e library API Removes the following functions from FirmwareBootMediaLib.h: * FirmwareBootMediaIsSpi () * FirmwareBootMediaIsUfs () * FirmwareBootMediaIsEmmc () * FirmwareBootMediaIsNvme () It is preferred to have a single method to retrieve the firmware boot media= . To reduce overall maintenance effort over time, the FirmwareBootMediaIsXx= x () pattern is removed in favor of returning the firmware boot media type = via GetFirmwareBootMediaType (). Cc: Sai Chaganty Cc: Ray Ni Signed-off-by: Michael Kubacki --- Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/DxeSmmFirmware= BootMediaLib.inf | 1 - Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/PeiFirmwareBoo= tMediaLib.inf | 1 - Silicon/Intel/IntelSiliconPkg/Include/Library/FirmwareBootMediaLib.h = | 48 --------- Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/FirmwareBootMe= diaLib.c | 109 -------------------- 4 files changed, 159 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/Dx= eSmmFirmwareBootMediaLib.inf b/Silicon/Intel/IntelSiliconPkg/Library/PeiDxe= SmmBootMediaLib/DxeSmmFirmwareBootMediaLib.inf index 83ed5f04af..7e10b5f7a7 100644 --- a/Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/DxeSmmFir= mwareBootMediaLib.inf +++ b/Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/DxeSmm +++ FirmwareBootMediaLib.inf @@ -27,7 +27,6 @@ # =20 [Sources] - FirmwareBootMediaLib.c DxeSmmFirmwareBootMediaLib.c =20 [Packages] diff --git a/Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/Pe= iFirmwareBootMediaLib.inf b/Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmm= BootMediaLib/PeiFirmwareBootMediaLib.inf index 063c4027d3..ff1da31387 100644 --- a/Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/PeiFirmwa= reBootMediaLib.inf +++ b/Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/PeiFir +++ mwareBootMediaLib.inf @@ -22,7 +22,6 @@ LIBRARY_CLASS =3D FirmwareBootMediaLib =20 [Sources] - FirmwareBootMediaLib.c PeiFirmwareBootMediaLib.c =20 [Packages] diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/FirmwareBootMedi= aLib.h b/Silicon/Intel/IntelSiliconPkg/Include/Library/FirmwareBootMediaLib= .h index aca9593a84..b36ebacf30 100644 --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/FirmwareBootMediaLib.h +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/FirmwareBootMediaLib +++ .h @@ -55,52 +55,4 @@ FirmwareBootMediaIsKnown ( VOID ); =20 -/** - Determines if the platform firmware is booting from SPI. - - @retval TRUE Platform firmware is booting from SPI - @retval FALSE Platform firmware is booting from a non-SPI device o= r the boot media is unknown -**/ -BOOLEAN -EFIAPI -FirmwareBootMediaIsSpi ( - VOID - ); - -/** - Determines if the platform firmware is booting from UFS. - - @retval TRUE Platform firmware is booting from UFS - @retval FALSE Platform firmware is booting from a non-UFS device o= r the boot media is unknown -**/ -BOOLEAN -EFIAPI -FirmwareBootMediaIsUfs ( - VOID - ); - -/** - Determines if the platform firmware is booting from eMMC. - - @retval TRUE Platform firmware is booting from eMMC - @retval FALSE Platform firmware is booting from a non-eMMC device = or the boot media is unknown -**/ -BOOLEAN -EFIAPI -FirmwareBootMediaIsEmmc ( - VOID - ); - -/** - Determines if the platform firmware is booting from NVMe. - - @retval TRUE Platform firmware is booting from NVMe. - @retval FALSE Platform firmware is booting from a non-NVMe device = or the boot media is unknown -**/ -BOOLEAN -EFIAPI -FirmwareBootMediaIsNvme ( - VOID - ); - #endif diff --git a/Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/Fi= rmwareBootMediaLib.c b/Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootM= ediaLib/FirmwareBootMediaLib.c deleted file mode 100644 index 11a14d172d..0000000000 --- a/Silicon/Intel/IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/FirmwareB= ootMediaLib.c +++ /dev/null @@ -1,109 +0,0 @@ -/** @file - This library identifies the firmware boot media device. - - The firmware boot media device is used to make system initialization dec= isions in the boot flow dependent - upon firmware boot media. Note that the firmware boot media is the stora= ge media that the boot firmware is stored on. - It is not the OS storage media which may be stored upon a different non-= volatile storage device. - - This file contains library implementation common to all boot phases. - -Copyright (c) 2019, Intel Corporation. All rights reserved.
-SPDX-License-Identifier: BSD-2-Clause-Patent - -**/ - -#include -#include -#include - -/** - Determines if the platform firmware is booting from SPI. - - @retval TRUE Platform firmware is booting from SPI - @retval FALSE Platform firmware is booting from a non-SPI device o= r the boot media is unknown -**/ -BOOLEAN -EFIAPI -FirmwareBootMediaIsSpi ( - VOID - ) -{ - EFI_STATUS Status; - FW_BOOT_MEDIA_TYPE BootMedia; - - Status =3D GetFirmwareBootMediaType (&BootMedia); - if (EFI_ERROR (Status) || BootMedia !=3D FwBootMediaSpi) { - return FALSE; - } else { - return TRUE; - } -} - -/** - Determines if the platform firmware is booting from UFS. - - @retval TRUE Platform firmware is booting from UFS - @retval FALSE Platform firmware is booting from a non-UFS device o= r the boot media is unknown -**/ -BOOLEAN -EFIAPI -FirmwareBootMediaIsUfs ( - VOID - ) -{ - EFI_STATUS Status; - FW_BOOT_MEDIA_TYPE BootMedia; - - Status =3D GetFirmwareBootMediaType (&BootMedia); - if (EFI_ERROR (Status) || BootMedia !=3D FwBootMediaUfs) { - return FALSE; - } else { - return TRUE; - } -} - -/** - Determines if the platform firmware is booting from eMMC. - - @retval TRUE Platform firmware is booting from eMMC - @retval FALSE Platform firmware is booting from a non-eMMC device = or the boot media is unknown -**/ -BOOLEAN -EFIAPI -FirmwareBootMediaIsEmmc ( - VOID - ) -{ - EFI_STATUS Status; - FW_BOOT_MEDIA_TYPE BootMedia; - - Status =3D GetFirmwareBootMediaType (&BootMedia); - if (EFI_ERROR (Status) || BootMedia !=3D FwBootMediaEmmc) { - return FALSE; - } else { - return TRUE; - } -} - -/** - Determines if the platform firmware is booting from NVMe. - - @retval TRUE Platform firmware is booting from NVMe. - @retval FALSE Platform firmware is booting from a non-NVMe device = or the boot media is unknown -**/ -BOOLEAN -EFIAPI -FirmwareBootMediaIsNvme ( - VOID - ) -{ - EFI_STATUS Status; - FW_BOOT_MEDIA_TYPE BootMedia; - - Status =3D GetFirmwareBootMediaType (&BootMedia); - if (EFI_ERROR (Status) || BootMedia !=3D FwBootMediaNvme) { - return FALSE; - } else { - return TRUE; - } -} -- 2.16.2.windows.1