From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.570.1573808351122841544 for ; Fri, 15 Nov 2019 00:59:11 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: rangasai.v.chaganty@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 00:59:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,307,1569308400"; d="scan'208";a="230395829" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 15 Nov 2019 00:59:10 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 00:59:09 -0800 Received: from fmsmsx104.amr.corp.intel.com ([169.254.3.245]) by fmsmsx156.amr.corp.intel.com ([169.254.13.184]) with mapi id 14.03.0439.000; Fri, 15 Nov 2019 00:59:09 -0800 From: "Chaganty, Rangasai V" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Kubacki, Michael A" Subject: Re: [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM Thread-Topic: [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM Thread-Index: AQHVmrPpyNu1pARUakKKW2HssCJiyaeL8Dew Date: Fri, 15 Nov 2019 08:59:09 +0000 Message-ID: References: <20191114060655.5161-1-nathaniel.l.desimone@intel.com> <20191114060655.5161-2-nathaniel.l.desimone@intel.com> In-Reply-To: <20191114060655.5161-2-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGMxYTc3NzAtZDE4My00OTc1LWJmN2EtYTU4MTBhN2RlNWFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid1JsQW9jQzRXNzlmN05tbGdUQzF6SnNnQWlkYmdFSXNVU0tMbzlmVkQ3Z2RvSWFTUnpxOEhQWE5wQ2RkZWFHQyJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Return-Path: rangasai.v.chaganty@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Desimone, Nathaniel L=20 Sent: Wednesday, November 13, 2019 10:07 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Kubacki, Michael A ; Chaganty, Rangasai V Subject: [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change MODUL= E_TYPE of SiliconInitLib to PEIM This library contains PEI phase only code. For example, ClearIchSmiAndWake() calls PeiServicesGetBootMode(). Accordingly, this library should have never been marked as a BASE library. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone --- .../PeiSiliconInitLib.inf} | 3 ++- .../{SiliconInitLib =3D> PeiSiliconInitLib}/SiliconInit.c | 0 .../{SiliconInitLib =3D> PeiSiliconInitLib}/SiliconInitPreMem.c | 0 3 files changed, 2 insertions(+), 1 deletion(-) rename Silicon/Intel/Kaby= lakeSiliconPkg/Library/{SiliconInitLib/SiliconInitLib.inf =3D> PeiSiliconIn= itLib/PeiSiliconInitLib.inf} (91%) rename Silicon/Intel/KabylakeSiliconPkg= /Library/{SiliconInitLib =3D> PeiSiliconInitLib}/SiliconInit.c (100%) rena= me Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D> PeiSilicon= InitLib}/SiliconInitPreMem.c (100%) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/Silico= nInitLib.inf b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/P= eiSiliconInitLib.inf similarity index 91% rename from Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/Silicon= InitLib.inf rename to Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSil= iconInitLib.inf index 132080e876..ff83bf2835 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLi= b.inf +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSili +++ conInitLib.inf @@ -11,8 +11,9 @@ BASE_NAME =3D SiliconInitLib FILE_GUID = =3D 72CD3A7B-FEA5-4F5E-9165-4DD12187BB13 VERSION_STRING = =3D 1.0- MODULE_TYPE =3D BASE+ MODULE_TYPE = =3D PEIM LIBRARY_CLASS =3D SiliconInit= Lib+ # # The following information is for reference only and not required b= y the build tools. #diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/S= iliconInitLib/SiliconInit.c b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiS= iliconInitLib/SiliconInit.c similarity index 100% rename from Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/Silicon= Init.c rename to Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silico= nInit.c diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/Silico= nInitPreMem.c b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/= SiliconInitPreMem.c similarity index 100% rename from Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/Silicon= InitPreMem.c rename to Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silico= nInitPreMem.c -- 2.23.0.windows.1