From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.3249.1574404954204299614 for ; Thu, 21 Nov 2019 22:42:34 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: rangasai.v.chaganty@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 22:42:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="238500391" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 21 Nov 2019 22:42:33 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:42:33 -0800 Received: from fmsmsx104.amr.corp.intel.com ([169.254.3.245]) by FMSMSX152.amr.corp.intel.com ([169.254.6.123]) with mapi id 14.03.0439.000; Thu, 21 Nov 2019 22:42:33 -0800 From: "Chaganty, Rangasai V" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Kubacki, Michael A" Subject: Re: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments Thread-Topic: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments Thread-Index: AQHVoEn8O/oNn+QR50GPXkCZMneo1qeWv1Xg Date: Fri, 22 Nov 2019 06:42:32 +0000 Message-ID: References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> <20191121085853.2626-4-nathaniel.l.desimone@intel.com> In-Reply-To: <20191121085853.2626-4-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzZiNmMzZTktZGJlMC00OTczLTgxZWYtNmVlYjk3NjE0Y2I4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9OSUFud0ZsdlJKS2RhcFBUd3dzaTVlNmtJYXNvblIxajZUSzlTQjBjNDFUSCtZRmtCNE4rQkdwSm5BMUgzRDcifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Return-Path: rangasai.v.chaganty@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Desimone, Nathaniel L=20 Sent: Thursday, November 21, 2019 12:59 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Kubacki, Michael A ; Chaganty, Rangasai V Subject: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old = comments Cc: Chasel Chiu Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone --- .../Library/PeiSiliconInitLib/SiliconInit.c | 3 +++ .../Library/PeiSiliconInitLib/SiliconInitPreMem.c | 4 +--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Sil= iconInit.c b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Sil= iconInit.c index d09bec0489..2057973d4b 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconIni= t.c +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon +++ Init.c @@ -199,6 +199,9 @@ ClearIchSmiAndWake ( return EFI_SUCCESS; } +/**+ Late Silicon Initialization+**/ VOID LateSi= liconInit ( VOIDdiff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/Pei= SiliconInitLib/SiliconInitPreMem.c b/Silicon/Intel/KabylakeSiliconPkg/Libra= ry/PeiSiliconInitLib/SiliconInitPreMem.c index 65a67a6795..6af9e0fcfc 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconIni= tPreMem.c +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon +++ InitPreMem.c @@ -31,9 +31,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include -/= /@todo it should be moved to Si Pkg. /**- Early Platform PCH initializatio= n+ Early Silicon initialization **/ VOID EarlySiliconInit (@@ -233,4 +232,= 3 @@ SiliconInit ( } }--- 2.24.0.windows.2