From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.3360.1574405330786271635 for ; Thu, 21 Nov 2019 22:48:51 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: rangasai.v.chaganty@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 22:48:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="238501875" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 21 Nov 2019 22:48:50 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:48:49 -0800 Received: from fmsmsx104.amr.corp.intel.com ([169.254.3.245]) by fmsmsx118.amr.corp.intel.com ([169.254.1.68]) with mapi id 14.03.0439.000; Thu, 21 Nov 2019 22:48:49 -0800 From: "Chaganty, Rangasai V" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Kubacki, Michael A" Subject: Re: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup Thread-Topic: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup Thread-Index: AQHVoEn7WG/TmovCG0WFJnhWOXr7mKeWwRHQ Date: Fri, 22 Nov 2019 06:48:48 +0000 Message-ID: References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> <20191121085853.2626-6-nathaniel.l.desimone@intel.com> In-Reply-To: <20191121085853.2626-6-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWU3Y2M1ODQtZmIzZS00M2NlLThlMGUtMDAyMTg5OTY1ZmQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUFVJSlZBRHlyWCtkTTVMMTJmN0RcL2YzNVZ5Y3lWQVlnUDRqUU9pd0FCa203QUZiSUJta01qR2J4V3l3VDZzazQifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Return-Path: rangasai.v.chaganty@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Desimone, Nathaniel L=20 Sent: Thursday, November 21, 2019 12:59 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Kubacki, Michael A ; Chaganty, Rangasai V Subject: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.= h Cleanup Removes duplicate EFI_HOB_GENERIC_HEADER and EFI_HOB_GUID_TYPE definitions = from TcoWdtHob.h Cc: Chasel Chiu Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone --- .../Include/Guid/TcoWdtHob.h | 23 ++----------------- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h b/= Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h index 5bf2527963..9e83ed49c1 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h @@ -7,35 +7,16 @@ #ifndef __TCO_WDT_HOB_H__ #define __TCO_WDT_HOB_H__ +#include + #= define TCO_WDT_HOB_GUID \ { \ 0x3e405418, 0xd8c, 0x4f1a, { 0xb0, 0x55= , 0xbe, 0xf9, 0x8, 0x41, 0x46, 0x8d } \ } -#ifndef _PEI_HOB_H_-#ifndef __= HOB__H__-#ifndef __PI_HOB_H__-typedef struct _EFI_HOB_GENERIC_HEADER {- UI= NT16 HobType;- UINT16 HobLength;- UINT32 Reserved;-} EFI_HOB_GENERIC_H= EADER;--typedef struct _EFI_HOB_GUID_TYPE {- EFI_HOB_GENERIC_HEADER Heade= r;- EFI_GUID Name;- //- // Guid specific data goes here- = //-} EFI_HOB_GUID_TYPE;-#endif-#endif-#endif- typedef struct { EFI_HOB_G= UID_TYPE Header; UINT8 TcoRebootHappened; } TCO_WDT_HOB; #en= dif---=20 2.24.0.windows.2