From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.2744.1574836954977923425 for ; Tue, 26 Nov 2019 22:42:35 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: rangasai.v.chaganty@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2019 22:42:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,248,1571727600"; d="scan'208";a="199079039" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 26 Nov 2019 22:42:34 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 26 Nov 2019 22:42:33 -0800 Received: from fmsmsx104.amr.corp.intel.com ([169.254.3.245]) by FMSMSX126.amr.corp.intel.com ([169.254.1.160]) with mapi id 14.03.0439.000; Tue, 26 Nov 2019 22:42:33 -0800 From: "Chaganty, Rangasai V" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Gao, Zhichao" Subject: Re: [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove ResetSystemLib.h override Thread-Topic: [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove ResetSystemLib.h override Thread-Index: AQHVpM5X0s/aoxngbkySRqgbHjTTV6eej95Q Date: Wed, 27 Nov 2019 06:42:32 +0000 Message-ID: References: <20191127025643.32056-1-michael.a.kubacki@intel.com> <20191127025643.32056-2-michael.a.kubacki@intel.com> In-Reply-To: <20191127025643.32056-2-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmQ0NzRhYzYtY2RjYi00ODZkLWJlOWYtNGFmZGVhNWJiM2U3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVnVpM293MUNZV29IS0Zld1dcL0I0cnJWS0czSHdcLzliTjkzMmxpSDNpYVBYbzlaSmVEY1JqWm1aYjdCVkIrXC9BVCJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Return-Path: rangasai.v.chaganty@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This change is introducing SiliconPkg's dependency on MdeModulePkg. SiliconPkg dependencies should be limited to a selected few packages and th= is seems to be an unnecessary addition to the dependency list. The reset interfaces are providing generic reset services and perhaps bette= r suited in packages like MdePkg. -----Original Message----- From: Kubacki, Michael A=20 Sent: Tuesday, November 26, 2019 6:57 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L = ; Gao, Zhichao Subject: [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove ResetSys= temLib.h override REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2375 Removes a stale ResetSystemLib.h override in KabylakeSiliconPkg that does n= ot contain the prototype for ResetSystem () and ResetPlatformSpecific (). The ResetSystemLib.h file from MdeModulePkg will be used. Any INF files tha= t did not include the MdeModulePkg.dec under [Packages] were updated to do = so. Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Zhichao Gao Signed-off-by: Michael Kubacki --- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/DxeResetSys= temLib.inf | 3 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystemLib/DxeR= untimeResetSystemLib.inf | 3 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPchResetLib= .inf | 3 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiResetSys= temLib.inf | 3 +- Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Library/R= esetSystemLib.h | 62 -------------------- 5 files changed, 8 insertions(+), 66 deletions(-) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib= /DxeResetSystemLib.inf b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRe= setSystemLib/DxeResetSystemLib.inf index aa8877140a..46313bf35f 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/DxeRes= etSystemLib.inf +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/Dxe +++ ResetSystemLib.inf @@ -1,7 +1,7 @@ ## @file # Component description file for Intel Ich7 Reset System Library. # -# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -35,6 +35,7 @@ PchCyc= leDecodingLib =20 [Packages] MdePkg/MdePkg.dec +MdeModulePkg/MdeModulePkg.dec KabylakeSiliconPkg/SiPkg.dec =20 =20 diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSy= stemLib/DxeRuntimeResetSystemLib.inf b/Silicon/Intel/KabylakeSiliconPkg/Pch= /Library/DxeRuntimeResetSystemLib/DxeRuntimeResetSystemLib.inf index 6b27661603..c7fad31c71 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystemLib= /DxeRuntimeResetSystemLib.inf +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystem +++ Lib/DxeRuntimeResetSystemLib.inf @@ -1,7 +1,7 @@ ## @file # Component description file for Intel Ich7 Reset System Library. # -# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -36,6 +36,7 @@ PchCyc= leDecodingLib =20 [Packages] MdePkg/MdePkg.dec +MdeModulePkg/MdeModulePkg.dec KabylakeSiliconPkg/SiPkg.dec =20 =20 diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/Pe= iPchResetLib.inf b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchReset= Lib/PeiPchResetLib.inf index b04f4006ef..29f69078a4 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPchRes= etLib.inf +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPch +++ ResetLib.inf @@ -1,7 +1,7 @@ ## @file # Component description file for PCH Reset Lib Pei Phase # -# Copyright (= c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -28,6 +28,7 @@ ResetS= ystemLib =20 [Packages] MdePkg/MdePkg.dec +MdeModulePkg/MdeModulePkg.dec KabylakeSiliconPkg/SiPkg.dec =20 [Sources] diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib= /PeiResetSystemLib.inf b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiRe= setSystemLib/PeiResetSystemLib.inf index 18a92a6f18..3c6ff78863 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiRes= etSystemLib.inf +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/Pei +++ ResetSystemLib.inf @@ -1,7 +1,7 @@ ## @file # Component description file for Intel Ich7 Reset System Library. # -# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -32,6 +32,7 @@ PchCyc= leDecodingLib =20 [Packages] MdePkg/MdePkg.dec +MdeModulePkg/MdeModulePkg.dec KabylakeSiliconPkg/SiPkg.dec =20 =20 diff --git a/Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Inclu= de/Library/ResetSystemLib.h b/Silicon/Intel/KabylakeSiliconPkg/SampleCode/M= deModulePkg/Include/Library/ResetSystemLib.h deleted file mode 100644 index 75d3e15ed7..0000000000 --- a/Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Libr= ary/ResetSystemLib.h +++ /dev/null @@ -1,62 +0,0 @@ -/** @file - System reset Library Services. This library class defines a set of - methods that reset the whole system. - -Copyright (c) 2005 - 2010, Intel Corporation. All rights reserved.
-SPDX-License-Identifier: BSD-2-Clause-Patent - -**/ - -#ifndef __RESET_SYSTEM_LIB_H__ -#define __RESET_SYSTEM_LIB_H__ - -/** - This function causes a system-wide reset (cold reset), in which - all circuitry within the system returns to its initial state. This type = of reset - is asynchronous to system operation and operates without regard to - cycle boundaries. - - If this function returns, it means that the system does not support cold= reset. -**/ -VOID -EFIAPI -ResetCold ( - VOID - ); - -/** - This function causes a system-wide initialization (warm reset), in which= all processors - are set to their initial state. Pending cycles are not corrupted. - - If this function returns, it means that the system does not support warm= reset. -**/ -VOID -EFIAPI -ResetWarm ( - VOID - ); - -/** - This function causes the system to enter a power state equivalent - to the ACPI G2/S5 or G3 states. - - If this function returns, it means that the system does not support shut= down reset. -**/ -VOID -EFIAPI -ResetShutdown ( - VOID - ); - -/** - This function causes the system to enter S3 and then wake up immediately= . - - If this function returns, it means that the system does not support S3 f= eature. -**/ -VOID -EFIAPI -EnterS3WithImmediateWake ( - VOID - ); - -#endif -- 2.16.2.windows.1