From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.3258.1575362735014497877 for ; Tue, 03 Dec 2019 00:45:35 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: rangasai.v.chaganty@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 00:45:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,272,1571727600"; d="scan'208";a="218582847" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 03 Dec 2019 00:45:34 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Dec 2019 00:45:34 -0800 Received: from fmsmsx104.amr.corp.intel.com ([169.254.3.245]) by FMSMSX157.amr.corp.intel.com ([169.254.14.160]) with mapi id 14.03.0439.000; Tue, 3 Dec 2019 00:45:34 -0800 From: "Chaganty, Rangasai V" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [edk2-platforms][PATCH V2 01/47] AdvancedFeaturePkg: Package DSC style cleanup Thread-Topic: [edk2-platforms][PATCH V2 01/47] AdvancedFeaturePkg: Package DSC style cleanup Thread-Index: AQHVpYgPnNEvG1mIskSX8nWXjQmWt6eoIJbA Date: Tue, 3 Dec 2019 08:45:33 +0000 Message-ID: References: <20191128010614.43628-1-michael.a.kubacki@intel.com> <20191128010614.43628-2-michael.a.kubacki@intel.com> In-Reply-To: <20191128010614.43628-2-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTkxZjc2ZDQtYTkyZC00MjY1LWE5ZjgtNjE2OTMzOGI3NTUxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQUNmSmE0WjRlVVpTRGF3Z05VZW5Ca3pWU1laVWp0R1hNR1BNV01rQmJVdW1IUUFrMDBnekx2YTFHYTFSVG9NSiJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Return-Path: rangasai.v.chaganty@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Kubacki, Michael A=20 Sent: Wednesday, November 27, 2019 5:05 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-platforms][PATCH V2 01/47] AdvancedFeaturePkg: Package DSC s= tyle cleanup This change refactors AdvancedFeaturePkg.dsc to consolidate redundant secti= ons and better group file content to improve maintainability and readabilit= y. This pattern is being applied in all Minimum Platform package DSC files. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 133 +++++++++++= --------- 1 file changed, 71 insertions(+), 62 deletions(-) diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Pla= tform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index b2e7ab8302..b83e72b48c 100644 --- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -1,5 +1,5 @@ ## @file -# Platform description. +# Advanced Feature Package build description file. # # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
= # @@ -24,8 +24,7 @@ =20 ##########################################################################= ###### # -# SKU Identification section - list of all SKU IDs supported by this -# Platform. +# SKU Identification section - list of all SKU IDs supported. # ##########################################################################= ###### [SkuIds] @@ -33,88 +32,93 @@ =20 ##########################################################################= ###### # -# Pcd Section - list of all EDK II PCD Entries defined by this Platform +# Pcd Section - list of all EDK II PCD Entries defined by this package. # ##########################################################################= ###### - =20 + [PcdsFeatureFlag] =20 ##########################################################################= ###### # -# Library Class section - list of all Library Classes needed by this Platf= orm. +# Library Class section - list of all Library Classes needed by this packa= ge. # ##########################################################################= ###### =20 [LibraryClasses.common] - - PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf - PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf - DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf - UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry= Point.inf - UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiA= pplicationEntryPoint.inf - SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf - PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeC= offExtraActionLibNull.inf - - # - # Basic - # + ####################################### + # Edk2 Packages + ####################################### BaseLib|MdePkg/Library/BaseLib/BaseLib.inf BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf - - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf + =20 + BasePciLibPciExpress|MdePkg/Library/BasePciLibPciExpress/BasePciLibPci + Express.inf =20 + CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMa + intenanceLib.inf CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf + DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf + =20 + DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.i + nf DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf + =20 + DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTabl + eLib.inf HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf - PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.i= nf - PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf - BasePciLibPciExpress|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciEx= press.inf -# PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf - CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMain= tenanceLib.inf - PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf + PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf + =20 + PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci + .inf =20 + PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BaseP + eCoffExtraActionLibNull.inf PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeC= offGetEntryPointLib.inf + PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf + =20 + PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.i + nf PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf + PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf + =20 + PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibId + t/PeiServicesTablePointerLibIdt.inf + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf + =20 + ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseRep + ortStatusCodeLibNull.inf =20 + SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPo + rtLib16550.inf SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf - # - # UEFI & PI - # + =20 + TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTempl + ate.inf =20 + UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/Uef + iApplicationEntryPoint.inf UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBoo= tServicesTableLib.inf - UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/U= efiRuntimeServicesTableLib.inf - UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf - HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf - UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServic= esLib.inf - DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf - - UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompres= sLib.inf - PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/= PeiServicesTablePointerLibIdt.inf - PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf - DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf - DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableL= ib.inf UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf - - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf - ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseRepor= tStatusCodeLibNull.inf - - PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf - - TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplat= e.inf - - IpmiPlatformHookLib|AdvancedFeaturePkg/Ipmi/Library/IpmiPlatformHookLibN= ull/IpmiPlatformHookLibNull.inf - IpmiLib|AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.inf + =20 + UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompr + essLib.inf =20 + UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEnt + ryPoint.inf =20 + UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServ + icesLib.inf UefiLib|MdePkg/Library/UefiLib/UefiLib.inf + UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf + =20 + UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib + /UefiRuntimeServicesTableLib.inf + + ####################################### + # Advanced Feature Package + ####################################### IpmiCommandLib|AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiComman= dLib.inf + IpmiLib|AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.inf + =20 + IpmiPlatformHookLib|AdvancedFeaturePkg/Ipmi/Library/IpmiPlatformHookLi + bNull/IpmiPlatformHookLibNull.inf =20 [LibraryClasses.common.SEC,LibraryClasses.common.PEI_CORE,LibraryClasses.c= ommon.PEIM] - PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf + ####################################### + # Edk2 Packages + ####################################### HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAlloc= ationLib.inf + PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf + + ####################################### + # Silicon Initialization Package + ####################################### SmmAccessLib|IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/P= eiSmmAccessLib.inf =20 [LibraryClasses.common.DXE_CORE,LibraryClasses.common.DXE_SMM_DRIVER,Libra= ryClasses.common.SMM_CORE,LibraryClasses.common.DXE_DRIVER,LibraryClasses.c= ommon.DXE_RUNTIME_DRIVER,LibraryClasses.common.UEFI_DRIVER,LibraryClasses.c= ommon.UEFI_APPLICATION] + ####################################### + # Edk2 Packages + ####################################### HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf - PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAll= ocationLib.inf + PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf =20 [LibraryClasses.common.DXE_SMM_DRIVER,LibraryClasses.common.SMM_CORE] + ####################################### + # Edk2 Packages + ####################################### SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableL= ib.inf =20 ##########################################################################= ######################### @@ -137,20 +141,25 @@ ##########################################################################= ######################### =20 [Components] + ####################################### + # Advanced Feature Package + ####################################### =20 - AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf + # Add library instances here that are not included in package=20 + components and should be tested # in the package build. =20 - AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.inf - AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.inf - AdvancedFeaturePkg/Ipmi/Frb/FrbPei.inf + # Add components here that should be included in the package build. + AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcAcpi.inf + AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.inf AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.inf + AdvancedFeaturePkg/Ipmi/Frb/FrbPei.inf + AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.inf + AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.inf + AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.inf AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.inf AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.inf - AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.inf - AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.inf - AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcAcpi.inf - AdvancedFeaturePkg/S3/S3Pei.inf + AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf =20 [BuildOptions] - *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES \ No newline at = end of file + *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES -- 2.16.2.windows.1