From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.943.1575445994946292129 for ; Tue, 03 Dec 2019 23:53:15 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: rangasai.v.chaganty@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 23:53:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,276,1571727600"; d="scan'208";a="218856303" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 03 Dec 2019 23:53:13 -0800 Received: from fmsmsx104.amr.corp.intel.com ([169.254.3.245]) by FMSMSX105.amr.corp.intel.com ([169.254.4.231]) with mapi id 14.03.0439.000; Tue, 3 Dec 2019 23:53:13 -0800 From: "Chaganty, Rangasai V" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [edk2-platforms][PATCH V2 13/47] Features/Intel/IpmiFeaturePkg: Add initial package Thread-Topic: [edk2-platforms][PATCH V2 13/47] Features/Intel/IpmiFeaturePkg: Add initial package Thread-Index: AQHVpYgtRpNw9Mv9iE2wb7kA4fY97KeppJ2w Date: Wed, 4 Dec 2019 07:53:13 +0000 Message-ID: References: <20191128010614.43628-1-michael.a.kubacki@intel.com> <20191128010614.43628-14-michael.a.kubacki@intel.com> In-Reply-To: <20191128010614.43628-14-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2NkMzdjZGEtMmExZi00ZmNhLWFkYWQtOGUwODhhMzlhZmMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMEI0SElUb2NWTHNKVjl4ZHpSNzQ5aUlrMjFXYkRjWXZBN2dGZSttemw5bVBrdzlFS3NTNEZWMW5GZzMrbURrcSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Kubacki, Michael A=20 Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-platforms][PATCH V2 13/47] Features/Intel/IpmiFeaturePkg: Ad= d initial package Adds a new feature package for the IPMI feature. This change updates the advanced feature package template for IPMI and adds= the updated template to the IpmiFeaturePkg. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec |= 29 +++++++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc |= 24 ++++++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf |= 8 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory= .fdf | 8 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md |= 89 ++++++++++++++++++++ 5 files changed, 158 insertions(+) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeatureP= kg.dec b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d= ec new file mode 100644 index 0000000000..dfa8888e88 --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d +++ ec @@ -0,0 +1,29 @@ +## @file +# This package provides advanced feature functionality to enable the #=20 +Intelligent Platform Management Interface (IPMI). +# This package should only depend on EDK II Core packages, IntelSiliconPkg= , and MinPlatformPkg. +# +# The DEC files are used by the utilities that parse DSC and # INF=20 +files to generate AutoGen.c and AutoGen.h files # for the build=20 +infrastructure. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# #=20 +SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +[Defines] + DEC_SPECIFICATION =3D 0x00010017 + PACKAGE_NAME =3D IpmiFeaturePkg + PACKAGE_GUID =3D AE091910-F6C9-4AB5-B8B4-995E2F0D5166 + PACKAGE_VERSION =3D 0.1 + +[Includes] + Include + +[Guids] + gIpmiFeaturePkgTokenSpaceGuid =3D {0xc05283f6, 0xd6a8, 0x48f3, {0x9b,= =20 +0x59, 0xfb, 0xca, 0x71, 0x32, 0x0f, 0x12}} + +[PcdsFeatureFlag] + =20 +gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable|FALSE|BOOLEAN|0xA000 +0001 diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeatureP= kg.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d= sc new file mode 100644 index 0000000000..1952ba185e --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d +++ sc @@ -0,0 +1,24 @@ +## @file +# This package provides advanced feature functionality to enable the #=20 +Intelligent Platform Management Interface (IPMI). +# This package should only depend on EDK II Core packages, IntelSiliconPkg= , and MinPlatformPkg. +# +# The DEC files are used by the utilities that parse DSC and # INF=20 +files to generate AutoGen.c and AutoGen.h files # for the build=20 +infrastructure. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# #=20 +SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +[Defines] + PLATFORM_NAME =3D IpmiFeaturePkg + PLATFORM_GUID =3D 7B2E74D7-9538-4818-B51A-492F3D33BD20 + PLATFORM_VERSION =3D 0.1 + DSC_SPECIFICATION =3D 0x00010005 + OUTPUT_DIRECTORY =3D Build/$(PLATFORM_NAME) + SUPPORTED_ARCHITECTURES =3D IA32|X64 + BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT + SKUID_IDENTIFIER =3D DEFAULT diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Post= Memory.fdf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Post= Memory.fdf new file mode 100644 index 0000000000..c3847c54c7 --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemo +++ ry.fdf @@ -0,0 +1,8 @@ +## @file +# FDF file for post-memory modules that enable Intelligent Platform Manag= ement Interface. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# #=20 +SPDX-License-Identifier: BSD-2-Clause-Patent # ## diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreM= emory.fdf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMe= mory.fdf new file mode 100644 index 0000000000..0c82d7eb02 --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemor +++ y.fdf @@ -0,0 +1,8 @@ +## @file +# FDF file for pre-memory modules that enable Intelligent Platform Manage= ment Interface. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# #=20 +SPDX-License-Identifier: BSD-2-Clause-Patent # ## diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md b/= Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md new file mode 100644 index 0000000000..e70f1e850b --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md @@ -0,0 +1,89 @@ +# Overview +* **Feature Name:** Intelligent Platform Management Interface (IPMI) +* **PI Phase(s) Supported:** PEI, DXE +* **SMM Required?** No + +More Information: +* [IPMI Specification 2nd Generation=20 +v2.0](https://www.intel.com/content/dam/www/public/us/en/documents/prod +uct-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf) + +## Purpose +The IPMI feature provides firmware functionality that implements=20 +behavior described in the IPMI specification. IPMI enables out-of-band and= monitoring capabilities independent of the host system's CPU, firmware, an= d operating system. + +# High-Level Theory of Operation +*_TODO_* +A description of how the device works at a high-level. + +The description should not be constrained to implementation details but=20 +provide a simple mental model of how the feature is supposed to work. + +## Firmware Volumes +*_TODO_* +A bulleted list of the firmware volumes that feature module(s) are placed = in. + +## Modules +*_TODO_* +A bulleted list of the modules that make up the feature. + +## +*_TODO_* +Each module in the feature should have a section that describes the=20 +module in a level of detail that is useful to better understand the module= source code. + +## +*_TODO_* +Each library in the feature should have a section that describes the=20 +library in a level of detail that is useful to better understand the libra= ry source code. + +## Key Functions +*_TODO_* +A bulleted list of key functions for interacting with the feature. + +Not all features need to be listed. Only functions exposed through=20 +external interfaces that are important for feature users to be aware of. + +## Configuration +*_TODO_* +Information that is useful for configuring the feature. + +Not all configuration options need to be listed. This section is used=20 +to provide more background on configuration options than possible elsewher= e. + +## Data Flows +*_TODO_* +Architecturally defined data structures and flows for the feature. + +## Control Flows +*_TODO_* +Key control flows for the feature. + +## Build Flows +*_TODO_* +Any special build flows should be described in this section. + +This is particularly useful for features that use custom build tools or=20 +require non-standard tool configuration. If the standard flow in the featu= re package template is used, this section may be empty. + +## Test Point Results +*_TODO_* +The test(s) that can verify porting is complete for the feature. + +Each feature must describe at least one test point to verify the=20 +feature is successful. If the test point is not implemented, this should b= e stated. + +## Functional Exit Criteria +*_TODO_* +The testable functionality for the feature. + +This section should provide an ordered list of criteria that a board=20 +integrator can reference to ensure the feature is functional on their boar= d. + +## Feature Enabling Checklist +*_TODO_* +An ordered list of required activities to achieve desired functionality fo= r the feature. + +## Common Optimizations +*_TODO_* +Common size or performance tuning options for this feature. + +This section is recommended but not required. If not used, the contents sh= ould be left empty. -- 2.16.2.windows.1