From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from loongson.cn (loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web08.16315.1650504897118782572 for ; Wed, 20 Apr 2022 18:34:57 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: loongson.cn, ip: 114.242.206.163, mailfrom: lichao@loongson.cn) Received: from lichao-PC (unknown [10.40.24.65]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxXxO7tGBipakqAA--.53880S2; Thu, 21 Apr 2022 09:34:51 +0800 (CST) Date: Thu, 21 Apr 2022 09:34:51 +0800 From: "Chao Li" To: "=?utf-8?Q?devel=40edk2.groups.io?=" , "=?utf-8?Q?mikuback=40linux.microsoft.com?=" Cc: "=?utf-8?Q?=22devel=40edk2.groups.io=22?=" , "=?utf-8?Q?=22michael.d.kinney=40intel.com=22?=" , "=?utf-8?Q?=22quic=5Frcran=40quicinc.com=22?=" , "=?utf-8?Q?=22spbrogan=40outlook.com=22?=" Message-ID: In-Reply-To: References: Subject: Re: [edk2-devel] Some questions about Azure CI X-Mailer: Mailspring MIME-Version: 1.0 X-CM-TRANSID: AQAAf9DxXxO7tGBipakqAA--.53880S2 X-Coremail-Antispam: 1UD129KBjvJXoW3Xw1DAFyrtFy3tw1fCry3Arb_yoWfKFW7pF ZxK3W3Crs8A3yjkr4vq3WUXw12qrn5Gr4UX3W5t34kZFn0kF97trW7tr4rCFyDCrZ5Jw1U Xr1Yvwn7XF1UA3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUmmb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I 8E87Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG67k0 8I80eVWUJVW8JwAqx4xG64xvF2IEw4CE5I8CrVC2j2Wl5I8CrVAKz4kIr2xC04v26r4j6r yUMc02F40Ex7xS67I2xxkvbII20VAFz48EcVAYj21lYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4l Yx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrw Cjr7xvwVCIw2I0I7xG6c02F41lc2xSY4AK6svPMxAIw28IcxkI7VAKI48JMxC20s026xCa FVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_JrI_JrWlx2IqxVCjr7xvwVAFwI0_JrI_Jr Wlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j 6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_WF yUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4U YxBIdaVFxhVjvjDU0xZFpf9x07bo2-OUUUUU= X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQADCF3QvPPUNwAEsv Content-Type: multipart/alternative; boundary="6260b4bb_597f7a27_1b64" --6260b4bb_597f7a27_1b64 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Micheal, Sorry for my so carelessness, I actually fixed our code yesterday, I think = this bug was brought on by when I modified the code formatting, I will chec= k carefully next time. Sorry again. -- Thanks, Chao ------------------------ On 4=E6=9C=88 20 2022, at 10:45 =E6=99=9A=E4=B8=8A, "Michael Kubacki" wrote: > My understanding is that you were referring to the document on my fork > being difficult to access and you shared a link to your CI results that > does not have the message pointing to the wiki page yet. > > This is all correct. The wiki content has moved from my fork to the > official wiki page and the patch that adds the message to the CI results > has not been merged yet. It is posted on the mailing list here and > waiting for reviews: > > https://edk2.groups.io/g/devel/message/89098 > --- > As for your build failing between yesterday and today, note that the > builds are based on different commits. > > Yesterday: > https://github.com/loongson/edk2/commit/8d100910a2ad98b71acaabc0dcdd70be7= e0eba63 > > Today: > https://github.com/loongson/edk2/commit/6ca5d9d6c55ca773a652fe52508e980c7= aa372d3 > > The commits have different content. In particular, I took a quick look > at a build that is failing now (Build_GCC5 TARGET_MDEMODULE_DEBUG) but > previously succeeded. > > The compilation step is failing for reasons such as the following: > INFO - > /home/vsts/work/1/s/MdePkg/Include/LoongArch64/ProcessorBind.h:35:24: > error: expected =E2=80=98=3D=E2=80=99, =E2=80=98,=E2=80=99, =E2=80=98;=E2= =80=99, =E2=80=98asm=E2=80=99 or =E2=80=98__attribute__=E2=80=99 before =E2= =80=98UINT16=E2=80=99 > INFO - 35 | typedef unsigned shor UINT16; > > Notice, that there is a typo introduced in the new commit. "shor" versus > "short", this is what is causing compilation failure. > > Here is a comparison of those two commits showing the line in > ProcessorBind.h that is causing the problem: > > https://github.com/loongson/edk2/compare/8d10091..6ca5d9d#diff-50b24eb92c= 5785d5c70097a70104040fcacfb70225dd8196c1a97ef3bbb305c8R35-R36 > Regards, > Michael > > On 4/20/2022 7:08 AM, Chao Li wrote: > > Hi Micheal, > > > > Do you know if anyone has modified the Azure CI today? I did a CI test > > today, and many modules reported errors, but yesterday, only two module= s > > reported errors, I don't know what happened. Please refer following two > > links: > > > > Today: > > https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId= =3D32&view=3Dresults > > > > Yesterday: > > https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId= =3D31&view=3Dresults > > > > > > -- > > Thanks, > > Chao > > ------------------------ > > > > > > On 4=E6=9C=88 20 2022, at 6:10 =E6=99=9A=E4=B8=8A, Chao Li wrote: > > > > Hi Micheal, > > > > Sorry for late reply, I'm busy with other things, focusing on > > modifying our code, refer to the detailed error log file. > > > > I am learning how to get the detailed log from this link: > > https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify= _instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-e= rrors-in-continuous-integration-ci > > . > > I didn't find the detailed log link in the Azure error log, it looks > > like: > > https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId= =3D31&view=3Dlogs&j=3D9701361e-2546-5093-77e5-58c75d95b7ce&t=3D27131ef8-75e= 1-57c3-3236-d806181f2f1f > > . > > > > -- > > Thanks, > > Chao > > ------------------------ > > > > > > On 4=E6=9C=88 20 2022, at 9:56 =E4=B8=8A=E5=8D=88, "Michael Kubacki" > > wrote: > > > > Hi Chao, > > > > Are you referring to the change I made to put the link to the > > instructions in the build log. Here's an example of what that > > will look > > like: > > > > https://github.com/makubacki/tianocore.github.io/blob/temp_show_uncrust= ify_ci_link_in_build_log/images/edk-ii-code-formatting/temp-example-instruc= tion-link-in-build-log.png?raw=3Dtrue > > > > (some of the words running together are not in the actual change) > > > > I'm open to moving it elsewhere but developers will need to know > > how to > > at least find that or they will have trouble fixing build issues. > > > > Regards, > > Michael > > > > > > On 4/19/2022 9:46 PM, Chao Li wrote: > > > Hi Micheal, > > > Using the way your provided the link, I found the detail log, > > thanks, > > > but this way is not friendly to newbies, because they don't > > know how to > > > find the tutorial.:) > > > > > > -- > > > Thanks, > > > Chao > > > ------------------------ > > > > > > > > > On 4=E6=9C=88 20 2022, at 7:43 =E6=97=A9=E4=B8=8A, "Michael Kubacki" > > > wrote: > > > > > > The wiki update is here: > > > > > https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify= _instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-e= rrors-in-continuous-integration-ci > > > > > > I am waiting for permissions to be updated so I can update > > the actual > > > wiki page and then I'll send a patch for the plugin change > > with the link > > > to that section. > > > > > > Regards, > > > Michael > > > > > > On 4/19/2022 6:15 PM, Michael Kubacki wrote: > > > > I agree that is ideal but I'm not aware of how to do that > > at the > > > moment. > > > > > > > > Thanks, > > > > Michael > > > > > > > > On 4/19/2022 4:52 PM, Michael D Kinney wrote: > > > >> Hi Michael, > > > >> > > > >> Can the build log provide a direct link to the log file > > artifact > > > if an > > > >> error is detected? > > > >> > > > >> Mike > > > >> > > > >>> -----Original Message----- > > > >>> From: devel@edk2.groups.io On > > Behalf Of > > > >>> Michael Kubacki > > > >>> Sent: Tuesday, April 19, 2022 12:42 PM > > > >>> To: devel@edk2.groups.io; quic_rcran@quicinc.com; > > > >>> spbrogan@outlook.com; Chao Li > > > >>> Subject: Re: [edk2-devel] Some questions about Azure CI > > > >>> > > > >>> Hi Rebecca, > > > >>> > > > >>> We are trying to keep the results reporting experience > > > consistent with > > > >>> other plugins and prevent an overwhelming amount of > > information > > > being > > > >>> printed to the build log. > > > >>> > > > >>> In case other errors are present, providing high-level > > > information from > > > >>> each plugin can help point the user in the right direction to > > > get more > > > >>> detail. > > > >>> > > > >>> I completely understand the concern though, so I'm > > planning to make > > > >>> another step toward providing more information about how to > > > debug an > > > >>> issue, when it occurs. That is to put the step-by-step > > > information about > > > >>> where to find the file diff into the EDK II Code Formatting > > > wiki page > > > >>> and then if a failure occurs, print a link to that section of > > > the wiki > > > >>> page. I am hoping this will provide sufficient information to > > > get to the > > > >>> file diff at the point of failure. > > > >>> > > > >>> I should be able to send these patches later today. > > > >>> > > > >>> Regards, > > > >>> Michael > > > >>> > > > >>> On 4/19/2022 12:43 PM, Rebecca Cran wrote: > > > >>>> Since people are going to keep running into this, could we > > > just output > > > >>>> the file diff to the console? That would avoid having to go > > > hunting for > > > >>>> the log file. > > > >>>> > > > >>> > > > >>> > > > >>> > > > >>> > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > > > > > > > Sent from Mailspring > > >=20 > > > > Sent from Mailspring > --6260b4bb_597f7a27_1b64 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
Hi Micheal,

Sorry for my so carelessness, I actually fix= ed our code yesterday, I think this bug was brought on by when I modified t= he code formatting, I will check carefully next time. Sorry again.

--
Thanks,
Chao
------------------------


On 4=E6=9C=88 20 2022, = at 10:45 =E6=99=9A=E4=B8=8A, "Michael Kubacki" <mikuback@linux.microsoft= .com> wrote:
My understanding is that you wer= e referring to the document on my fork
being difficult to access = and you shared a link to your CI results that
does not have the m= essage pointing to the wiki page yet.

This is all correct. Th= e wiki content has moved from my fork to the
official wiki page a= nd the patch that adds the message to the CI results
has not been= merged yet. It is posted on the mailing list here and
waiting fo= r reviews:

https://edk2.groups.io/g/devel/message/89098
=
---

As for your build failing between yesterday and = today, note that the
builds are based on different commits.
=
Yesterday:
https://github.com/loongson/edk2/commit/8d100= 910a2ad98b71acaabc0dcdd70be7e0eba63

Today:
https://= github.com/loongson/edk2/commit/6ca5d9d6c55ca773a652fe52508e980c7aa372d3
The commits have different content. In particular, I took a qui= ck look
at a build that is failing now (Build_GCC5 TARGET_MDEMODU= LE_DEBUG) but
previously succeeded.

The compilation= step is failing for reasons such as the following:

INFO -
/home/vsts/work/1/s/MdePkg/Include/LoongArch64/ProcessorBind.h:35:2= 4:
error: expected =E2=80=98=3D=E2=80=99, =E2=80=98,=E2=80=99, = =E2=80=98;=E2=80=99, =E2=80=98asm=E2=80=99 or =E2=80=98__attribute__=E2=80= =99 before =E2=80=98UINT16=E2=80=99
INFO - 35 | typedef unsigned = shor UINT16;

Notice, that there is a typo introduced in the n= ew commit. "shor" versus
"short", this is what is causing compila= tion failure.

Here is a comparison of those two commits showi= ng the line in
ProcessorBind.h that is causing the problem:
=
https://github.com/loongson/edk2/compare/8d10091..6ca5d9d#diff-50b= 24eb92c5785d5c70097a70104040fcacfb70225dd8196c1a97ef3bbb305c8R35-R36
<= br>
Regards,
Michael

On 4/20/2022 7:08 AM, Chao= Li wrote:
> Hi Micheal,
>
> Do you = know if anyone has modified the Azure CI today? I did a CI test
&= gt; today, and many modules reported errors, but yesterday, only two module= s
> reported errors, I don't know what happened. Please refer = following two
> links:
>
> Today:
> https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results= ?buildId=3D32&view=3Dresults
> <https://link.getmailspr= ing.com/link/3FB8CF0A-BF1B-4A0A-924B-3B5F6D7EB834@getmailspring.com/0?redir= ect=3Dhttps%3A%2F%2Fdev.azure.com%2Fkilaterlee%2FLoongArch_edk2%2F_build%2F= results%3FbuildId%3D32%26view%3Dresults&recipient=3DbWlrdWJhY2tAbGludXg= ubWljcm9zb2Z0LmNvbQ%3D%3D>
> Yesterday:
> http= s://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=3D31&= ;view=3Dresults
> <https://link.getmailspring.com/link/3FB8= CF0A-BF1B-4A0A-924B-3B5F6D7EB834@getmailspring.com/1?redirect=3Dhttps%3A%2F= %2Fdev.azure.com%2Fkilaterlee%2FLoongArch_edk2%2F_build%2Fresults%3FbuildId= %3D31%26view%3Dresults&recipient=3DbWlrdWJhY2tAbGludXgubWljcm9zb2Z0LmNv= bQ%3D%3D>
>
> --
> Thanks,
<= div>> Chao
> ------------------------
>
<= div>>
> On 4=E6=9C=88 20 2022, at 6:10 =E6=99=9A=E4=B8=8A, = Chao Li <lichao@loongson.cn> wrote:
>
> Hi = Micheal,
>
> Sorry for late reply, I'm busy with = other things, focusing on
> modifying our code, refer to the d= etailed error log file.
>
> I am learning how to = get the detailed log from this link:
> https://github.com/maku= backi/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-F= ormatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integra= tion-ci
> <https://link.getmailspring.com/link/3FB8CF0A-BF1= B-4A0A-924B-3B5F6D7EB834@getmailspring.com/2?redirect=3Dhttps%3A%2F%2Flink.= getmailspring.com%2Flink%2FCA5CE175-A392-4D5E-9BE9-392B7A97BB32%40getmailsp= ring.com%2F0%3Fredirect%3Dhttps%253A%252F%252Fgithub.com%252Fmakubacki%252F= tianocore.github.io%252Fblob%252Fadd_ci_uncrustify_instructions%252FEDK-II-= Code-Formatting.md%2523how-to-find-uncrustify-formatting-errors-in-continuo= us-integration-ci%26recipient%3DZGV2ZWxAZWRrMi5ncm91cHMuaW8%253D&recipi= ent=3DbWlrdWJhY2tAbGludXgubWljcm9zb2Z0LmNvbQ%3D%3D>.
> I di= dn't find the detailed log link in the Azure error log, it looks
= > like:
> https://dev.azure.com/kilaterlee/LoongArch_edk2/_= build/results?buildId=3D31&view=3Dlogs&j=3D9701361e-2546-5093-77e5-= 58c75d95b7ce&t=3D27131ef8-75e1-57c3-3236-d806181f2f1f
> &l= t;https://link.getmailspring.com/link/3FB8CF0A-BF1B-4A0A-924B-3B5F6D7EB834@= getmailspring.com/3?redirect=3Dhttps%3A%2F%2Flink.getmailspring.com%2Flink%= 2FCA5CE175-A392-4D5E-9BE9-392B7A97BB32%40getmailspring.com%2F1%3Fredirect%3= Dhttps%253A%252F%252Fdev.azure.com%252Fkilaterlee%252FLoongArch_edk2%252F_b= uild%252Fresults%253FbuildId%253D31%2526view%253Dlogs%2526j%253D9701361e-25= 46-5093-77e5-58c75d95b7ce%2526t%253D27131ef8-75e1-57c3-3236-d806181f2f1f%26= recipient%3DZGV2ZWxAZWRrMi5ncm91cHMuaW8%253D&recipient=3DbWlrdWJhY2tAbG= ludXgubWljcm9zb2Z0LmNvbQ%3D%3D>.
>
> --
<= div>> Thanks,
> Chao
> -----------------------= -
>
>
> On 4=E6=9C=88 20 2022, at 9:= 56 =E4=B8=8A=E5=8D=88, "Michael Kubacki"
> <mikuback@linux.= microsoft.com> wrote:
>
> Hi Chao,
&= gt;
> Are you referring to the change I made to put the link t= o the
> instructions in the build log. Here's an example of wh= at that
> will look
> like:
>
<= div>> https://github.com/makubacki/tianocore.github.io/blob/temp_show_un= crustify_ci_link_in_build_log/images/edk-ii-code-formatting/temp-example-in= struction-link-in-build-log.png?raw=3Dtrue
>
> (s= ome of the words running together are not in the actual change)
&= gt;
> I'm open to moving it elsewhere but developers will need= to know
> how to
> at least find that or they wi= ll have trouble fixing build issues.
>
> Regards,=
> Michael
>
>
> On 4/1= 9/2022 9:46 PM, Chao Li wrote:
> > Hi Micheal,
&g= t; > Using the way your provided the link, I found the detail log,
=
> thanks,
> > but this way is not friendly to newbi= es, because they don't
> know how to
> > find = the tutorial.:)
> >
> > --
> &= gt; Thanks,
> > Chao
> > ------------------= ------
> >
> >
> > On 4=E6= =9C=88 20 2022, at 7:43 =E6=97=A9=E4=B8=8A, "Michael Kubacki"
>= ; > <mikuback@linux.microsoft.com> wrote:
> >
> > The wiki update is here:
> >
>= https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_in= structions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-erro= rs-in-continuous-integration-ci
> >
> > I a= m waiting for permissions to be updated so I can update
> the = actual
> > wiki page and then I'll send a patch for the plu= gin change
> with the link
> > to that section= .
> >
> > Regards,
> > Mich= ael
> >
> > On 4/19/2022 6:15 PM, Michael K= ubacki wrote:
> > > I agree that is ideal but I'm not aw= are of how to do that
> at the
> > moment.
> > >
> > > Thanks,
> > = > Michael
> > >
> > > On 4/19/2022= 4:52 PM, Michael D Kinney wrote:
> > >> Hi Michael,<= /div>
> > >>
> > >> Can the build log= provide a direct link to the log file
> artifact
&g= t; > if an
> > >> error is detected?
>= ; > >>
> > >> Mike
> > >&= gt;
> > >>> -----Original Message-----
&= gt; > >>> From: devel@edk2.groups.io <devel@edk2.groups.io&g= t; On
> Behalf Of
> > >>> Michael Kub= acki
> > >>> Sent: Tuesday, April 19, 2022 12:42 P= M
> > >>> To: devel@edk2.groups.io; quic_rcran@qui= cinc.com;
> > >>> spbrogan@outlook.com; Chao Li &l= t;lichao@loongson.cn>
> > >>> Subject: Re: [edk= 2-devel] Some questions about Azure CI
> > >>>
> > >>> Hi Rebecca,
> > >>><= /div>
> > >>> We are trying to keep the results reportin= g experience
> > consistent with
> > >&g= t;> other plugins and prevent an overwhelming amount of
> i= nformation
> > being
> > >>> print= ed to the build log.
> > >>>
> > &= gt;>> In case other errors are present, providing high-level
> > information from
> > >>> each plugin c= an help point the user in the right direction to
> > get mo= re
> > >>> detail.
> > >>>= ;
> > >>> I completely understand the concern thou= gh, so I'm
> planning to make
> > >>>= another step toward providing more information about how to
>= > debug an
> > >>> issue, when it occurs. That= is to put the step-by-step
> > information about
> > >>> where to find the file diff into the EDK II Code Fo= rmatting
> > wiki page
> > >>> and= then if a failure occurs, print a link to that section of
> &= gt; the wiki
> > >>> page. I am hoping this will p= rovide sufficient information to
> > get to the
&= gt; > >>> file diff at the point of failure.
> >= ; >>>
> > >>> I should be able to send th= ese patches later today.
> > >>>
> &g= t; >>> Regards,
> > >>> Michael
> > >>>
> > >>> On 4/19/2022 12:43= PM, Rebecca Cran wrote:
> > >>>> Since people = are going to keep running into this, could we
> > just outp= ut
> > >>>> the file diff to the console? That = would avoid having to go
> > hunting for
> >= ; >>>> the log file.
> > >>>>
=
> > >>>
> > >>>
>= > >>>
> > >>>
> > >= ;>
> > >>
> > >>
&= gt; > >>
> > >>
> > >>=
> >
> >
> > Sent from Mail= spring
>
> Sent from Mailspring
3D"Sent --6260b4bb_597f7a27_1b64--