public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Re: [PATCH] CryptoPkg: Fix "responsiblity" typos
       [not found] <1470430825-14473-1-git-send-email-thuth@redhat.com>
@ 2016-08-07 14:04 ` Long, Qin
  2016-08-11  7:27   ` Wu, Jiaxin
  0 siblings, 1 reply; 2+ messages in thread
From: Long, Qin @ 2016-08-07 14:04 UTC (permalink / raw)
  To: Thomas Huth, edk2-devel@ml01.01.org; +Cc: Ye, Ting

Reviewed-by: Qin Long <qin.long@intel.com>

Best Regards & Thanks,
LONG, Qin

> -----Original Message-----
> From: Thomas Huth [mailto:thuth@redhat.com]
> Sent: Saturday, August 6, 2016 5:00 AM
> To: edk2-devel@ml01.01.org
> Cc: Long, Qin <qin.long@intel.com>; Ye, Ting <ting.ye@intel.com>
> Subject: [PATCH] CryptoPkg: Fix "responsiblity" typos
> 
> It's "responsibility", not "responsiblity".
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c           | 10 +++++-----
>  CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c       | 10 +++++-----
>  .../BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7VerifyNull.c | 10 +++++-----
>  3 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
> index efa3796..4dd1625 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
> @@ -238,10 +238,10 @@ _Exit:
>    @param[in]  P7Data       Pointer to the PKCS#7 message to verify.
>    @param[in]  P7Length     Length of the PKCS#7 message in bytes.
>    @param[out] CertStack    Pointer to Signer's certificates retrieved from P7Data.
> -                           It's caller's responsiblity to free the buffer.
> +                           It's caller's responsibility to free the buffer.
>    @param[out] StackLength  Length of signer's certificates in bytes.
>    @param[out] TrustedCert  Pointer to a trusted certificate from Signer's certificates.
> -                           It's caller's responsiblity to free the buffer.
> +                           It's caller's responsibility to free the buffer.
>    @param[out] CertLength   Length of the trusted certificate in bytes.
> 
>    @retval  TRUE            The operation is finished successfully.
> @@ -436,10 +436,10 @@ Pkcs7FreeSigners (
>    @param[in]  P7Data            Pointer to the PKCS#7 message.
>    @param[in]  P7Length          Length of the PKCS#7 message in bytes.
>    @param[out] SignerChainCerts  Pointer to the certificates list chained to signer's
> -                                certificate. It's caller's responsiblity to free the buffer.
> +                                certificate. It's caller's responsibility to free the buffer.
>    @param[out] ChainLength       Length of the chained certificates list buffer in bytes.
>    @param[out] UnchainCerts      Pointer to the unchained certificates lists. It's caller's
> -                                responsiblity to free the buffer.
> +                                responsibility to free the buffer.
>    @param[out] UnchainLength     Length of the unchained certificates list buffer in bytes.
> 
>    @retval  TRUE         The operation is finished successfully.
> @@ -905,7 +905,7 @@ _Exit:
>    @param[in]   P7Data       Pointer to the PKCS#7 signed data to process.
>    @param[in]   P7Length     Length of the PKCS#7 signed data in bytes.
>    @param[out]  Content      Pointer to the extracted content from the PKCS#7 signedData.
> -                            It's caller's responsiblity to free the buffer.
> +                            It's caller's responsibility to free the buffer.
>    @param[out]  ContentSize  The size of the extracted content in bytes.
> 
>    @retval     TRUE          The P7Data was correctly formatted for processing.
> diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c
> index 05433ff..d09fd54 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c
> @@ -25,10 +25,10 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>    @param[in]  P7Data       Pointer to the PKCS#7 message to verify.
>    @param[in]  P7Length     Length of the PKCS#7 message in bytes.
>    @param[out] CertStack    Pointer to Signer's certificates retrieved from P7Data.
> -                           It's caller's responsiblity to free the buffer.
> +                           It's caller's responsibility to free the buffer.
>    @param[out] StackLength  Length of signer's certificates in bytes.
>    @param[out] TrustedCert  Pointer to a trusted certificate from Signer's certificates.
> -                           It's caller's responsiblity to free the buffer.
> +                           It's caller's responsibility to free the buffer.
>    @param[out] CertLength   Length of the trusted certificate in bytes.
> 
>    @retval FALSE  This interface is not supported.
> @@ -75,10 +75,10 @@ Pkcs7FreeSigners (
>    @param[in]  P7Data            Pointer to the PKCS#7 message.
>    @param[in]  P7Length          Length of the PKCS#7 message in bytes.
>    @param[out] SignerChainCerts  Pointer to the certificates list chained to signer's
> -                                certificate. It's caller's responsiblity to free the buffer.
> +                                certificate. It's caller's responsibility to free the buffer.
>    @param[out] ChainLength       Length of the chained certificates list buffer in bytes.
>    @param[out] UnchainCerts      Pointer to the unchained certificates lists. It's caller's
> -                                responsiblity to free the buffer.
> +                                responsibility to free the buffer.
>    @param[out] UnchainLength     Length of the unchained certificates list buffer in bytes.
> 
>    @retval  TRUE         The operation is finished successfully.
> @@ -142,7 +142,7 @@ Pkcs7Verify (
>    @param[in]   P7Data       Pointer to the PKCS#7 signed data to process.
>    @param[in]   P7Length     Length of the PKCS#7 signed data in bytes.
>    @param[out]  Content      Pointer to the extracted content from the PKCS#7 signedData.
> -                            It's caller's responsiblity to free the buffer.
> +                            It's caller's responsibility to free the buffer.
>    @param[out]  ContentSize  The size of the extracted content in bytes.
> 
>    @retval     TRUE          The P7Data was correctly formatted for processing.
> diff --git a/CryptoPkg/Library/BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7VerifyNull.c
> b/CryptoPkg/Library/BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7VerifyNull.c
> index 05433ff..d09fd54 100644
> --- a/CryptoPkg/Library/BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7VerifyNull.c
> +++ b/CryptoPkg/Library/BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7VerifyNull.c
> @@ -25,10 +25,10 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>    @param[in]  P7Data       Pointer to the PKCS#7 message to verify.
>    @param[in]  P7Length     Length of the PKCS#7 message in bytes.
>    @param[out] CertStack    Pointer to Signer's certificates retrieved from P7Data.
> -                           It's caller's responsiblity to free the buffer.
> +                           It's caller's responsibility to free the buffer.
>    @param[out] StackLength  Length of signer's certificates in bytes.
>    @param[out] TrustedCert  Pointer to a trusted certificate from Signer's certificates.
> -                           It's caller's responsiblity to free the buffer.
> +                           It's caller's responsibility to free the buffer.
>    @param[out] CertLength   Length of the trusted certificate in bytes.
> 
>    @retval FALSE  This interface is not supported.
> @@ -75,10 +75,10 @@ Pkcs7FreeSigners (
>    @param[in]  P7Data            Pointer to the PKCS#7 message.
>    @param[in]  P7Length          Length of the PKCS#7 message in bytes.
>    @param[out] SignerChainCerts  Pointer to the certificates list chained to signer's
> -                                certificate. It's caller's responsiblity to free the buffer.
> +                                certificate. It's caller's responsibility to free the buffer.
>    @param[out] ChainLength       Length of the chained certificates list buffer in bytes.
>    @param[out] UnchainCerts      Pointer to the unchained certificates lists. It's caller's
> -                                responsiblity to free the buffer.
> +                                responsibility to free the buffer.
>    @param[out] UnchainLength     Length of the unchained certificates list buffer in bytes.
> 
>    @retval  TRUE         The operation is finished successfully.
> @@ -142,7 +142,7 @@ Pkcs7Verify (
>    @param[in]   P7Data       Pointer to the PKCS#7 signed data to process.
>    @param[in]   P7Length     Length of the PKCS#7 signed data in bytes.
>    @param[out]  Content      Pointer to the extracted content from the PKCS#7 signedData.
> -                            It's caller's responsiblity to free the buffer.
> +                            It's caller's responsibility to free the buffer.
>    @param[out]  ContentSize  The size of the extracted content in bytes.
> 
>    @retval     TRUE          The P7Data was correctly formatted for processing.
> --
> 1.8.3.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] CryptoPkg: Fix "responsiblity" typos
  2016-08-07 14:04 ` [PATCH] CryptoPkg: Fix "responsiblity" typos Long, Qin
@ 2016-08-11  7:27   ` Wu, Jiaxin
  0 siblings, 0 replies; 2+ messages in thread
From: Wu, Jiaxin @ 2016-08-11  7:27 UTC (permalink / raw)
  To: Long, Qin, Thomas Huth, edk2-devel@ml01.01.org; +Cc: Ye, Ting

Commit version: 

SHA-1: 210abffdca9015986a78d883647c85706fc39ee3

Reviewed-By: Wu Jiaxin <jiaxin.wu@intel.com>


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Long, Qin
> Sent: Sunday, August 7, 2016 10:04 PM
> To: Thomas Huth <thuth@redhat.com>; edk2-devel@ml01.01.org
> Cc: Ye, Ting <ting.ye@intel.com>
> Subject: Re: [edk2] [PATCH] CryptoPkg: Fix "responsiblity" typos
> 
> Reviewed-by: Qin Long <qin.long@intel.com>
> 
> Best Regards & Thanks,
> LONG, Qin
> 
> > -----Original Message-----
> > From: Thomas Huth [mailto:thuth@redhat.com]
> > Sent: Saturday, August 6, 2016 5:00 AM
> > To: edk2-devel@ml01.01.org
> > Cc: Long, Qin <qin.long@intel.com>; Ye, Ting <ting.ye@intel.com>
> > Subject: [PATCH] CryptoPkg: Fix "responsiblity" typos
> >
> > It's "responsibility", not "responsiblity".
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c           | 10 +++++----
> -
> >  CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c       | 10 +++++-
> ----
> >  .../BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7VerifyNull.c | 10
> > +++++-----
> >  3 files changed, 15 insertions(+), 15 deletions(-)
> >
> > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
> > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
> > index efa3796..4dd1625 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
> > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
> > @@ -238,10 +238,10 @@ _Exit:
> >    @param[in]  P7Data       Pointer to the PKCS#7 message to verify.
> >    @param[in]  P7Length     Length of the PKCS#7 message in bytes.
> >    @param[out] CertStack    Pointer to Signer's certificates retrieved from
> P7Data.
> > -                           It's caller's responsiblity to free the buffer.
> > +                           It's caller's responsibility to free the buffer.
> >    @param[out] StackLength  Length of signer's certificates in bytes.
> >    @param[out] TrustedCert  Pointer to a trusted certificate from Signer's
> certificates.
> > -                           It's caller's responsiblity to free the buffer.
> > +                           It's caller's responsibility to free the buffer.
> >    @param[out] CertLength   Length of the trusted certificate in bytes.
> >
> >    @retval  TRUE            The operation is finished successfully.
> > @@ -436,10 +436,10 @@ Pkcs7FreeSigners (
> >    @param[in]  P7Data            Pointer to the PKCS#7 message.
> >    @param[in]  P7Length          Length of the PKCS#7 message in bytes.
> >    @param[out] SignerChainCerts  Pointer to the certificates list chained to
> signer's
> > -                                certificate. It's caller's responsiblity to free the buffer.
> > +                                certificate. It's caller's responsibility to free the buffer.
> >    @param[out] ChainLength       Length of the chained certificates list buffer
> in bytes.
> >    @param[out] UnchainCerts      Pointer to the unchained certificates lists.
> It's caller's
> > -                                responsiblity to free the buffer.
> > +                                responsibility to free the buffer.
> >    @param[out] UnchainLength     Length of the unchained certificates list
> buffer in bytes.
> >
> >    @retval  TRUE         The operation is finished successfully.
> > @@ -905,7 +905,7 @@ _Exit:
> >    @param[in]   P7Data       Pointer to the PKCS#7 signed data to process.
> >    @param[in]   P7Length     Length of the PKCS#7 signed data in bytes.
> >    @param[out]  Content      Pointer to the extracted content from the
> PKCS#7 signedData.
> > -                            It's caller's responsiblity to free the buffer.
> > +                            It's caller's responsibility to free the buffer.
> >    @param[out]  ContentSize  The size of the extracted content in bytes.
> >
> >    @retval     TRUE          The P7Data was correctly formatted for processing.
> > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c
> > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c
> > index 05433ff..d09fd54 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c
> > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c
> > @@ -25,10 +25,10 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF
> ANY KIND, EITHER EXPRESS OR IMPLIED.
> >    @param[in]  P7Data       Pointer to the PKCS#7 message to verify.
> >    @param[in]  P7Length     Length of the PKCS#7 message in bytes.
> >    @param[out] CertStack    Pointer to Signer's certificates retrieved from
> P7Data.
> > -                           It's caller's responsiblity to free the buffer.
> > +                           It's caller's responsibility to free the buffer.
> >    @param[out] StackLength  Length of signer's certificates in bytes.
> >    @param[out] TrustedCert  Pointer to a trusted certificate from Signer's
> certificates.
> > -                           It's caller's responsiblity to free the buffer.
> > +                           It's caller's responsibility to free the buffer.
> >    @param[out] CertLength   Length of the trusted certificate in bytes.
> >
> >    @retval FALSE  This interface is not supported.
> > @@ -75,10 +75,10 @@ Pkcs7FreeSigners (
> >    @param[in]  P7Data            Pointer to the PKCS#7 message.
> >    @param[in]  P7Length          Length of the PKCS#7 message in bytes.
> >    @param[out] SignerChainCerts  Pointer to the certificates list chained to
> signer's
> > -                                certificate. It's caller's responsiblity to free the buffer.
> > +                                certificate. It's caller's responsibility to free the buffer.
> >    @param[out] ChainLength       Length of the chained certificates list buffer
> in bytes.
> >    @param[out] UnchainCerts      Pointer to the unchained certificates lists.
> It's caller's
> > -                                responsiblity to free the buffer.
> > +                                responsibility to free the buffer.
> >    @param[out] UnchainLength     Length of the unchained certificates list
> buffer in bytes.
> >
> >    @retval  TRUE         The operation is finished successfully.
> > @@ -142,7 +142,7 @@ Pkcs7Verify (
> >    @param[in]   P7Data       Pointer to the PKCS#7 signed data to process.
> >    @param[in]   P7Length     Length of the PKCS#7 signed data in bytes.
> >    @param[out]  Content      Pointer to the extracted content from the
> PKCS#7 signedData.
> > -                            It's caller's responsiblity to free the buffer.
> > +                            It's caller's responsibility to free the buffer.
> >    @param[out]  ContentSize  The size of the extracted content in bytes.
> >
> >    @retval     TRUE          The P7Data was correctly formatted for processing.
> > diff --git
> >
> a/CryptoPkg/Library/BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7Veri
> > fyNull.c
> >
> b/CryptoPkg/Library/BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7Veri
> > fyNull.c
> > index 05433ff..d09fd54 100644
> > ---
> >
> a/CryptoPkg/Library/BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7Veri
> > fyNull.c
> > +++
> b/CryptoPkg/Library/BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7
> > +++ VerifyNull.c
> > @@ -25,10 +25,10 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF
> ANY KIND, EITHER EXPRESS OR IMPLIED.
> >    @param[in]  P7Data       Pointer to the PKCS#7 message to verify.
> >    @param[in]  P7Length     Length of the PKCS#7 message in bytes.
> >    @param[out] CertStack    Pointer to Signer's certificates retrieved from
> P7Data.
> > -                           It's caller's responsiblity to free the buffer.
> > +                           It's caller's responsibility to free the buffer.
> >    @param[out] StackLength  Length of signer's certificates in bytes.
> >    @param[out] TrustedCert  Pointer to a trusted certificate from Signer's
> certificates.
> > -                           It's caller's responsiblity to free the buffer.
> > +                           It's caller's responsibility to free the buffer.
> >    @param[out] CertLength   Length of the trusted certificate in bytes.
> >
> >    @retval FALSE  This interface is not supported.
> > @@ -75,10 +75,10 @@ Pkcs7FreeSigners (
> >    @param[in]  P7Data            Pointer to the PKCS#7 message.
> >    @param[in]  P7Length          Length of the PKCS#7 message in bytes.
> >    @param[out] SignerChainCerts  Pointer to the certificates list chained to
> signer's
> > -                                certificate. It's caller's responsiblity to free the buffer.
> > +                                certificate. It's caller's responsibility to free the buffer.
> >    @param[out] ChainLength       Length of the chained certificates list buffer
> in bytes.
> >    @param[out] UnchainCerts      Pointer to the unchained certificates lists.
> It's caller's
> > -                                responsiblity to free the buffer.
> > +                                responsibility to free the buffer.
> >    @param[out] UnchainLength     Length of the unchained certificates list
> buffer in bytes.
> >
> >    @retval  TRUE         The operation is finished successfully.
> > @@ -142,7 +142,7 @@ Pkcs7Verify (
> >    @param[in]   P7Data       Pointer to the PKCS#7 signed data to process.
> >    @param[in]   P7Length     Length of the PKCS#7 signed data in bytes.
> >    @param[out]  Content      Pointer to the extracted content from the
> PKCS#7 signedData.
> > -                            It's caller's responsiblity to free the buffer.
> > +                            It's caller's responsibility to free the buffer.
> >    @param[out]  ContentSize  The size of the extracted content in bytes.
> >
> >    @retval     TRUE          The P7Data was correctly formatted for processing.
> > --
> > 1.8.3.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-11  7:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1470430825-14473-1-git-send-email-thuth@redhat.com>
2016-08-07 14:04 ` [PATCH] CryptoPkg: Fix "responsiblity" typos Long, Qin
2016-08-11  7:27   ` Wu, Jiaxin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox