public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Long, Qin" <qin.long@intel.com>
To: "Zhang, Chao B" <chao.b.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix GCC build failure
Date: Mon, 10 Oct 2016 08:47:03 +0000	[thread overview]
Message-ID: <BF2CCE9263284D428840004653A28B6E51537870@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1476089091-12112-1-git-send-email-chao.b.zhang@intel.com>

Reviewed-by: Qin Long <qin.long@intel.com>


> -----Original Message-----
> From: Zhang, Chao B
> Sent: Monday, October 10, 2016 4:45 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Gao, Liming; Zhang, Chao B
> Subject: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix GCC build
> failure
> 
> GCC is case sensitive. Also add BaseMemoryLib in INF.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> ---
>  .../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c    |
> 2 +-
>  .../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.inf  |
> 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> index 8fcce74..c03b42b 100644
> ---
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> +++
> b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> @@ -28,7 +28,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY
> KIND, EITHER EXPRESS OR IMPLIED.
>  #include <Protocol/SmmVariable.h>
> 
>  #include <Library/DebugLib.h>
> -#include <Library/BaseMemorylib.h>
> +#include <Library/BaseMemoryLib.h>
>  #include <Library/Tcg2PpVendorLib.h>
>  #include <Library/SmmServicesTableLib.h>
> 
> diff --git
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.inf
> b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.inf
> index a351dcb..5fa84b1 100644
> ---
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.inf
> +++
> b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.inf
> @@ -45,7 +45,8 @@
>    DebugLib
>    Tcg2PpVendorLib
>    SmmServicesTableLib
> -
> +  BaseMemoryLib
> +
>  [Guids]
>    ## SOMETIMES_PRODUCES ## Variable:L"PhysicalPresence"
>    ## SOMETIMES_CONSUMES ## Variable:L"PhysicalPresence"
> --
> 1.9.5.msysgit.1



      parent reply	other threads:[~2016-10-10  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10  8:44 [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix GCC build failure Zhang, Chao B
2016-10-10  8:45 ` Gao, Liming
2016-10-10  8:47 ` Long, Qin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BF2CCE9263284D428840004653A28B6E51537870@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox