public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Long, Qin" <qin.long@intel.com>
To: "Zhang, Chao B" <chao.b.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue
Date: Fri, 21 Oct 2016 06:55:13 +0000	[thread overview]
Message-ID: <BF2CCE9263284D428840004653A28B6E5154D100@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1477027526-13104-1-git-send-email-chao.b.zhang@intel.com>

Reviewed-by: Qin Long <qin.long@intel.com>


> -----Original Message-----
> From: Zhang, Chao B
> Sent: Friday, October 21, 2016 1:25 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan <dandan.bi@intel.com>; Long, Qin <qin.long@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style
> issue
> 
> Fix coding style issue for function descriptor.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> ---
>  SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h                 | 4 ++--
>  .../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c   | 4
> ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> index 696c7e8..910da7a 100644
> --- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> +++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> @@ -125,8 +125,8 @@
> Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
> 
>    Caution: This function may receive untrusted input.
> 
> -  @param[in out]  Pointer to OperationRequest TPM physical presence
> operation request.
> -  @param[in out]  Pointer to RequestParameter TPM physical presence
> operation request parameter.
> +  @param[in, out]  Pointer to OperationRequest TPM physical presence
> operation request.
> +  @param[in, out]  Pointer to RequestParameter TPM physical presence
> operation request parameter.
> 
>    @return Return Code for Submit TPM Operation Request to Pre-OS
> Environment and
>          Submit TPM Operation Request to Pre-OS Environment 2.
> diff --git
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> index c03b42b..039bca1 100644
> ---
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> +++
> b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> @@ -91,8 +91,8 @@
> Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
> 
>    Caution: This function may receive untrusted input.
> 
> -  @param[in out]  Pointer to OperationRequest TPM physical presence
> operation request.
> -  @param[in out]  Pointer to RequestParameter TPM physical presence
> operation request parameter.
> +  @param[in, out]  Pointer to OperationRequest TPM physical presence
> operation request.
> +  @param[in, out]  Pointer to RequestParameter TPM physical presence
> operation request parameter.
> 
>    @return Return Code for Submit TPM Operation Request to Pre-OS
> Environment and
>          Submit TPM Operation Request to Pre-OS Environment 2.
> --
> 1.9.5.msysgit.1



  reply	other threads:[~2016-10-21  6:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  5:25 [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue Zhang, Chao B
2016-10-21  6:55 ` Long, Qin [this message]
2016-10-21  8:15 ` Bi, Dandan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BF2CCE9263284D428840004653A28B6E5154D100@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox