* [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue
@ 2016-10-21 5:25 Zhang, Chao B
2016-10-21 6:55 ` Long, Qin
2016-10-21 8:15 ` Bi, Dandan
0 siblings, 2 replies; 3+ messages in thread
From: Zhang, Chao B @ 2016-10-21 5:25 UTC (permalink / raw)
To: edk2-devel; +Cc: dandan.bi, qin.long, Chao Zhang
Fix coding style issue for function descriptor.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
---
SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 4 ++--
.../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
index 696c7e8..910da7a 100644
--- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
+++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
@@ -125,8 +125,8 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
Caution: This function may receive untrusted input.
- @param[in out] Pointer to OperationRequest TPM physical presence operation request.
- @param[in out] Pointer to RequestParameter TPM physical presence operation request parameter.
+ @param[in, out] Pointer to OperationRequest TPM physical presence operation request.
+ @param[in, out] Pointer to RequestParameter TPM physical presence operation request parameter.
@return Return Code for Submit TPM Operation Request to Pre-OS Environment and
Submit TPM Operation Request to Pre-OS Environment 2.
diff --git a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
index c03b42b..039bca1 100644
--- a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
+++ b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
@@ -91,8 +91,8 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
Caution: This function may receive untrusted input.
- @param[in out] Pointer to OperationRequest TPM physical presence operation request.
- @param[in out] Pointer to RequestParameter TPM physical presence operation request parameter.
+ @param[in, out] Pointer to OperationRequest TPM physical presence operation request.
+ @param[in, out] Pointer to RequestParameter TPM physical presence operation request parameter.
@return Return Code for Submit TPM Operation Request to Pre-OS Environment and
Submit TPM Operation Request to Pre-OS Environment 2.
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue
2016-10-21 5:25 [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue Zhang, Chao B
@ 2016-10-21 6:55 ` Long, Qin
2016-10-21 8:15 ` Bi, Dandan
1 sibling, 0 replies; 3+ messages in thread
From: Long, Qin @ 2016-10-21 6:55 UTC (permalink / raw)
To: Zhang, Chao B, edk2-devel@lists.01.org; +Cc: Bi, Dandan
Reviewed-by: Qin Long <qin.long@intel.com>
> -----Original Message-----
> From: Zhang, Chao B
> Sent: Friday, October 21, 2016 1:25 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan <dandan.bi@intel.com>; Long, Qin <qin.long@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style
> issue
>
> Fix coding style issue for function descriptor.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> ---
> SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 4 ++--
> .../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c | 4
> ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> index 696c7e8..910da7a 100644
> --- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> +++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
> @@ -125,8 +125,8 @@
> Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
>
> Caution: This function may receive untrusted input.
>
> - @param[in out] Pointer to OperationRequest TPM physical presence
> operation request.
> - @param[in out] Pointer to RequestParameter TPM physical presence
> operation request parameter.
> + @param[in, out] Pointer to OperationRequest TPM physical presence
> operation request.
> + @param[in, out] Pointer to RequestParameter TPM physical presence
> operation request parameter.
>
> @return Return Code for Submit TPM Operation Request to Pre-OS
> Environment and
> Submit TPM Operation Request to Pre-OS Environment 2.
> diff --git
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> index c03b42b..039bca1 100644
> ---
> a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> +++
> b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPrese
> nceLib.c
> @@ -91,8 +91,8 @@
> Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
>
> Caution: This function may receive untrusted input.
>
> - @param[in out] Pointer to OperationRequest TPM physical presence
> operation request.
> - @param[in out] Pointer to RequestParameter TPM physical presence
> operation request parameter.
> + @param[in, out] Pointer to OperationRequest TPM physical presence
> operation request.
> + @param[in, out] Pointer to RequestParameter TPM physical presence
> operation request parameter.
>
> @return Return Code for Submit TPM Operation Request to Pre-OS
> Environment and
> Submit TPM Operation Request to Pre-OS Environment 2.
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue
2016-10-21 5:25 [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue Zhang, Chao B
2016-10-21 6:55 ` Long, Qin
@ 2016-10-21 8:15 ` Bi, Dandan
1 sibling, 0 replies; 3+ messages in thread
From: Bi, Dandan @ 2016-10-21 8:15 UTC (permalink / raw)
To: Zhang, Chao B, edk2-devel@lists.01.org; +Cc: Long, Qin
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
-----Original Message-----
From: Zhang, Chao B
Sent: Friday, October 21, 2016 1:25 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Long, Qin <qin.long@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
Subject: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue
Fix coding style issue for function descriptor.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
---
SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 4 ++--
.../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
index 696c7e8..910da7a 100644
--- a/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
+++ b/SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h
@@ -125,8 +125,8 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
Caution: This function may receive untrusted input.
- @param[in out] Pointer to OperationRequest TPM physical presence operation request.
- @param[in out] Pointer to RequestParameter TPM physical presence operation request parameter.
+ @param[in, out] Pointer to OperationRequest TPM physical presence operation request.
+ @param[in, out] Pointer to RequestParameter TPM physical presence operation request parameter.
@return Return Code for Submit TPM Operation Request to Pre-OS Environment and
Submit TPM Operation Request to Pre-OS Environment 2.
diff --git a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
index c03b42b..039bca1 100644
--- a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
+++ b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c
@@ -91,8 +91,8 @@ Tcg2PhysicalPresenceLibReturnOperationResponseToOsFunction (
Caution: This function may receive untrusted input.
- @param[in out] Pointer to OperationRequest TPM physical presence operation request.
- @param[in out] Pointer to RequestParameter TPM physical presence operation request parameter.
+ @param[in, out] Pointer to OperationRequest TPM physical presence operation request.
+ @param[in, out] Pointer to RequestParameter TPM physical presence operation request parameter.
@return Return Code for Submit TPM Operation Request to Pre-OS Environment and
Submit TPM Operation Request to Pre-OS Environment 2.
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-21 8:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-21 5:25 [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue Zhang, Chao B
2016-10-21 6:55 ` Long, Qin
2016-10-21 8:15 ` Bi, Dandan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox