From: "Long, Qin" <qin.long@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2] CryptoPkg/BaseCryptLib: Make comments consistent with the function
Date: Fri, 11 Nov 2016 00:54:53 +0000 [thread overview]
Message-ID: <BF2CCE9263284D428840004653A28B6E51562831@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1478768939-18040-1-git-send-email-dandan.bi@intel.com>
Reviewed-by: Qin Long <qin.long@intel.com>
Best Regards & Thanks,
LONG, Qin
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Thursday, November 10, 2016 5:09 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2] CryptoPkg/BaseCryptLib: Make comments
> consistent with the function
>
> V2: Correct the unaligned parameter name in BaseCryptLib.h.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> CryptoPkg/Include/Library/BaseCryptLib.h | 4 ++--
> CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c | 2 +-
> CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/CryptoPkg/Include/Library/BaseCryptLib.h
> b/CryptoPkg/Include/Library/BaseCryptLib.h
> index 45dac3b..0004493 100644
> --- a/CryptoPkg/Include/Library/BaseCryptLib.h
> +++ b/CryptoPkg/Include/Library/BaseCryptLib.h
> @@ -1114,11 +1114,11 @@ HmacSha1Update (
> If HmacSha1Context is NULL, then return FALSE.
> If HashValue is NULL, then return FALSE.
> If this interface is not supported, then return FALSE.
>
> @param[in, out] HmacSha1Context Pointer to the HMAC-SHA1 context.
> - @param[out] HashValue Pointer to a buffer that receives the HMAC-
> SHA1 digest
> + @param[out] HmacValue Pointer to a buffer that receives the
> HMAC-SHA1 digest
> value (20 bytes).
>
> @retval TRUE HMAC-SHA1 digest computation succeeded.
> @retval FALSE HMAC-SHA1 digest computation failed.
> @retval FALSE This interface is not supported.
> @@ -1232,11 +1232,11 @@ HmacSha256Update (
> If HmacSha256Context is NULL, then return FALSE.
> If HashValue is NULL, then return FALSE.
> If this interface is not supported, then return FALSE.
>
> @param[in, out] HmacSha256Context Pointer to the HMAC-SHA256
> context.
> - @param[out] HashValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> + @param[out] HmacValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> value (32 bytes).
>
> @retval TRUE HMAC-SHA256 digest computation succeeded.
> @retval FALSE HMAC-SHA256 digest computation failed.
> @retval FALSE This interface is not supported.
> diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> index 5d349dc..e17ef29 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> @@ -162,11 +162,11 @@ HmacSha256Update (
>
> If HmacSha256Context is NULL, then return FALSE.
> If HashValue is NULL, then return FALSE.
>
> @param[in, out] HmacSha256Context Pointer to the HMAC-SHA256
> context.
> - @param[out] HashValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> + @param[out] HmacValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> value (32 bytes).
>
> @retval TRUE HMAC-SHA256 digest computation succeeded.
> @retval FALSE HMAC-SHA256 digest computation failed.
>
> diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> index 48704e1..35abdda 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> @@ -107,11 +107,11 @@ HmacSha256Update (
> Completes computation of the HMAC-SHA256 digest value.
>
> Return FALSE to indicate this interface is not supported.
>
> @param[in, out] HmacSha256Context Pointer to the HMAC-SHA256
> context.
> - @param[out] HashValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> + @param[out] HmacValue Pointer to a buffer that receives the
> HMAC-SHA256 digest
> value (32 bytes).
>
> @retval FALSE This interface is not supported.
>
> **/
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-11-11 0:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 9:08 [PATCH v2] CryptoPkg/BaseCryptLib: Make comments consistent with the function Dandan Bi
2016-11-11 0:54 ` Long, Qin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF2CCE9263284D428840004653A28B6E51562831@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox