From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 24DEA81E12 for ; Thu, 10 Nov 2016 16:54:55 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 10 Nov 2016 16:54:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,620,1473145200"; d="scan'208";a="29994410" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 10 Nov 2016 16:54:58 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 10 Nov 2016 16:54:58 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 10 Nov 2016 16:54:57 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.96]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Fri, 11 Nov 2016 08:54:54 +0800 From: "Long, Qin" To: "Bi, Dandan" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v2] CryptoPkg/BaseCryptLib: Make comments consistent with the function Thread-Index: AQHSOzIgIUPnP+Tm3EC5ylUJBiaTm6DS9fCQ Date: Fri, 11 Nov 2016 00:54:53 +0000 Message-ID: References: <1478768939-18040-1-git-send-email-dandan.bi@intel.com> In-Reply-To: <1478768939-18040-1-git-send-email-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] CryptoPkg/BaseCryptLib: Make comments consistent with the function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 00:54:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Dandan Bi > Sent: Thursday, November 10, 2016 5:09 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2] CryptoPkg/BaseCryptLib: Make comments > consistent with the function >=20 > V2: Correct the unaligned parameter name in BaseCryptLib.h. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > CryptoPkg/Include/Library/BaseCryptLib.h | 4 ++-- > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c | 2 +- > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/CryptoPkg/Include/Library/BaseCryptLib.h > b/CryptoPkg/Include/Library/BaseCryptLib.h > index 45dac3b..0004493 100644 > --- a/CryptoPkg/Include/Library/BaseCryptLib.h > +++ b/CryptoPkg/Include/Library/BaseCryptLib.h > @@ -1114,11 +1114,11 @@ HmacSha1Update ( > If HmacSha1Context is NULL, then return FALSE. > If HashValue is NULL, then return FALSE. > If this interface is not supported, then return FALSE. >=20 > @param[in, out] HmacSha1Context Pointer to the HMAC-SHA1 context. > - @param[out] HashValue Pointer to a buffer that receives th= e HMAC- > SHA1 digest > + @param[out] HmacValue Pointer to a buffer that receives th= e > HMAC-SHA1 digest > value (20 bytes). >=20 > @retval TRUE HMAC-SHA1 digest computation succeeded. > @retval FALSE HMAC-SHA1 digest computation failed. > @retval FALSE This interface is not supported. > @@ -1232,11 +1232,11 @@ HmacSha256Update ( > If HmacSha256Context is NULL, then return FALSE. > If HashValue is NULL, then return FALSE. > If this interface is not supported, then return FALSE. >=20 > @param[in, out] HmacSha256Context Pointer to the HMAC-SHA256 > context. > - @param[out] HashValue Pointer to a buffer that receives = the > HMAC-SHA256 digest > + @param[out] HmacValue Pointer to a buffer that receives = the > HMAC-SHA256 digest > value (32 bytes). >=20 > @retval TRUE HMAC-SHA256 digest computation succeeded. > @retval FALSE HMAC-SHA256 digest computation failed. > @retval FALSE This interface is not supported. > diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c > b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c > index 5d349dc..e17ef29 100644 > --- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c > +++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c > @@ -162,11 +162,11 @@ HmacSha256Update ( >=20 > If HmacSha256Context is NULL, then return FALSE. > If HashValue is NULL, then return FALSE. >=20 > @param[in, out] HmacSha256Context Pointer to the HMAC-SHA256 > context. > - @param[out] HashValue Pointer to a buffer that receives = the > HMAC-SHA256 digest > + @param[out] HmacValue Pointer to a buffer that receives = the > HMAC-SHA256 digest > value (32 bytes). >=20 > @retval TRUE HMAC-SHA256 digest computation succeeded. > @retval FALSE HMAC-SHA256 digest computation failed. >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c > b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c > index 48704e1..35abdda 100644 > --- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c > +++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c > @@ -107,11 +107,11 @@ HmacSha256Update ( > Completes computation of the HMAC-SHA256 digest value. >=20 > Return FALSE to indicate this interface is not supported. >=20 > @param[in, out] HmacSha256Context Pointer to the HMAC-SHA256 > context. > - @param[out] HashValue Pointer to a buffer that receives = the > HMAC-SHA256 digest > + @param[out] HmacValue Pointer to a buffer that receives = the > HMAC-SHA256 digest > value (32 bytes). >=20 > @retval FALSE This interface is not supported. >=20 > **/ > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel