Re: [PATCH 1/2] SecurityPkg/FmpAuthLib: Add PublicKeyDataLength check

["Long, Qin" <qin.long@intel.com>]

Reviewed-by: Qin Long <qin.long@intel.com>


> -----Original Message-----
> From: Yao, Jiewen
> Sent: Thursday, December 22, 2016 1:00 PM
> To: edk2-devel@lists.01.org
> Cc: Zhang, Chao B; Long, Qin
> Subject: [PATCH 1/2] SecurityPkg/FmpAuthLib: Add PublicKeyDataLength
> check
> 
> Add PublicKeyDataLength check to be multiple SHA256_DIGEST_SIZE to avoid
> caller make mistake, or platform mis-configuration.
> 
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Qin Long <qin.long@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
> 
> SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio
> nLibRsa2048Sha256.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git
> a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticat
> ionLibRsa2048Sha256.c
> b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticat
> ionLibRsa2048Sha256.c
> index d113d58..4b2556c 100644
> ---
> a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticat
> ionLibRsa2048Sha256.c
> +++
> b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthentic
> +++ ationLibRsa2048Sha256.c
> @@ -306,6 +306,11 @@ AuthenticateFmpImage (
>      return RETURN_UNSUPPORTED;
>    }
> 
> +  if ((PublicKeyDataLength % SHA256_DIGEST_SIZE) != 0) {
> +    DEBUG ((DEBUG_ERROR, "PublicKeyDataLength is not multiple SHA256
> size\n"));
> +    return RETURN_UNSUPPORTED;
> +  }
> +
>    if (ImageSize < sizeof(EFI_FIRMWARE_IMAGE_AUTHENTICATION)) {
>      DEBUG((DEBUG_ERROR, "AuthenticateFmpImage - ImageSize too
> small\n"));
>      return RETURN_INVALID_PARAMETER;
> --
> 2.7.4.windows.1