public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Long, Qin" <qin.long@intel.com>
To: "Zhang, Chao B" <chao.b.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH 2/2] MdePkg: UefiTcgPlatform.h: Add TCG_PCR_EVENT2_HDR definition
Date: Sat, 4 Feb 2017 08:49:34 +0000	[thread overview]
Message-ID: <BF2CCE9263284D428840004653A28B6E53F5C8B8@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170204013304.16360-2-chao.b.zhang@intel.com>

Hi, Chao,

Please use "Digests", instead of "Digest" in TCG_PCR_EVENT2 definition for spec alignment.
Other looks good to me.

Reviewed-by: Long Qin <qin.long@intel.com>


Best Regards & Thanks,
LONG, Qin

> -----Original Message-----
> From: Zhang, Chao B
> Sent: Saturday, February 04, 2017 9:33 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Yao, Jiewen; Zhang, Chao B
> Subject: [PATCH 2/2] MdePkg: UefiTcgPlatform.h: Add
> TCG_PCR_EVENT2_HDR definition
> 
> Add TCG_PCR_EVENT2_HDR definition.
> 
> Cc: Long Qin <qin.long@intel.com>
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/UefiTcgPlatform.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> index 8a3e170..cd1dea8 100644
> --- a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> +++ b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> @@ -206,6 +206,16 @@ typedef struct tdTCG_PCR_EVENT2 {  }
> TCG_PCR_EVENT2;
> 
>  //
> +// TCG PCR Event2 Header
> +//
> +typedef struct tdTCG_PCR_EVENT2_HDR{
> +  TCG_PCRINDEX        PCRIndex;
> +  TCG_EVENTTYPE       EventType;
> +  TPML_DIGEST_VALUES  Digest;
> +  UINT32              EventSize;
> +} TCG_PCR_EVENT2_HDR;
> +
> +//
>  // Log Header Entry Data
>  //
>  typedef struct {
> --
> 1.9.5.msysgit.1



  reply	other threads:[~2017-02-04  8:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-04  1:33 [PATCH 1/2] SecurityPkg: Tcg2Dxe: Log EV_NO_ACTION event in TCG_PCR_EVENT2 format Zhang, Chao B
2017-02-04  1:33 ` [PATCH 2/2] MdePkg: UefiTcgPlatform.h: Add TCG_PCR_EVENT2_HDR definition Zhang, Chao B
2017-02-04  8:49   ` Long, Qin [this message]
2017-02-04  8:53 ` [PATCH 1/2] SecurityPkg: Tcg2Dxe: Log EV_NO_ACTION event in TCG_PCR_EVENT2 format Long, Qin
2017-02-06  0:57   ` Zhang, Chao B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BF2CCE9263284D428840004653A28B6E53F5C8B8@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox