Re: [PATCH 2/2] MdePkg: UefiTcgPlatform.h: Add TCG_PCR_EVENT2_HDR definition

["Long, Qin" <qin.long@intel.com>]

Hi, Chao,

Please use "Digests", instead of "Digest" in TCG_PCR_EVENT2 definition for spec alignment.
Other looks good to me.

Reviewed-by: Long Qin <qin.long@intel.com>


Best Regards & Thanks,
LONG, Qin

> -----Original Message-----
> From: Zhang, Chao B
> Sent: Saturday, February 04, 2017 9:33 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin; Yao, Jiewen; Zhang, Chao B
> Subject: [PATCH 2/2] MdePkg: UefiTcgPlatform.h: Add
> TCG_PCR_EVENT2_HDR definition
> 
> Add TCG_PCR_EVENT2_HDR definition.
> 
> Cc: Long Qin <qin.long@intel.com>
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/UefiTcgPlatform.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> index 8a3e170..cd1dea8 100644
> --- a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> +++ b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> @@ -206,6 +206,16 @@ typedef struct tdTCG_PCR_EVENT2 {  }
> TCG_PCR_EVENT2;
> 
>  //
> +// TCG PCR Event2 Header
> +//
> +typedef struct tdTCG_PCR_EVENT2_HDR{
> +  TCG_PCRINDEX        PCRIndex;
> +  TCG_EVENTTYPE       EventType;
> +  TPML_DIGEST_VALUES  Digest;
> +  UINT32              EventSize;
> +} TCG_PCR_EVENT2_HDR;
> +
> +//
>  // Log Header Entry Data
>  //
>  typedef struct {
> --
> 1.9.5.msysgit.1