Re: [PATCH V2 2/6] SecurityPkg/dec: Add PcdPasswordCleared.

["Long, Qin" <qin.long@intel.com>]

Reviewed-by: Qin Long <qin.long@intel.com>

Please correct one typo: accroding --> according in the comment. 


Best Regards & Thanks,
LONG, Qin

> -----Original Message-----
> From: Yao, Jiewen
> Sent: Tuesday, February 7, 2017 12:24 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin <qin.long@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>
> Subject: [PATCH V2 2/6] SecurityPkg/dec: Add PcdPasswordCleared.
> 
> This PCD is to indicate if the password is cleared.
> 
> Cc: Qin Long <qin.long@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
>  SecurityPkg/SecurityPkg.dec |  6 ++++++  SecurityPkg/SecurityPkg.uni | 10
> ++++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec index
> b556fb6..da2f84f 100644
> --- a/SecurityPkg/SecurityPkg.dec
> +++ b/SecurityPkg/SecurityPkg.dec
> @@ -446,6 +446,12 @@
>    # @Prompt Initial setting of TCG2 Persistent Firmware Management Flags
> 
> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UI
> NT32|0x0001001B
> 
> +  ## Indicate whether the password is cleared.
> +  # When it is configured to Dynamic or DynamicEx, it can be set
> + through detection using  # a platform-specific method (e.g. Board
> + Jumper set) in a actual platform in early boot phase.<BR><BR>  #
> + @Prompt The passowrd clear status
> +
> gEfiSecurityPkgTokenSpaceGuid.PcdPasswordCleared|FALSE|BOOLEAN|0x0
> 0010
> + 01C
> +
>  [PcdsDynamic, PcdsDynamicEx]
> 
>    ## This PCD indicates Hash mask for TPM 2.0.<BR><BR> diff --git
> a/SecurityPkg/SecurityPkg.uni b/SecurityPkg/SecurityPkg.uni index
> 17d36c0..ffc097e 100644
> --- a/SecurityPkg/SecurityPkg.uni
> +++ b/SecurityPkg/SecurityPkg.uni
> @@ -219,6 +219,16 @@
>  "When it is configured to Dynamic or DynamicEx, it can be set through
> detection using "
>  "a platform-specific method (e.g. Button pressed) in a actual platform in
> early boot phase.<BR><BR>"
> 
> +#string
> STR_gEfiSecurityPkgTokenSpaceGuid_PcdPasswordCleared_PROMPT
> +#language en-US
> +"The passowrd clear status"
> +
> +#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdPasswordCleared_HELP
> +#language en-US
> +"Indicate whether the password is cleared. "
> +"When it is configured to Dynamic or DynamicEx, it can be set through
> detection using "
> +"a platform-specific method (e.g. Board Jumper set) in a actual platform in
> early boot phase.<BR><BR>"
> +
>  #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdPkcs7CertBuffer_PROMPT
> #language en-US "One PKCS7 cert used to verify Recovery and Capsule
> Update images"
> 
>  #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdPkcs7CertBuffer_HELP
> #language en-US "Provides one PKCS7 cert used to verify Recovery and
> Capsule Update images\n"
> --
> 2.7.4.windows.1