public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Long, Qin" <qin.long@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [PATCH V2 2/6] SecurityPkg/dec: Add PcdPasswordCleared.
Date: Thu, 9 Feb 2017 00:41:17 +0000	[thread overview]
Message-ID: <BF2CCE9263284D428840004653A28B6E53F5E6F3@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1486455866-7896-3-git-send-email-jiewen.yao@intel.com>

Reviewed-by: Qin Long <qin.long@intel.com>

Please correct one typo: accroding --> according in the comment. 


Best Regards & Thanks,
LONG, Qin

> -----Original Message-----
> From: Yao, Jiewen
> Sent: Tuesday, February 7, 2017 12:24 AM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin <qin.long@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>
> Subject: [PATCH V2 2/6] SecurityPkg/dec: Add PcdPasswordCleared.
> 
> This PCD is to indicate if the password is cleared.
> 
> Cc: Qin Long <qin.long@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
>  SecurityPkg/SecurityPkg.dec |  6 ++++++  SecurityPkg/SecurityPkg.uni | 10
> ++++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec index
> b556fb6..da2f84f 100644
> --- a/SecurityPkg/SecurityPkg.dec
> +++ b/SecurityPkg/SecurityPkg.dec
> @@ -446,6 +446,12 @@
>    # @Prompt Initial setting of TCG2 Persistent Firmware Management Flags
> 
> gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags|0x300E2|UI
> NT32|0x0001001B
> 
> +  ## Indicate whether the password is cleared.
> +  # When it is configured to Dynamic or DynamicEx, it can be set
> + through detection using  # a platform-specific method (e.g. Board
> + Jumper set) in a actual platform in early boot phase.<BR><BR>  #
> + @Prompt The passowrd clear status
> +
> gEfiSecurityPkgTokenSpaceGuid.PcdPasswordCleared|FALSE|BOOLEAN|0x0
> 0010
> + 01C
> +
>  [PcdsDynamic, PcdsDynamicEx]
> 
>    ## This PCD indicates Hash mask for TPM 2.0.<BR><BR> diff --git
> a/SecurityPkg/SecurityPkg.uni b/SecurityPkg/SecurityPkg.uni index
> 17d36c0..ffc097e 100644
> --- a/SecurityPkg/SecurityPkg.uni
> +++ b/SecurityPkg/SecurityPkg.uni
> @@ -219,6 +219,16 @@
>  "When it is configured to Dynamic or DynamicEx, it can be set through
> detection using "
>  "a platform-specific method (e.g. Button pressed) in a actual platform in
> early boot phase.<BR><BR>"
> 
> +#string
> STR_gEfiSecurityPkgTokenSpaceGuid_PcdPasswordCleared_PROMPT
> +#language en-US
> +"The passowrd clear status"
> +
> +#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdPasswordCleared_HELP
> +#language en-US
> +"Indicate whether the password is cleared. "
> +"When it is configured to Dynamic or DynamicEx, it can be set through
> detection using "
> +"a platform-specific method (e.g. Board Jumper set) in a actual platform in
> early boot phase.<BR><BR>"
> +
>  #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdPkcs7CertBuffer_PROMPT
> #language en-US "One PKCS7 cert used to verify Recovery and Capsule
> Update images"
> 
>  #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdPkcs7CertBuffer_HELP
> #language en-US "Provides one PKCS7 cert used to verify Recovery and
> Capsule Update images\n"
> --
> 2.7.4.windows.1



  reply	other threads:[~2017-02-09  0:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07  8:24 [PATCH V2 0/6] Add password support Jiewen Yao
2017-02-07  8:24 ` [PATCH V2 1/6] CryptoPkg:SmmCryptLib: Add real Pkcs5Pbkdf2.c Jiewen Yao
2017-02-09  0:37   ` Long, Qin
2017-02-07  8:24 ` [PATCH V2 2/6] SecurityPkg/dec: Add PcdPasswordCleared Jiewen Yao
2017-02-09  0:41   ` Long, Qin [this message]
2017-02-09  6:04     ` Yao, Jiewen
2017-02-07  8:24 ` [PATCH V2 3/6] SecurityPkg/include: Add PlatformPasswordLib lib class Jiewen Yao
2017-02-09  0:39   ` Long, Qin
2017-02-09  6:04     ` Yao, Jiewen
2017-02-07  8:24 ` [PATCH V2 4/6] SecurityPkg/PlatformPasswordLibNull: Add PlatformPasswordLib instance Jiewen Yao
2017-02-09  0:42   ` Long, Qin
2017-02-07  8:24 ` [PATCH V2 5/6] SecurityPkg/Password: Add Password based UserAuthentication modules Jiewen Yao
2017-02-09  0:49   ` Long, Qin
2017-02-09  1:03     ` Yao, Jiewen
2017-02-09  1:29       ` Long, Qin
2017-02-07  8:24 ` [PATCH V2 6/6] SecurityPkg/dsc: add Password authentication module Jiewen Yao
2017-02-09  0:49   ` Long, Qin
2017-02-09  1:05 ` [PATCH V2 0/6] Add password support Zhang, Chao B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BF2CCE9263284D428840004653A28B6E53F5E6F3@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox