From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BA6EB8042A for ; Wed, 22 Mar 2017 19:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490235391; x=1521771391; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZBKn5CufuIEHJmHPIvdzGF01Idq+XK2PqSf1C/gmPgE=; b=sA0OzzxxqLjOf3WIEfzG/haIHsX+PvOXgpu2kxomCuR5SLFXIBXQd38A fwMqJc93r0+6wSGuDhE8DR+5hLECoA==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2017 19:16:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,207,1486454400"; d="scan'208";a="947257528" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 22 Mar 2017 19:16:30 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 19:16:30 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 19:16:30 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by shsmsx102.ccr.corp.intel.com ([169.254.2.88]) with mapi id 14.03.0248.002; Thu, 23 Mar 2017 10:16:26 +0800 From: "Long, Qin" To: Gary Lin CC: "edk2-devel@lists.01.org" , "ard.biesheuvel@linaro.org" , "Ye, Ting" , David Woodhouse , "ronald.cron@arm.com" , "Wu, Jiaxin" , "lersek@redhat.com" Thread-Topic: [edk2] [PATCH v1 3/9] CryptoPkg: Fix handling of &strcmp function pointers Thread-Index: AQHSolvd5pv7Qd32BkeU2M+ahPY9fKGgHm0AgAGR2+A= Date: Thu, 23 Mar 2017 02:16:25 +0000 Message-ID: References: <20170321155612.1192-1-qin.long@intel.com> <20170321155612.1192-4-qin.long@intel.com> <20170322101110.d7lpswvlhdpeaetd@GaryWorkstation> In-Reply-To: <20170322101110.d7lpswvlhdpeaetd@GaryWorkstation> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 3/9] CryptoPkg: Fix handling of &strcmp function pointers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 02:16:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 R2FyeSwgSSBtaXNzZWQgeW91ciBjb21tZW50Lg0KWWVzLCBJIGRpZG4ndCBub3RpY2UgdGhpcyBm aXggd2FzIGFscmVhZHkgbWVyZ2VkLiANClNpbmNlIDEuMS4weHggYWxyZWFkeSBtZXJnZSB0aGlz IE9QRU5TU0xfU1lTX1VFRkkgaGFuZGxpbmcgLCBJIHRoaW5rIHdlIGNhbiBzaW1wbGlmeSBvdXIg c2lkZSB3aXRoIGRpcmVjdCBBc2NpaVN0ckNtcCBtYXBwaW5nIGluIENSVCB3cmFwcGVyLiANCg0K VGhhbmsgeW91IHNvIG11Y2ggZm9yIGNhdGNoaW5nIHRoaXMgb25lLg0KDQoNCkJlc3QgUmVnYXJk cyAmIFRoYW5rcywNCkxPTkcsIFFpbg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ IEZyb206IEdhcnkgTGluIFttYWlsdG86Z2xpbkBzdXNlLmNvbV0NCj4gU2VudDogV2VkbmVzZGF5 LCBNYXJjaCAyMiwgMjAxNyA2OjExIFBNDQo+IFRvOiBMb25nLCBRaW4gPHFpbi5sb25nQGludGVs LmNvbT4NCj4gQ2M6IGVkazItZGV2ZWxAbGlzdHMuMDEub3JnOyBhcmQuYmllc2hldXZlbEBsaW5h cm8ub3JnOyBZZSwgVGluZw0KPiA8dGluZy55ZUBpbnRlbC5jb20+OyBEYXZpZCBXb29kaG91c2Ug PGR3bXcyQGluZnJhZGVhZC5vcmc+Ow0KPiByb25hbGQuY3JvbkBhcm0uY29tOyBXdSwgSmlheGlu IDxqaWF4aW4ud3VAaW50ZWwuY29tPjsNCj4gbGVyc2VrQHJlZGhhdC5jb20NCj4gU3ViamVjdDog UmU6IFtlZGsyXSBbUEFUQ0ggdjEgMy85XSBDcnlwdG9Qa2c6IEZpeCBoYW5kbGluZyBvZiAmc3Ry Y21wDQo+IGZ1bmN0aW9uIHBvaW50ZXJzDQo+IA0KPiBPbiBUdWUsIE1hciAyMSwgMjAxNyBhdCAx MTo1NjowNlBNICswODAwLCBRaW4gTG9uZyB3cm90ZToNCj4gPiBJbiBhIGNvdXBsZSBvZiBwbGFj ZXMsIE9wZW5TU0wgY29kZSB1c2VzIHRoZSBhZGRyZXNzIG9mIHRoZSBzdHJjbXAoKQ0KPiA+IGZ1 bmN0aW9uLCBhbmQgYXNzaWducyBpdCB0byBhbm90aGVyIGNvbXBhcmF0b3IgZnVuY3Rpb24gcG9p bnRlci4NCj4gPg0KPiA+IFVuZm9ydHVuYXRlbHksIHRoaXMgZmFsbHMgZm91bCBvZiB0aGUgaW5j b25zaXN0ZW50IGZ1bmN0aW9uIEFCSSB0aGF0DQo+ID4gd2UgdXNlIGluIEVES0lJLiBXZSAnI2Rl ZmluZSBzdHJjbXAgQXNjaWlTdHJDbXAnIGJ1dCBBc2NpaVN0ckNtcCBpcyBhbg0KPiA+IEVGSUFQ SSBmdW5jdGlvbiB3aXRoIHRoZSBNaWNyb3NvZnQgQUJJLiBBbmQgd2UncmUgYXNzaWduaW5nIGl0 cw0KPiA+IGFkZHJlc3MgdG8gYSBub24tRUZJQVBJIGZ1bmN0aW9uLCB3aGljaCBtYXkgd2VsbCBo YXZlIGEgZGlmZmVyZW50IEFCSS4NCj4gPg0KPiA+IFRoZSBjb21waWxlciAqc2hvdWxkKiBoYXZl IGNvbXBsYWluZWQgYWJvdXQgdGhpcyBlcnJvciwgdGh1czoNCj4gPg0KPiA+IOKApi9jcnlwdG8v b2JqZWN0cy9vX25hbWVzLmM6IEluIGZ1bmN0aW9uIOKAmE9CSl9OQU1FX25ld19pbmRleOKAmToN Cj4gPiDigKYvY3J5cHRvL29iamVjdHMvb19uYW1lcy5jOjk0OjMwOiBlcnJvcjogYXNzaWdubWVu dCBmcm9tIGluY29tcGF0aWJsZQ0KPiA+IHBvaW50ZXIgdHlwZSBbLVdlcnJvcj1pbmNvbXBhdGli bGUtcG9pbnRlci10eXBlc10NCj4gPiAgICAgICAgICBuYW1lX2Z1bmNzLT5jbXBfZnVuYyA9IE9Q RU5TU0xfc3RyY21wOw0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF4NCj4gPiBU aGVyZSdzIGFub3RoZXIgb25lIGluIGNyeXB0by9saGFzaC9saGFzaC5jOjpsaF9uZXcoKSB3aGlj aCBoYXMgYW4NCj4gPiBleHBsaWNpdCBjYXN0IHNvIGV2ZW4gd2l0aCBjb21waWxlciB3YXJuaW5n cyB3ZSB3b3VsZG4ndCBoYXZlIHNlZW4gaXQuDQo+ID4NCj4gPiBGaXggdGhpcyBieSBwcm92aWRp bmcgYW4gYWN0dWFsIHN0cmNtcCgpIGZ1bmN0aW9uIGluIHRoZSBkZWZhdWx0IEFCSS4NCj4gPiBX ZSBhbHJlYWR5ICpoYWQqIGEgcHJvdG90eXBlIGZvciBpdCBpbiBPcGVuU3NsU3VwcG9ydC5oLCB3 aGljaCB3YXMNCj4gPiB0aGVuIHN1cGVyc2VkZWQgYnkgdGhlICNkZWZpbmUgc3RyY21wIEFzY2lp U3RyQ21wLg0KPiA+DQo+ID4gTm93LCBPcGVuU1NMIGNvZGUgKmNhbiogdXNlICZzdHJjbXAgd2l0 aG91dCBwcm9ibGVtcy4NCj4gDQo+IFdpdGggdGhpcyBwYXRjaCwgd2UgcHJvYmFibHkgY2FuIHJl bW92ZSAiZGVmaW5lZChPUEVOU1NMX1NZU19VRUZJKSINCj4gZnJvbQ0KPiBodHRwczovL2dpdGh1 Yi5jb20vb3BlbnNzbC9vcGVuc3NsL2Jsb2IvbWFzdGVyL2NyeXB0by9vYmplY3RzL29fbmFtZXMu DQo+IGMjTDMyDQo+IA0KPiBHYXJ5IExpbg0KPiA+DQo+ID4gQ2M6IFRpbmcgWWUgPHRpbmcueWVA aW50ZWwuY29tPg0KPiA+IENjOiBMYXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPg0KPiA+ IENjOiBBcmQgQmllc2hldXZlbCA8YXJkLmJpZXNoZXV2ZWxAbGluYXJvLm9yZz4NCj4gPiBDYzog R2FyeSBMaW4gPGdsaW5Ac3VzZS5jb20+DQo+ID4gQ2M6IFJvbmFsZCBDcm9uIDxyb25hbGQuY3Jv bkBhcm0uY29tPg0KPiA+IENvbnRyaWJ1dGVkLXVuZGVyOiBUaWFub0NvcmUgQ29udHJpYnV0aW9u IEFncmVlbWVudCAxLjANCj4gPiBTaWduZWQtb2ZmLWJ5OiBEYXZpZCBXb29kaG91c2UgPGR3bXcy QGluZnJhZGVhZC5vcmc+DQo+ID4gU2lnbmVkLW9mZi1ieTogUWluIExvbmcgPHFpbi5sb25nQGlu dGVsLmNvbT4NCj4gPiAtLS0NCj4gPiAgQ3J5cHRvUGtnL0luY2x1ZGUvT3BlblNzbFN1cHBvcnQu aCAgICAgICAgICAgICAgICB8IDMgKy0tDQo+ID4gIENyeXB0b1BrZy9MaWJyYXJ5L0ludHJpbnNp Y0xpYi9NZW1vcnlJbnRyaW5zaWNzLmMgfCA4ICsrKysrKystDQo+ID4gIDIgZmlsZXMgY2hhbmdl ZCwgOCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBh L0NyeXB0b1BrZy9JbmNsdWRlL09wZW5Tc2xTdXBwb3J0LmgNCj4gPiBiL0NyeXB0b1BrZy9JbmNs dWRlL09wZW5Tc2xTdXBwb3J0LmgNCj4gPiBpbmRleCA5MTU2N2M3OGY4Li5jM2M1YjVkY2Q3IDEw MDY0NA0KPiA+IC0tLSBhL0NyeXB0b1BrZy9JbmNsdWRlL09wZW5Tc2xTdXBwb3J0LmgNCj4gPiAr KysgYi9DcnlwdG9Qa2cvSW5jbHVkZS9PcGVuU3NsU3VwcG9ydC5oDQo+ID4gQEAgLTEsNyArMSw3 IEBADQo+ID4gIC8qKiBAZmlsZQ0KPiA+ICAgIFJvb3QgaW5jbHVkZSBmaWxlIHRvIHN1cHBvcnQg YnVpbGRpbmcgT3BlblNTTCBDcnlwdG8gTGlicmFyeS4NCj4gPg0KPiA+IC1Db3B5cmlnaHQgKGMp IDIwMTAgLSAyMDE2LCBJbnRlbCBDb3Jwb3JhdGlvbi4gQWxsIHJpZ2h0cw0KPiA+IHJlc2VydmVk LjxCUj4NCj4gPiArQ29weXJpZ2h0IChjKSAyMDEwIC0gMjAxNywgSW50ZWwgQ29ycG9yYXRpb24u IEFsbCByaWdodHMNCj4gPiArcmVzZXJ2ZWQuPEJSPg0KPiA+ICBUaGlzIHByb2dyYW0gYW5kIHRo ZSBhY2NvbXBhbnlpbmcgbWF0ZXJpYWxzICBhcmUgbGljZW5zZWQgYW5kIG1hZGUNCj4gPiBhdmFp bGFibGUgdW5kZXIgdGhlIHRlcm1zIGFuZCBjb25kaXRpb25zIG9mIHRoZSBCU0QgTGljZW5zZSAg d2hpY2gNCj4gPiBhY2NvbXBhbmllcyB0aGlzIGRpc3RyaWJ1dGlvbi4gIFRoZSBmdWxsIHRleHQg b2YgdGhlIGxpY2Vuc2UgbWF5IGJlDQo+ID4gZm91bmQgYXQgQEAgLTI3NSw3ICsyNzUsNiBAQCBl eHRlcm4gRklMRSAgKnN0ZG91dDsNCj4gPiAgI2RlZmluZSBtZW1jaHIoYnVmLGNoLGNvdW50KQ0K PiBTY2FuTWVtOChidWYsKFVJTlROKShjb3VudCksKFVJTlQ4KWNoKQ0KPiA+ICAjZGVmaW5lIG1l bWNtcChidWYxLGJ1ZjIsY291bnQpDQo+IChpbnQpKENvbXBhcmVNZW0oYnVmMSxidWYyLChVSU5U TikoY291bnQpKSkNCj4gPiAgI2RlZmluZSBtZW1tb3ZlKGRlc3Qsc291cmNlLGNvdW50KQ0KPiBD b3B5TWVtKGRlc3Qsc291cmNlLChVSU5UTikoY291bnQpKQ0KPiA+IC0jZGVmaW5lIHN0cmNtcCAg ICAgICAgICAgICAgICAgICAgICAgICAgICBBc2NpaVN0ckNtcA0KPiA+ICAjZGVmaW5lIHN0cm5j bXAoc3RyaW5nMSxzdHJpbmcyLGNvdW50KQ0KPiAoaW50KShBc2NpaVN0cm5DbXAoc3RyaW5nMSxz dHJpbmcyLChVSU5UTikoY291bnQpKSkNCj4gPiAgI2RlZmluZSBzdHJjcHkoc3RyRGVzdCxzdHJT b3VyY2UpDQo+IEFzY2lpU3RyQ3B5UyhzdHJEZXN0LE1BWF9TVFJJTkdfU0laRSxzdHJTb3VyY2Up DQo+ID4gICNkZWZpbmUgc3RybmNweShzdHJEZXN0LHN0clNvdXJjZSxjb3VudCkNCj4gPiBBc2Np aVN0cm5DcHlTKHN0ckRlc3QsTUFYX1NUUklOR19TSVpFLHN0clNvdXJjZSwoVUlOVE4pY291bnQp DQo+ID4gZGlmZiAtLWdpdCBhL0NyeXB0b1BrZy9MaWJyYXJ5L0ludHJpbnNpY0xpYi9NZW1vcnlJ bnRyaW5zaWNzLmMNCj4gPiBiL0NyeXB0b1BrZy9MaWJyYXJ5L0ludHJpbnNpY0xpYi9NZW1vcnlJ bnRyaW5zaWNzLmMNCj4gPiBpbmRleCA5ZDY4NjdlYmNlLi5lOGE3NmQwN2ZmIDEwMDY0NA0KPiA+ IC0tLSBhL0NyeXB0b1BrZy9MaWJyYXJ5L0ludHJpbnNpY0xpYi9NZW1vcnlJbnRyaW5zaWNzLmMN Cj4gPiArKysgYi9DcnlwdG9Qa2cvTGlicmFyeS9JbnRyaW5zaWNMaWIvTWVtb3J5SW50cmluc2lj cy5jDQo+ID4gQEAgLTIsNyArMiw3IEBADQo+ID4gICAgSW50cmluc2ljIE1lbW9yeSBSb3V0aW5l cyBXcmFwcGVyIEltcGxlbWVudGF0aW9uIGZvciBPcGVuU1NMLWJhc2VkDQo+ID4gICAgQ3J5cHRv Z3JhcGhpYyBMaWJyYXJ5Lg0KPiA+DQo+ID4gLUNvcHlyaWdodCAoYykgMjAxMCAtIDIwMTQsIElu dGVsIENvcnBvcmF0aW9uLiBBbGwgcmlnaHRzDQo+ID4gcmVzZXJ2ZWQuPEJSPg0KPiA+ICtDb3B5 cmlnaHQgKGMpIDIwMTAgLSAyMDE3LCBJbnRlbCBDb3Jwb3JhdGlvbi4gQWxsIHJpZ2h0cw0KPiA+ ICtyZXNlcnZlZC48QlI+DQo+ID4gIFRoaXMgcHJvZ3JhbSBhbmQgdGhlIGFjY29tcGFueWluZyBt YXRlcmlhbHMgIGFyZSBsaWNlbnNlZCBhbmQgbWFkZQ0KPiA+IGF2YWlsYWJsZSB1bmRlciB0aGUg dGVybXMgYW5kIGNvbmRpdGlvbnMgb2YgdGhlIEJTRCBMaWNlbnNlICB3aGljaA0KPiA+IGFjY29t cGFuaWVzIHRoaXMgZGlzdHJpYnV0aW9uLiAgVGhlIGZ1bGwgdGV4dCBvZiB0aGUgbGljZW5zZSBt YXkgYmUNCj4gPiBmb3VuZCBhdCBAQCAtMTUsNiArMTUsNyBAQCBXSVRIT1VUIFdBUlJBTlRJRVMg T1INCj4gUkVQUkVTRU5UQVRJT05TIE9GIEFOWSBLSU5ELCBFSVRIRVIgRVhQUkVTUyBPUiBJTVBM SUVELg0KPiA+DQo+ID4gICNpbmNsdWRlIDxCYXNlLmg+DQo+ID4gICNpbmNsdWRlIDxMaWJyYXJ5 L0Jhc2VNZW1vcnlMaWIuaD4NCj4gPiArI2luY2x1ZGUgPExpYnJhcnkvQmFzZUxpYi5oPg0KPiA+ DQo+ID4gIC8qIE9wZW5TU0wgd2lsbCB1c2UgZmxvYXRpbmcgcG9pbnQgc3VwcG9ydCwgYW5kIEMg Y29tcGlsZXIgcHJvZHVjZXMgdGhlDQo+IF9mbHR1c2VkDQo+ID4gICAgIHN5bWJvbCBieSBkZWZh dWx0LiBTaW1wbHkgZGVmaW5lIHRoaXMgc3ltYm9sIGhlcmUgdG8gc2F0aXNmeSB0aGUNCj4gPiBs aW5rZXIuICovIEBAIC00NCwzICs0NSw4IEBAIHZvaWQgKiBtZW1zZXQgKHZvaWQgKmRlc3QsIGNo YXIgY2gsDQo+ID4gdW5zaWduZWQgaW50IGNvdW50KQ0KPiA+DQo+ID4gICAgcmV0dXJuIGRlc3Q7 DQo+ID4gIH0NCj4gPiArDQo+ID4gK2ludCBzdHJjbXAgKGNvbnN0IGNoYXIgKnMxLCBjb25zdCBj aGFyICpzMikgew0KPiA+ICsgIHJldHVybiAoaW50KUFzY2lpU3RyQ21wKHMxLCBzMik7DQo+ID4g K30NCj4gPiAtLQ0KPiA+IDIuMTEuMS53aW5kb3dzLjENCj4gPg0KPiA+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+ID4gZWRrMi1kZXZlbCBtYWlsaW5n IGxpc3QNCj4gPiBlZGsyLWRldmVsQGxpc3RzLjAxLm9yZw0KPiA+IGh0dHBzOi8vbGlzdHMuMDEu b3JnL21haWxtYW4vbGlzdGluZm8vZWRrMi1kZXZlbA0K