From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4BBA42041FBC3 for ; Thu, 6 Apr 2017 07:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491488259; x=1523024259; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=XxKP10HUEXwfRCwR4sjxymny+hzsZI4qqWaSNFfRjOk=; b=vB1T67KTJbCVJLY3IGrYvdxDxPyWNiLQcLpSMleeeRhfkeGr62fv9yDZ oxngm2eh/ndsKFV01l4KXdV3L9TvrA==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2017 07:17:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,160,1488873600"; d="scan'208";a="952758624" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 06 Apr 2017 07:17:38 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Apr 2017 07:17:38 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Thu, 6 Apr 2017 22:17:34 +0800 From: "Long, Qin" To: Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Wu, Hao A" , "Tian, Feng" , "Dong, Eric" Thread-Topic: [edk2] [PATCH v2 0/4] Resolving Some CryptoPkg Build Issues Thread-Index: AQHSqqqDJ5FpJIefrEKL6FelBOXq46G3i3sAgACt6fD//5WwAIAAnC2A Date: Thu, 6 Apr 2017 14:17:34 +0000 Message-ID: References: <20170401053834.12856-1-qin.long@intel.com> <51a65891-7565-086a-3827-f29d6b0d3529@redhat.com> <9304ab09-441f-0794-d2da-6cefa7f97672@redhat.com> In-Reply-To: <9304ab09-441f-0794-d2da-6cefa7f97672@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/4] Resolving Some CryptoPkg Build Issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 14:17:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Thursday, April 6, 2017 8:57 PM > To: Long, Qin ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Hao A ; Tian, > Feng ; Dong, Eric > Subject: Re: [edk2] [PATCH v2 0/4] Resolving Some CryptoPkg Build Issues >=20 > On 04/06/17 13:26, Long, Qin wrote: > > Thanks, Laszlo. > > > > And the last "workaround" patch can be dropped, since we introduced > > the new [Includes.Common.Private] setting in Package DEC file (from my > > last patch). This will help to eliminate the potential macro > > re-definition risk. >=20 > Is the [Includes.Common.Private] section documented somewhere? I > checked the DEC spec v1.25, and it's not described there. Should I file a > documentation BZ about this? The feature was introduced by the Commit ("c28d2e1047816164ffec552e4a337512= 2cbcc6b6"). I will check the documentation status with the owner.=20 >=20 > Thanks > Laszlo >=20 > > It's still valuable to refine openssl e_os2.h definition for > > consistence, which was submitted / approved by the PR > > (https://github.com/openssl/openssl/pull/3121) > > > > > > Best Regards & Thanks, > > LONG, Qin > > > >> -----Original Message----- > >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > >> Of Laszlo Ersek > >> Sent: Thursday, April 6, 2017 4:55 PM > >> To: Long, Qin ; edk2-devel@lists.01.org > >> Cc: Ye, Ting ; Wu, Hao A ; > >> Tian, Feng ; Dong, Eric > >> Subject: Re: [edk2] [PATCH v2 0/4] Resolving Some CryptoPkg Build > >> Issues > >> > >> On 04/01/17 07:38, Long Qin wrote: > >>> From: Qin Long > >>> > >>> V2: > >>> Updated the patches as the comments from Laszlo > (lersek@redhat.com). > >>> And filed two TianoCore BZ (#455, #456) to track the further follow= -ups > >>> on openssl and EDKII-CryptoPkg: > >>> https://bugzilla.tianocore.org/show_bug.cgi?id=3D455 > >>> https://bugzilla.tianocore.org/show_bug.cgi?id=3D456 > >>> > >>> This patch series introduced some hotfixes and workaround to resolve > >>> the build issues under different toolchain, and from potential > >>> external consumers, including: > >>> - build warning under GCC48 and VS2010 toolchain; > >>> - Potential unresolved external symbol link issue; > >>> - One bug fix of timer() wrapper in ConstantTimeClock.c; > >>> - One workaround to resolve macro re-definitions issue from some > >>> external BaseCryptLib consumer. > >>> > >>> (https://github.com/qloong/edk2/commits/dev-openssl-hotfix) > >>> > >>> Qin Long (4): > >>> CryptoPkg/OpensslLib: Suppress extra build warnings in openssl sour= ce > >>> CryptoPkg: Fix possible unresolved external symbol issue. > >>> CryptoPkg/BaseCryptLib: Adding NULL checking in time() wrapper. > >>> CryptoPkg: One workaround to resolve potential build issue. > >>> > >>> CryptoPkg/Include/CrtLibSupport.h | 1 + > >>> CryptoPkg/Include/openssl/e_os2.h | 321 > >> +++++++++++++++++++++ > >>> .../BaseCryptLib/SysCall/ConstantTimeClock.c | 6 +- > >>> CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 +- > >>> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 15 +- > >>> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 15 +- > >>> 6 files changed, 355 insertions(+), 13 deletions(-) create mode > >>> 100644 CryptoPkg/Include/openssl/e_os2.h > >>> > >> > >> I can see the upstream OpenSSL pull req / issue report references in > >> TianoCore BZs 455 and 456. > >> > >> series > >> Reviewed-by: Laszlo Ersek > >> > >> Thanks! > >> Laszlo > >> _______________________________________________ > >> edk2-devel mailing list > >> edk2-devel@lists.01.org > >> https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > >