From: "Long, Qin" <qin.long@intel.com>
To: "Zhang, Chao B" <chao.b.zhang@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [PATCH] SecurityPkg:Tcg2Smm: Update Interrupt resource name
Date: Tue, 12 Dec 2017 08:40:48 +0000 [thread overview]
Message-ID: <BF2CCE9263284D428840004653A28B6E54030A13@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20171212074032.17872-1-chao.b.zhang@intel.com>
Reviewed-by: Long Qin <qin.long@intel.com>
Best Regards & Thanks,
LONG, Qin
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zhang, Chao B
Sent: Tuesday, December 12, 2017 3:41 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Long, Qin <qin.long@intel.com>
Subject: [edk2] [PATCH] SecurityPkg:Tcg2Smm: Update Interrupt resource name
Update TPM interrupt resource descriptor name for better compatibility to old ASL compiler.
Cc: Long Qin <qin.long@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
---
SecurityPkg/Tcg/Tcg2Smm/Tpm.asl | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl b/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl index 76a8a13..f528305 100644
--- a/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl
+++ b/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl
@@ -97,7 +97,7 @@ DefinitionBlock (
Name(RESO, ResourceTemplate () {
Memory32Fixed (ReadWrite, 0xfed40000, 0x5000, REGS)
- Interrupt(ResourceConsumer, Level, ActiveLow, Shared, , , IRQ) {12}
+ Interrupt(ResourceConsumer, Level, ActiveLow, Shared, , , INTR)
+ {12}
})
//
@@ -120,16 +120,16 @@ DefinitionBlock (
// Use the field name to identify the offsets in the argument
// buffer and RESO buffer.
//
- CreateDWordField(Arg0, ^IRQ._INT, IRQ0)
- CreateDWordField(RESO, ^IRQ._INT, LIRQ)
+ CreateDWordField(Arg0, ^INTR._INT, IRQ0)
+ CreateDWordField(RESO, ^INTR._INT, LIRQ)
Store(IRQ0, LIRQ)
- CreateBitField(Arg0, ^IRQ._HE, ITRG)
- CreateBitField(RESO, ^IRQ._HE, LTRG)
+ CreateBitField(Arg0, ^INTR._HE, ITRG)
+ CreateBitField(RESO, ^INTR._HE, LTRG)
Store(ITRG, LTRG)
- CreateBitField(Arg0, ^IRQ._LL, ILVL)
- CreateBitField(RESO, ^IRQ._LL, LLVL)
+ CreateBitField(Arg0, ^INTR._LL, ILVL)
+ CreateBitField(RESO, ^INTR._LL, LLVL)
Store(ILVL, LLVL)
//
--
1.9.5.msysgit.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-12-12 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 7:40 [PATCH] SecurityPkg:Tcg2Smm: Update Interrupt resource name Zhang, Chao B
2017-12-12 8:40 ` Long, Qin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF2CCE9263284D428840004653A28B6E54030A13@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox