Re: [Patch] CryptoPkg PeiCryptLib: Enable SHA384/512 support

["Long, Qin" <qin.long@intel.com>]

Hi, Chao,

The update from NULL to real wrapper looks good to me.
Please also update the "Note" part in this INF's comment before your commit, since SHA384/512 was noted as "not supported" before. 

Reviewed-by: Long Qin <qin.long@intel.com>


Best Regards & Thanks,
LONG, Qin

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zhang,
> Chao B
> Sent: Thursday, June 7, 2018 10:30 PM
> To: edk2-devel@lists.01.org
> Cc: Zhang, Chao B <chao.b.zhang@intel.com>; Long, Qin <qin.long@intel.com>
> Subject: [edk2] [Patch] CryptoPkg PeiCryptLib: Enable SHA384/512 support
> 
> Enable SHA384/512 support in PEI phase.
> 
> Cc: Long Qin <qin.long@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
> ---
>  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> index f1f709ef6d..e08627be24 100644
> --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> @@ -11,11 +11,11 @@
>  #  functions, PKCS#7 SignedData sign functions, Diffie-Hellman functions, X.509
> #  certificate handler functions, authenticode signature verification functions,  #
> PEM handler functions, and pseudorandom number generator functions are not
> #  supported in this instance.
>  #
> -#  Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2010 - 2018, Intel Corporation. All rights
> +reserved.<BR>
>  #  This program and the accompanying materials  #  are licensed and made
> available under the terms and conditions of the BSD License  #  which
> accompanies this distribution.  The full text of the license may be found at  #
> http://opensource.org/licenses/bsd-license.php
>  #
> @@ -42,11 +42,11 @@
>  [Sources]
>    Hash/CryptMd4Null.c
>    Hash/CryptMd5.c
>    Hash/CryptSha1.c
>    Hash/CryptSha256.c
> -  Hash/CryptSha512Null.c
> +  Hash/CryptSha512.c
>    Hmac/CryptHmacMd5Null.c
>    Hmac/CryptHmacSha1Null.c
>    Hmac/CryptHmacSha256Null.c
>    Cipher/CryptAesNull.c
>    Cipher/CryptTdesNull.c
> --
> 2.16.2.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel