From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=qin.long@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1D31C211093B8 for ; Thu, 7 Jun 2018 08:45:50 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2018 08:45:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,486,1520924400"; d="scan'208";a="62134067" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 07 Jun 2018 08:45:49 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Jun 2018 08:45:49 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Jun 2018 08:45:49 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Thu, 7 Jun 2018 23:45:47 +0800 From: "Long, Qin" To: "Zhang, Chao B" , "edk2-devel@lists.01.org" CC: "Zhang, Chao B" Thread-Topic: [edk2] [Patch] CryptoPkg PeiCryptLib: Enable SHA384/512 support Thread-Index: AQHT/mwQTfkBJpy6XU+7XVpvTVN3VaRU7xaw Date: Thu, 7 Jun 2018 15:45:47 +0000 Message-ID: References: <20180607143005.15508-1-chao.b.zhang@intel.com> In-Reply-To: <20180607143005.15508-1-chao.b.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWQyZWI3ZmQtN2UxNC00ZWE2LTkwMTUtZTIzNmE0YzRkYTVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaDNTMms2SVBETkNPSmtORDhlK3FDTTVSU25BNHZtQUo3UmNLVmxFXC9keDQzc1RDTHRBVElpU3NOUWljTCtiNlQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] CryptoPkg PeiCryptLib: Enable SHA384/512 support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 15:45:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Chao, The update from NULL to real wrapper looks good to me. Please also update the "Note" part in this INF's comment before your commit= , since SHA384/512 was noted as "not supported" before.=20 Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zh= ang, > Chao B > Sent: Thursday, June 7, 2018 10:30 PM > To: edk2-devel@lists.01.org > Cc: Zhang, Chao B ; Long, Qin > Subject: [edk2] [Patch] CryptoPkg PeiCryptLib: Enable SHA384/512 support >=20 > Enable SHA384/512 support in PEI phase. >=20 > Cc: Long Qin > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Chao Zhang > Signed-off-by: Zhang, Chao B > --- > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > index f1f709ef6d..e08627be24 100644 > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > @@ -11,11 +11,11 @@ > # functions, PKCS#7 SignedData sign functions, Diffie-Hellman functions= , X.509 > # certificate handler functions, authenticode signature verification fun= ctions, # > PEM handler functions, and pseudorandom number generator functions are no= t > # supported in this instance. > # > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. > +# Copyright (c) 2010 - 2018, Intel Corporation. All rights > +reserved.
> # This program and the accompanying materials # are licensed and made > available under the terms and conditions of the BSD License # which > accompanies this distribution. The full text of the license may be found= at # > http://opensource.org/licenses/bsd-license.php > # > @@ -42,11 +42,11 @@ > [Sources] > Hash/CryptMd4Null.c > Hash/CryptMd5.c > Hash/CryptSha1.c > Hash/CryptSha256.c > - Hash/CryptSha512Null.c > + Hash/CryptSha512.c > Hmac/CryptHmacMd5Null.c > Hmac/CryptHmacSha1Null.c > Hmac/CryptHmacSha256Null.c > Cipher/CryptAesNull.c > Cipher/CryptTdesNull.c > -- > 2.16.2.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel