public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Long, Qin" <qin.long@intel.com>
To: "Zhang, Chao B" <chao.b.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [Patch] SecurityPkg:Tcg: Fix comment typos
Date: Mon, 16 Jul 2018 08:01:40 +0000	[thread overview]
Message-ID: <BF2CCE9263284D428840004653A28B6E5414D890@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180716072039.27660-1-chao.b.zhang@intel.com>

Reviewed-by: Long Qin <qin.long@intel.com>

(BTW: Please remove the extra "Signed-off-by" signature)


Best Regards & Thanks,
LONG, Qin

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Zhang, Chao B
> Sent: Monday, July 16, 2018 3:21 PM
> To: edk2-devel@lists.01.org
> Cc: Long Qin <long.qin@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [edk2] [Patch] SecurityPkg:Tcg: Fix comment typos
> 
> "Triggle" is a typo. Fix it with "Trigger"
> 
> Cc: Long Qin <long.qin@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
> ---
>  SecurityPkg/Tcg/Tcg2Smm/Tpm.asl | 16 ++++++++--------
> SecurityPkg/Tcg/TcgSmm/Tpm.asl  | 16 ++++++++--------
>  2 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl
> b/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl index 50dea0ab9a..471b6b1fa1 100644
> --- a/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl
> +++ b/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl
> @@ -257,16 +257,16 @@ DefinitionBlock (
>            // Bit4 -- DisableAutoDetect. 0 -- Firmware MAY autodetect.
>            //
>            If (LNot (And (MORD, 0x10)))
>            {
>              //
> -            // Triggle the SMI through ACPI _PTS method.
> +            // Trigger the SMI through ACPI _PTS method.
>              //
>              Store (0x02, MCIP)
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (MCIN, IOB2)
>            }
>          }
>          Return (0)
> @@ -363,11 +363,11 @@ DefinitionBlock (
>              Store (DerefOf (Index (Arg2, 0x00)), PPRQ)
>              Store (0, PPRM)
>              Store (0x02, PPIP)
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (PPIN, IOB2)
>              Return (FRET)
> 
> 
> @@ -394,11 +394,11 @@ DefinitionBlock (
>              // e) Return TPM Operation Response to OS Environment
>              //
>              Store (0x05, PPIP)
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (PPIN, IOB2)
> 
>              Store (LPPR, Index (TPM3, 0x01))
>              Store (PPRP, Index (TPM3, 0x02)) @@ -426,11 +426,11 @@
> DefinitionBlock (
>              If (LEqual (PPRQ, 23)) {
>                Store (DerefOf (Index (Arg2, 0x01)), PPRM)
>              }
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (PPIN, IOB2)
>              Return (FRET)
>            }
>            Case (8)
> @@ -440,11 +440,11 @@ DefinitionBlock (
>              //
>              Store (8, PPIP)
>              Store (DerefOf (Index (Arg2, 0x00)), UCRQ)
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (PPIN, IOB2)
> 
>              Return (FRET)
>            }
> @@ -474,16 +474,16 @@ DefinitionBlock (
>              // Save the Operation Value of the Request to MORD (reserved
> memory)
>              //
>              Store (DerefOf (Index (Arg2, 0x00)), MORD)
> 
>              //
> -            // Triggle the SMI through ACPI _DSM method.
> +            // Trigger the SMI through ACPI _DSM method.
>              //
>              Store (0x01, MCIP)
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (MCIN, IOB2)
>              Return (MRET)
>            }
>            Default {BreakPoint}
> diff --git a/SecurityPkg/Tcg/TcgSmm/Tpm.asl
> b/SecurityPkg/Tcg/TcgSmm/Tpm.asl index 12f24f3996..2114283b45 100644
> --- a/SecurityPkg/Tcg/TcgSmm/Tpm.asl
> +++ b/SecurityPkg/Tcg/TcgSmm/Tpm.asl
> @@ -93,16 +93,16 @@ DefinitionBlock (
>            // Bit4 -- DisableAutoDetect. 0 -- Firmware MAY autodetect.
>            //
>            If (LNot (And (MORD, 0x10)))
>            {
>              //
> -            // Triggle the SMI through ACPI _PTS method.
> +            // Trigger the SMI through ACPI _PTS method.
>              //
>              Store (0x02, MCIP)
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (MCIN, IOB2)
>            }
>          }
>          Return (0)
> @@ -198,11 +198,11 @@ DefinitionBlock (
> 
>              Store (DerefOf (Index (Arg2, 0x00)), PPRQ)
>              Store (0x02, PPIP)
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (PPIN, IOB2)
>              Return (FRET)
> 
> 
> @@ -229,11 +229,11 @@ DefinitionBlock (
>              // e) Return TPM Operation Response to OS Environment
>              //
>              Store (0x05, PPIP)
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (PPIN, IOB2)
> 
>              Store (LPPR, Index (TPM3, 0x01))
>              Store (PPRP, Index (TPM3, 0x02)) @@ -257,11 +257,11 @@
> DefinitionBlock (
>              //
>              Store (7, PPIP)
>              Store (DerefOf (Index (Arg2, 0x00)), PPRQ)
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (PPIN, IOB2)
>              Return (FRET)
>            }
>            Case (8)
> @@ -271,11 +271,11 @@ DefinitionBlock (
>              //
>              Store (8, PPIP)
>              Store (DerefOf (Index (Arg2, 0x00)), UCRQ)
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (PPIN, IOB2)
> 
>              Return (FRET)
>            }
> @@ -305,16 +305,16 @@ DefinitionBlock (
>              // Save the Operation Value of the Request to MORD (reserved
> memory)
>              //
>              Store (DerefOf (Index (Arg2, 0x00)), MORD)
> 
>              //
> -            // Triggle the SMI through ACPI _DSM method.
> +            // Trigger the SMI through ACPI _DSM method.
>              //
>              Store (0x01, MCIP)
> 
>              //
> -            // Triggle the SMI interrupt
> +            // Trigger the SMI interrupt
>              //
>              Store (MCIN, IOB2)
>              Return (MRET)
>            }
>            Default {BreakPoint}
> --
> 2.16.2.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2018-07-16  8:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16  7:20 [Patch] SecurityPkg:Tcg: Fix comment typos Zhang, Chao B
2018-07-16  8:01 ` Long, Qin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BF2CCE9263284D428840004653A28B6E5414D890@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox