From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=qin.long@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6231721962301 for ; Wed, 8 Aug 2018 23:22:02 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 23:22:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,214,1531810800"; d="scan'208";a="61790111" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga008.fm.intel.com with ESMTP; 08 Aug 2018 23:22:01 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 23:22:01 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 23:22:01 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by shsmsx102.ccr.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 14:21:59 +0800 From: "Long, Qin" To: "Zhang, Chao B" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] SecurityPkg: HashLib: Update HashLib file GUID Thread-Index: AQHUL6cgd/CvFl8xi0+jO+rTlw7u4KS28WSg Date: Thu, 9 Aug 2018 06:21:59 +0000 Message-ID: References: <20180809060612.9800-1-chao.b.zhang@intel.com> In-Reply-To: <20180809060612.9800-1-chao.b.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGY4YzkyYjktMzc1Yy00NjhhLTkyM2UtNDhiYzU3OTYyYzQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN2c0ZmY4MkNDWGF3dXYxMzRKejFrNjJiZjlwZnNUTzBodWhIK0xPdDc2QXB3bFUzSlhzNjhoWjhLYUJpeFlYRyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] SecurityPkg: HashLib: Update HashLib file GUID X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 06:22:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Chao, Please change the lowercase letters in the new GUID to uppercase lett= ers when committing this. Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zh= ang, > Chao B > Sent: Wednesday, August 8, 2018 11:06 PM > To: edk2-devel@lists.01.org > Cc: Long, Qin > Subject: [edk2] [Patch] SecurityPkg: HashLib: Update HashLib file GUID >=20 > 2 file GUIDs conflict with existing SHA256 Lib. Update them. >=20 > Cc: Long Qin > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhang, Chao B > --- > SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf | 2 = +- > SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf | 2 += - > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > b/SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > index 76677794fa..cf12587354 100644 > --- a/SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > +++ b/SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.in > +++ f > @@ -15,11 +15,11 @@ >=20 > [Defines] > INF_VERSION =3D 0x00010005 > BASE_NAME =3D HashInstanceLibSha384 > MODULE_UNI_FILE =3D HashInstanceLibSha384.uni > - FILE_GUID =3D 5810798A-ED30-4080-8DD7-B9667A748C0= 2 > + FILE_GUID =3D 74223710-17A9-478f-9B24-E354496B968= B > MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > LIBRARY_CLASS =3D NULL > CONSTRUCTOR =3D HashInstanceLibSha384Constructor >=20 > diff --git > a/SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > b/SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > index 94929a8736..917c23f3d5 100644 > --- a/SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > +++ b/SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.in > +++ f > @@ -15,11 +15,11 @@ >=20 > [Defines] > INF_VERSION =3D 0x00010005 > BASE_NAME =3D HashInstanceLibSha512 > MODULE_UNI_FILE =3D HashInstanceLibSha512.uni > - FILE_GUID =3D 5810798A-ED30-4080-8DD7-B9667A748C0= 2 > + FILE_GUID =3D 959C3685-AC3F-4f3e-AC5B-7E2A64BADD3= 6 > MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > LIBRARY_CLASS =3D NULL > CONSTRUCTOR =3D HashInstanceLibSha512Constructor >=20 > -- > 2.16.2.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel