From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=qin.long@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D733321B02822 for ; Tue, 4 Sep 2018 16:18:42 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2018 16:18:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,330,1531810800"; d="scan'208";a="68402022" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 04 Sep 2018 16:18:41 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 4 Sep 2018 16:18:41 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 4 Sep 2018 16:18:41 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Wed, 5 Sep 2018 07:18:39 +0800 From: "Long, Qin" To: Stephano Cetola , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [staging/MicroPythonTestFramework][PATCH] MpyTestFrameworkPkg: use minified jquery source Thread-Index: AQHURHf4azs5aebewkWCLJKLH02WVKTgwidA Date: Tue, 4 Sep 2018 23:18:39 +0000 Message-ID: References: <20180904175107.38605-1-stephano.cetola@linux.intel.com> In-Reply-To: <20180904175107.38605-1-stephano.cetola@linux.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWQ5OGI5NTEtOTNlYi00ZmE1LWI5MzMtMmFiMmVjMGY1NTVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieWtEdEl1V1RTKytKRkpoRm5CdUxBVldIbDVadHZJWUo5TFk1ZUdLZ1NZK2lzcHVsam1zOTAwTmVHRENCTHNIVyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [staging/MicroPythonTestFramework][PATCH] MpyTestFrameworkPkg: use minified jquery source X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2018 23:18:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Stephano Cetola > Sent: Tuesday, September 4, 2018 10:51 AM > To: edk2-devel@lists.01.org > Cc: Long, Qin > Subject: [edk2] [staging/MicroPythonTestFramework][PATCH] > MpyTestFrameworkPkg: use minified jquery source >=20 > We should be using the compressed "minified" jquery source file rather th= an the > uncompressed version, as it will reduce the page load times. >=20 > This updates the relevant FreeMaker templates, the readme, and the setup = script. > It also corrects a small mistake in the error text of the setup script. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1. > Signed-off-by: Stephano Cetola > --- > MpyTestFrameworkPkg/README.md | 2 +- > .../ReportGenerator/src/main/resources/templates/index.ftl | 2 +- > .../src/main/resources/templates/iteration.ftl | 4 ++-- > .../src/main/resources/templates/recurrentSequence.ftl | 2 +- > MpyTestFrameworkPkg/setup.py | 6 +++--- > 5 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/MpyTestFrameworkPkg/README.md > b/MpyTestFrameworkPkg/README.md index bd1579dcd3..9bcd22d843 100644 > --- a/MpyTestFrameworkPkg/README.md > +++ b/MpyTestFrameworkPkg/README.md > @@ -13,7 +13,7 @@ This test framework is dependent on the MicroPython > Interpreter for UEFI: [Micro > * Install [Python27](https://www.python.org/). > * Install Maven, using the official site tutorial: [Installing Apache > Maven](https://maven.apache.org/install.html). JDK 1.8 is preferred. > * Download `Chart.bundle.min.js` from the [ChartJS official > site](https://github.com/chartjs/Chart.js/releases) and copy it to > `MpyTestFrameworkPkg\Report\resources\js` > - * Download `jquery-3.3.1.js` from the [JQuery official > site](https://jquery.com/download/) and copy it to > `MpyTestFrameworkPkg\Report\resources\js` > + * Download `jquery-3.3.1.min.js` from the [JQuery official > + site](https://jquery.com/download/) and copy it to > + `MpyTestFrameworkPkg\Report\resources\js` >=20 > ### Configuration >=20 > diff --git > a/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templat > es/index.ftl > b/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templat > es/index.ftl > index ed611f3805..d58c002baf 100644 > --- > a/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templat > es/index.ftl > +++ > b/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templ > +++ ates/index.ftl > @@ -3,7 +3,7 @@ > ETS Report > > > - > + > >=20 > > diff --git > a/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templat > es/iteration.ftl > b/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templat > es/iteration.ftl > index 82b681c8a4..e3f2490215 100644 > --- > a/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templat > es/iteration.ftl > +++ > b/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templ > +++ ates/iteration.ftl > @@ -3,7 +3,7 @@ > ETS Report > > > - > + > > >=20 > @@ -170,4 +170,4 @@ > >=20 > > - > \ No newline at end of file > + > diff --git > a/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templat > es/recurrentSequence.ftl > b/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templat > es/recurrentSequence.ftl > index d3c263cf91..1d09752095 100644 > --- > a/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templat > es/recurrentSequence.ftl > +++ > b/MpyTestFrameworkPkg/Tools/ReportGenerator/src/main/resources/templ > +++ ates/recurrentSequence.ftl > @@ -3,7 +3,7 @@ > ETS Report > > > - > + > >=20 > > diff --git a/MpyTestFrameworkPkg/setup.py b/MpyTestFrameworkPkg/setup.py > index 993a4cc598..4eaf43bfed 100644 > --- a/MpyTestFrameworkPkg/setup.py > +++ b/MpyTestFrameworkPkg/setup.py > @@ -31,8 +31,8 @@ def check_environment(): > error_p('Please download Chart.bundle.min.js to > MpyTestFrameworkPkg/Report/resources/js folder') > return False >=20 > - if not os.path.exists(origin + '/Report' + '/resources' + '/js' + '/= jquery-3.3.1.js'): > - error_p('Please download jquery-3.3.1.jsChart.bundle.min.js to > MpyTestFrameworkPkg/Report/resources/js folder') > + if not os.path.exists(origin + '/Report' + '/resources' + '/js' + '/= jquery- > 3.3.1.min.js'): > + error_p('Please download jquery-3.3.1.min.js > + MpyTestFrameworkPkg/Report/resources/js folder') > return False >=20 > return True > @@ -111,4 +111,4 @@ def generate_target(): >=20 > # Main procedure > if check_environment() =3D=3D True: > - generate_target() > \ No newline at end of file > + generate_target() > -- > 2.17.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel