From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=qin.long@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 933A02117B556 for ; Thu, 25 Oct 2018 06:23:14 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 06:23:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,424,1534834800"; d="scan'208,217";a="274371606" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 25 Oct 2018 06:23:13 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 06:23:13 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 06:23:13 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.199]) with mapi id 14.03.0415.000; Thu, 25 Oct 2018 21:23:10 +0800 From: "Long, Qin" To: Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Ye, Ting" Thread-Topic: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Fix potential integer overflow issue. Thread-Index: AQHUa5ygG57yUE84JE2Q/Zeb+yBEkaUuGHuAgAHVOCA= Date: Thu, 25 Oct 2018 13:23:10 +0000 Message-ID: References: <20181024132202.10596-1-qin.long@intel.com> <9f9769c6-8c3e-73d0-1a0c-06d81de27704@redhat.com> In-Reply-To: <9f9769c6-8c3e-73d0-1a0c-06d81de27704@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGNlNWVhN2MtNzIyZi00ZjlkLWE3YzAtODI4NWMzOGU5YTVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMEFyVHhGajB6RUlzRWdCczJCQ2t5T3hlMXFpbkpHbkttR1lmMDRESnZsMThVekkxTXRtYTRxanhjUWxSd2x6TiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH] CryptoPkg/BaseCryptLib: Fix potential integer overflow issue. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 13:23:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 VGhhbmtzLCBMYXN6bG8uDQoNCkZyb206IExhc3psbyBFcnNlayBbbWFpbHRvOmxlcnNla0ByZWRo YXQuY29tXQ0KU2VudDogVGh1cnNkYXksIE9jdG9iZXIgMjUsIDIwMTggMTI6NTkgQU0NClRvOiBM b25nLCBRaW4gPHFpbi5sb25nQGludGVsLmNvbT47IGVkazItZGV2ZWxAbGlzdHMuMDEub3JnDQpD YzogWWUsIFRpbmcgPHRpbmcueWVAaW50ZWwuY29tPg0KU3ViamVjdDogUmU6IFtlZGsyXSBbUEFU Q0hdIENyeXB0b1BrZy9CYXNlQ3J5cHRMaWI6IEZpeCBwb3RlbnRpYWwgaW50ZWdlciBvdmVyZmxv dyBpc3N1ZS4NCg0KT24gMTAvMjQvMTggMTU6MjIsIExvbmcgUWluIHdyb3RlOg0KPiBUaGUgTG9v a3VwRnJlZU1lbVJlZ2lvbigpIGluIFJ1bnRpbWVNZW1BbGxvY2F0ZS5jIGlzIHVzZWQgdG8gbG9v ay11cA0KPiBmcmVlIG1lbW9yeSByZWdpb24gZm9yIHJ1bnRpbWUgcmVzb3VyY2UgYWxsb2NhdGlv biwgd2hpY2ggd2FzIGRlc2lnbmVkDQo+IHRvIHN1cHBvcnQgcnVudGltZSBhdXRoZW50aWNhdGVk IHZhcmlhYmxlIHNlcnZpY2UuDQo+IFRoZSBkaXJlY3Qgb2Zmc2V0IHN1YnRyYWN0aW9ucyBpbiB0 aGlzIGZ1bmN0aW9uIG1heSBicmluZyBwb3NzaWJsZQ0KPiBpbnRlZ2VyIG92ZXJmbG93IGlzc3Vl Lg0KPg0KPiBUaGlzIHBhdGNoIGlzIHRvIGFkZCB0aGUgZXh0cmEgcGFyYW1ldGVyIGNoZWNrcyB0 byByZW1vdmUgdGhpcyBwb3NzaWJsZQ0KPiBvdmVyZmxvdyByaXNrLg0KPg0KPiBDYzogWWUgVGlu ZyA8dGluZy55ZUBpbnRlbC5jb208bWFpbHRvOnRpbmcueWVAaW50ZWwuY29tPj4NCj4gQ29udHJp YnV0ZWQtdW5kZXI6IFRpYW5vQ29yZSBDb250cmlidXRpb24gQWdyZWVtZW50IDEuMQ0KPiBTaWdu ZWQtb2ZmLWJ5OiBMb25nIFFpbiA8cWluLmxvbmdAaW50ZWwuY29tPG1haWx0bzpxaW4ubG9uZ0Bp bnRlbC5jb20+Pg0KPiAtLS0NCj4gIC4uLi9MaWJyYXJ5L0Jhc2VDcnlwdExpYi9TeXNDYWxsL1J1 bnRpbWVNZW1BbGxvY2F0aW9uLmMgICAgfCAxNCArKysrKysrKysrKysrLQ0KPiAgMSBmaWxlIGNo YW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4NCj4gZGlmZiAtLWdpdCBh L0NyeXB0b1BrZy9MaWJyYXJ5L0Jhc2VDcnlwdExpYi9TeXNDYWxsL1J1bnRpbWVNZW1BbGxvY2F0 aW9uLmMgYi9DcnlwdG9Qa2cvTGlicmFyeS9CYXNlQ3J5cHRMaWIvU3lzQ2FsbC9SdW50aW1lTWVt QWxsb2NhdGlvbi5jDQo+IGluZGV4IDQ2M2YyYmY4NTUuLjkyYmI5ZGRjY2QgMTAwNjQ0DQo+IC0t LSBhL0NyeXB0b1BrZy9MaWJyYXJ5L0Jhc2VDcnlwdExpYi9TeXNDYWxsL1J1bnRpbWVNZW1BbGxv Y2F0aW9uLmMNCj4gKysrIGIvQ3J5cHRvUGtnL0xpYnJhcnkvQmFzZUNyeXB0TGliL1N5c0NhbGwv UnVudGltZU1lbUFsbG9jYXRpb24uYw0KPiBAQCAtMiw3ICsyLDcgQEANCj4gICAgTGlnaHQtd2Vp Z2h0IE1lbW9yeSBNYW5hZ2VtZW50IFJvdXRpbmVzIGZvciBPcGVuU1NMLWJhc2VkIENyeXB0bw0K PiAgICBMaWJyYXJ5IGF0IFJ1bnRpbWUgUGhhc2UuDQo+DQo+IC1Db3B5cmlnaHQgKGMpIDIwMDkg LSAyMDE3LCBJbnRlbCBDb3Jwb3JhdGlvbi4gQWxsIHJpZ2h0cyByZXNlcnZlZC48QlI+DQo+ICtD b3B5cmlnaHQgKGMpIDIwMDkgLSAyMDE4LCBJbnRlbCBDb3Jwb3JhdGlvbi4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC48QlI+DQo+ICBUaGlzIHByb2dyYW0gYW5kIHRoZSBhY2NvbXBhbnlpbmcgbWF0ZXJp YWxzDQo+ICBhcmUgbGljZW5zZWQgYW5kIG1hZGUgYXZhaWxhYmxlIHVuZGVyIHRoZSB0ZXJtcyBh bmQgY29uZGl0aW9ucyBvZiB0aGUgQlNEIExpY2Vuc2UNCj4gIHdoaWNoIGFjY29tcGFuaWVzIHRo aXMgZGlzdHJpYnV0aW9uLiAgVGhlIGZ1bGwgdGV4dCBvZiB0aGUgbGljZW5zZSBtYXkgYmUgZm91 bmQgYXQNCj4gQEAgLTE0MSw2ICsxNDEsMTIgQEAgTG9va3VwRnJlZU1lbVJlZ2lvbiAoDQo+DQo+ ICAgIFN0YXJ0UGFnZUluZGV4ID0gUlRfU0laRV9UT19QQUdFUyAobVJUUGFnZVRhYmxlLT5MYXN0 RW1wdHlQYWdlT2Zmc2V0KTsNCj4gICAgUmVxUGFnZXMgICAgICAgPSBSVF9TSVpFX1RPX1BBR0VT IChBbGxvY2F0aW9uU2l6ZSk7DQo+ICsgIGlmIChSZXFQYWdlcyA+IG1SVFBhZ2VUYWJsZS0+UGFn ZUNvdW50KSB7DQo+ICsgICAgLy8NCj4gKyAgICAvLyBObyBlbm91Z2ggcmVnaW9uIGZvciBvYmpl Y3QgYWxsb2NhdGlvbi4NCj4gKyAgICAvLw0KPiArICAgIHJldHVybiAoVUlOVE4pKC0xKTsNCj4g KyAgfQ0KPg0KPiAgICAvLw0KPiAgICAvLyBMb29rIHVwIHRoZSBmcmVlIG1lbW9yeSByZWdpb24g d2l0aCBpbiBjdXJyZW50IG1lbW9yeSBtYXAgdGFibGUuDQo+IEBAIC0xNzYsNiArMTgyLDEyIEBA IExvb2t1cEZyZWVNZW1SZWdpb24gKA0KPiAgICAvLyBMb29rIHVwIHRoZSBmcmVlIG1lbW9yeSBy ZWdpb24gZnJvbSB0aGUgYmVnaW5uaW5nIG9mIHRoZSBtZW1vcnkgdGFibGUNCj4gICAgLy8gdW50 aWwgdGhlIFN0YXJ0Q3Vyc29yT2Zmc2V0DQo+ICAgIC8vDQo+ICsgIGlmIChSZXFQYWdlcyA+IFN0 YXJ0UGFnZUluZGV4KSB7DQo+ICsgICAgLy8NCj4gKyAgICAvLyBObyBlbm91Z2ggcmVnaW9uIGZv ciBvYmplY3QgYWxsb2NhdGlvbi4NCj4gKyAgICAvLw0KPiArICAgIHJldHVybiAoVUlOVE4pKC0x KTsNCj4gKyAgfQ0KPiAgICBmb3IgKEluZGV4ID0gMDsgSW5kZXggPCAoU3RhcnRQYWdlSW5kZXgg LSBSZXFQYWdlcyk7ICkgew0KPiAgICAgIC8vDQo+ICAgICAgLy8gQ2hlY2sgQ29uc2VjdXRpdmUg UmVxUGFnZXMgUGFnZXMuDQo+DQoNCkFzIGZhciBhcyBJIGNhbiBzZWUsICJSdW50aW1lQ3J5cHRM aWIuaW5mIiAod2hlcmUgdGhpcyBmaWxlIGlzIHVzZWQpIGlzDQpvbmx5IGxpbmtlZCBpbnRvIHJ1 bnRpbWUgRFhFIG1vZHVsZXMgLS0gbm90IFNNTSBtb2R1bGVzLiBUaGF0IG1lYW5zIHRoaXMNCmlz c3VlIGlzIG5vdCBhIHNlY3VyaXR5IGJ1ZywgYmVjYXVzZSBydW50aW1lIERYRSBtb2R1bGVzIGNh biBiZQ0Kb3ZlcndyaXR0ZW4gYnkgdGhlIE9TIGFueXdheS4gKFRoZXkgcmVzaWRlIGluIG5vcm1h bCBSQU0uKSBDYW4geW91DQpwbGVhc2UgY29uZmlybT8NCg0KW3Fsb25nXSBZZXMsIHRoaXMgbGli cmFyeSBpbnN0YW5jZSBpcyBvbmx5IGxpbmtlZCBpbnRvIHJ1bnRpbWUgRFhFIGRyaXZlciwgbm90 IFNNTS4NCkl0IHdhcyBkZXNpZ25lZCB0byBwcm92aWRlIHRoZSBydW50aW1lIGF1dGhlbnRpY2F0 aW9uIC8gdmVyaWZpY2F0aW9uIHN1cHBvcnQNCihmb3IgdmFyaWFibGUgc2VydmljZSkgaW4gZWFy bHkgaW1wbGVtZW50YXRpb24gKG5vbi1TTU0gdmFyaWFibGUgZHJpdmVyKS4NCkJ1dCB0aGUgbWVt b3J5IHVzZWQgaW4gcnVudGltZSBkeGUgbW9kdWxlcyB3aWxsIG5vdCBvdmVyd3JpdHRlbiBzaW5j ZQ0KSXQgd2FzIG1hcmtlZCBhcyDigJxFZmlSdW50aW1lU2VydmljZXNEYXRh4oCdLiBUaGUgUnVu dGltZUNyeXB0TGliIGFwcGxpZWQNCm9uZSBsaWdodC13ZWlnaHQgbWVtb3J5IG1hbmFnZW1lbnQg cm91dGluZXMgdG8gbWVldCB0aGUgaW50ZXJuYWwgbWVtb3J5DQphbGxvY2F0aW9uIC8gZnJlZSB1 c2FnZSB3aGVuIG9wZW5zc2wgaGFuZGxlIFBLQ1M3IHZlcmlmaWNhdGlvbi4NClRoZSBwb3NzaWJs ZSBpbnRlZ2VyIG92ZXJmbG93IGlzc3VlIHdhcyBmb3VuZCBmcm9tIGNvZGUgcmV2aWV3LiBZZXMs IEkgdGhpbmsNCml04oCZcyBsb3cgcmlzayBzaW5jZSBtb3N0IHJ1bnRpbWUgdmFyaWFibGUgc2Vy dmljZSB3YXMgdXBkYXRlZCB0byB1c2Ugc21tIHNvbHV0aW9uLg0KDQpOb25ldGhlbGVzcywgaXQg d291bGQgYmUgbmljZSB0byBleHBsYWluIGluIHRoZSBjb21taXQgbWVzc2FnZSwgd2hhdA0KZXhh Y3RseSAiUmVxUGFnZXMiIGRlcGVuZHMgb24uDQpbcWxvbmddIFJlcVBhZ2VzIGlzIG9uZSB2YXJp YWJsZSB0byBkZXNjcmliZSB0aGUgcmVxdWlyZWQgcGFnZXMgZm9yIG1lbW9yeSBhbGxvY2F0aW9u DQooZnJvbSB0aGUgbWFsbG9jKCkgY2FsbCBpbiBPcGVuU1NMIGNvZGVzIHdoZW4gaGFuZGxpbmcg cGtjczcgdmVyaWZpY2F0aW9uKS4NCkl04oCZcyBoYXJkIHRvIHN0YXRlIHRoZSBzcGVjaWZpYyBk ZXBlbmRlbmN5ICh3aGljaCBpbmNsdWRlIHRoZSBQS0NTNyBkYXRhIGFuZCBzb21lDQpvcGVuc3Ns IGludGVybmFsIGRhdGEgc3RydWN0dXJlKS4NCg0KSWYgbmVlZGVkLCBwbGVhc2UgZmlsZSBhIEJa IGFzIHdlbGwuIChJJ20gbm90IHNheWluZyBpdCdzIHJlcXVpcmVkLCBidXQNCnlvdSBtaWdodCB3 YW50IHRvIGNvbnNpZGVyIGl0LCBhbmQgcmVmZXJlbmNlIGl0IGluIHRoZSBjb21taXQgbWVzc2Fn ZS4pDQoNCltxbG9uZ10gU3VyZS4gSXQgbWFrZSBzZW5zZS4NCiAgICAgICAgICAgICBBbmQgY3Jl YXRlIG9uZTogaHR0cHM6Ly9idWd6aWxsYS50aWFub2NvcmUub3JnL3Nob3dfYnVnLmNnaT9pZD0x Mjc1DQoNClRoYW5rcw0KTGFzemxvDQo=