From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: xiaoyux.lu@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Tue, 14 May 2019 19:01:47 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2019 19:01:47 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 14 May 2019 19:01:47 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 14 May 2019 19:01:36 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 14 May 2019 19:01:35 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.33]) with mapi id 14.03.0415.000; Wed, 15 May 2019 10:00:28 +0800 From: "Xiaoyu lu" To: "devel@edk2.groups.io" , "glin@suse.com" , "Wang, Jian J" CC: Laszlo Ersek , "Ye, Ting" Subject: Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b Thread-Topic: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b Thread-Index: AQHVCY9yElnKq46NqE6YdGh/uj1aeaZo6ciAgAC2IACAAGG8AIAAFlaAgADQ44CAAIZtoA== Date: Wed, 15 May 2019 02:00:27 +0000 Message-ID: References: <1557753912-30122-1-git-send-email-xiaoyux.lu@intel.com> <20190514061630.GC23588@GaryWorkstation> <20190515015353.GD23588@GaryWorkstation> In-Reply-To: <20190515015353.GD23588@GaryWorkstation> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTIzZGNjYTUtNTVhNy00NWJkLTlhMjEtODhmMWM5YTJmNjA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRnN5TmEwUFhhaU9SQlNFYTlIdWFJQ2ZcL2dESzdcL1dEWnNSU0N0NVdlNUJIMDVyckN6Y2hybkQ5cGpIWHJYR2IrIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: xiaoyux.lu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gary Lin: I also need to modify the code about the entropy source today. But I have uploaded a TimerLib based implementation. https://github.com/xiaoyuxlu/edk2/commits/bz_1089_patch_v4 Thanks. Xiaoyu -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gary= Lin Sent: Wednesday, May 15, 2019 9:54 AM To: devel@edk2.groups.io; Wang, Jian J Cc: Laszlo Ersek ; Lu, XiaoyuX ; = Ye, Ting Subject: Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1= .1b On Tue, May 14, 2019 at 01:26:15PM +0000, Wang, Jian J wrote: > Yes, please wait for v4 version of this patch series. Good. I'm looking forward to the new series :) Thanks, Gary Lin >=20 > Regards, > Jian >=20 >=20 > > -----Original Message----- > > From: Laszlo Ersek [mailto:lersek@redhat.com] > > Sent: Tuesday, May 14, 2019 8:06 PM > > To: devel@edk2.groups.io; glin@suse.com > > Cc: Lu, XiaoyuX ; Wang, Jian J=20 > > ; Ye, Ting > > Subject: Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL=20 > > to 1.1.1b > >=20 > > On 05/14/19 08:16, Gary Lin wrote: > > > On Mon, May 13, 2019 at 09:24:39PM +0200, Laszlo Ersek wrote: > > >> On 05/13/19 15:25, Xiaoyu lu wrote: > > >>> (1) CryptoPkg/OpensslLib: Modify process_files.pl for upgrading O= penSSL > > >>> OpenSSL only support seeding NONE for UEFI(rand_unix.c line 93). > > >>> So add --with-rand-seed=3Dnone to process_files.pl. > > >>> > > >>> (2) CryptoPkg/OpensslLib: Exclude unnecessary files in process_fi= les.pl > > >>> When running process_files.py to configure OpenSSL, we can=20 > > >>> exclude some > > unnecessary files. This can reduce porting time, compiling time and li= brary size. > > >>> > > >>> (3) CryptoPkg/IntrinsicLib: Fix possible unresolved external=20 > > >>> symbol issue > > >>> > > >>> (4) CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL > > >>> Disable warning for building OpenSSL_1_1_1b > > >>> > > >>> (5) CryptoPkg: Upgrade OpenSSL to 1.1.1b > > >>> Update OpenSSL submodule to OpenSSL_1_1_1b > > >>> OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687) > > >>> > > >>> OpenSSL doesn't implement some rand_pool function for UEFI. > > >>> Use EFI_RNG_PROTOCOL to generate random for entropy. > > >>> If EFI_RNG_PROTOCOL is not avaliable, fall back to performance > > >>> counter, but we not sure about the amount of randomness it provi= des. > > >>> > > >>> (6) CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward > > >>> compatible > > >>> > > >>> Note: Will be remove next update. > > >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1792 > > >>> Ref: https://github.com/openssl/openssl/pull/4338 > > >>> > > >>> > > >>> Cc: Jian J Wang > > >>> Cc: Ting Ye > > >> > > >> I'm withdrawing from reviewing or testing this series. > > >> > > >> Gary, if you have the time, can you please regression test this=20 > > >> (for HTTPS boot) in both OVMF and ArmVirtQemu? > > >> > > > I'll find some time to do the regression test tomorrorw. > >=20 > > Thanks, Gary! > >=20 > > Xiaoyu might post a v4 with a remote topic branch for reviewers to=20 > > fetch; I suggest awaiting that. (The series is difficult to apply=20 > > with > > git-am.) > >=20 > > Thanks > > Laszlo > >=20 > > > Cheers, > > > > > > Gary Lin > > > > > >=20 > > > >=20 >=20 >=20 >=20