From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: xiaoyux.lu@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Tue, 04 Jun 2019 23:33:46 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 23:33:45 -0700 X-ExtLoop1: 1 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 04 Jun 2019 23:33:45 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 23:33:45 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.120]) with mapi id 14.03.0415.000; Wed, 5 Jun 2019 14:33:43 +0800 From: "Xiaoyu Lu" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem Thread-Topic: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem Thread-Index: AQHVG19PLG7tfDEHmUWtiTSzZwI4ZaaMCheAgACL6VA= Date: Wed, 5 Jun 2019 06:33:42 +0000 Message-ID: References: <1559712295-891-1-git-send-email-xiaoyux.lu@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E46C045@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46C045@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2ZjOWE4ZDQtYTY3Yi00YTAxLTljNmQtOTU0Yzg3MDZmOTk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTDhvTE5vTm1nVklXZSsxMEgyZDNYVHRxUW9tZHJVT3BMTVdFZ0FMU1FZeHZoWVROcW5QRE9penNFV2hTeTZFRiJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: xiaoyux.lu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, > -----Original Message----- > From: Gao, Liming > Sent: Wednesday, June 5, 2019 1:57 PM > To: devel@edk2.groups.io; Lu, XiaoyuX > Cc: Bi, Dandan ; Wang, Jian J > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix > CLANG38 IA32 build problem >=20 > Xiaoyu: >=20 > >-----Original Message----- > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >Xiaoyu Lu > >Sent: Wednesday, June 05, 2019 1:25 PM > >To: devel@edk2.groups.io > >Cc: Lu, XiaoyuX ; Bi, Dandan > ; > >Wang, Jian J > >Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG3= 8 > >IA32 build problem > > > >When use clang-3.8 to build the NetworkPkg, compiler optimization > >may use memcpy for memory copy. For example: > > > > CryptoPkg/Library/OpensslLib/openssl/ssl/ssl_rsa.c:918: undefined > > reference to `memcpy'` > > > >Compiler optimization is sophisticated, but we can work around it > >use __attribute__((__used__)) to informs the compiler that symbol > >should be retained in the object file, even if it may be > >unreferenced. > > > >Cc: Jian J Wang > >Cc: Dandan Bi > >Signed-off-by: Xiaoyu Lu > >--- > > CryptoPkg/Library/IntrinsicLib/CopyMem.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > >diff --git a/CryptoPkg/Library/IntrinsicLib/CopyMem.c > >b/CryptoPkg/Library/IntrinsicLib/CopyMem.c > >index e29b4918d200..7faf5a34d8c1 100644 > >--- a/CryptoPkg/Library/IntrinsicLib/CopyMem.c > >+++ b/CryptoPkg/Library/IntrinsicLib/CopyMem.c > >@@ -10,8 +10,21 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include > > #include > > > >+#if defined(__clang__) && !defined(__APPLE__) >=20 > So, this change is only for CLANG tool chain. >=20 > >+ > >+/* Copies bytes between buffers */ > >+static __attribute__((__used__)) >=20 > What purpose for static? >=20 Because I want __memcpy only use in this file scope. > >+void * __memcpy (void *dest, const void *src, unsigned int count) > >+{ > >+ return CopyMem (dest, src, (UINTN)count); > >+} > >+__attribute__((__alias__("__memcpy"))) > >+void * memcpy (void *dest, const void *src, unsigned int count); >=20 > __memcpy is IA32 Intrinsic API, memcpy is X64 Intrinsic API, right? >=20 __memcpy isn't IA32 Intrinsic API, only memcpy is intrinsic API for both I= A32 and X64. The reason I alias memcpy and use __attribute__((__used__)) is let compile= r retain symbol in object file, So it can link correct. Is this correct? > Thanks > Liming > >+ > >+#else > > /* Copies bytes between buffers */ > > void * memcpy (void *dest, const void *src, unsigned int count) > > { > > return CopyMem (dest, src, (UINTN)count); > > } > >+#endif > >-- > >2.7.4 > > > > > >