From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.9834.1592794211969311333 for ; Sun, 21 Jun 2020 19:50:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=LjR68mu8; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: guomin.jiang@intel.com) IronPort-SDR: tQgQZJPi0HgsPWWcpY6YsM7jqbVmVm4zj0GIH5StAvcfXGeAfYvdVoVJvW/w5Cz1c407yYZpj/ k1gpyamVDwAg== X-IronPort-AV: E=McAfee;i="6000,8403,9659"; a="161728962" X-IronPort-AV: E=Sophos;i="5.75,265,1589266800"; d="scan'208";a="161728962" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2020 19:50:11 -0700 IronPort-SDR: v86AQofvKtuRvsWxmHwgjUZgc82BTfkmEA86D/T29yZhzGDk8siwn+bqSGhzPm2IMkuCWe7nUP h/01l5+ffbEA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,265,1589266800"; d="scan'208";a="278437097" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 21 Jun 2020 19:50:10 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 21 Jun 2020 19:50:10 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 21 Jun 2020 19:50:10 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 21 Jun 2020 19:50:09 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 21 Jun 2020 19:50:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BTKzwgqdmzyH1a7XvaCN1n2w9U4jNLZx4yra9EFHXr95dhj1JiolJu4JvBnFoT8C4RXmMeI99prMlJBWo+PxKmwoB1gJ2OR2sM18fvkOwZil8TwX6QRU5cl4h5dspMqaiFy9G7e8+CA5En/cfXYoKjooPEFHv/7d5zApwc8Ekt+M85/rMSj2rDFgcyCwpAJPpDpVK3K3kkolgRkSf1d5uMwDxpUC0mb+cpAi0J0EGpNIUpJ00zYGBwehG1R1oJ7A9eEKgb9p4Yia93EA1F+rnmUVB9Oi9QUU6HbYgVk/ATfAE7hX26E2dwa9wTdnLS/0GberlCvacfZLcWhqlZvHMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1I6blxZScJvNgHyVjsc4feG3IYTb14nuIq8zBizW+RI=; b=cMVap4WQ7iR/vQaXPwYTyR/N7U0b7ktCyN+loXPQlPbM2s3I3swoIuwDSOPxMO9/mkkwMKeiZLV+gDduENlIaSIAUCYsMzFQCjpGnwLC0dlDkE9qVxvuSw9KqybFXfSVq+38MKG6QcvyTUXWSdISDUhgpbCP2O/otpPw3bzi2HkIbziydkoiqZoL8VRrJe711f0p6oQMXD9JjvEnsOlcpugswDdQTJ9Gfth5NYvKjzBJbnmqzo9TTUc9gxrKKladEx5ZbNoWdqgwm9rp9pKtECgLBwQ4ze8meZLIytRe9dnBfGAVrUfz7qvm1/TC++pCi6gRre0oYwDRc+Gcnbp4hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1I6blxZScJvNgHyVjsc4feG3IYTb14nuIq8zBizW+RI=; b=LjR68mu8Q7qY4OGuKKoZCt7zJp+b1D7YNGnItqecOPi1ssEPCyaK01W2bK8/KwFmmzUh/4N7NqPjqe/nAdkrQtK3JHXRORL+NcyVhIvvSAcjQ2iOXS5oYFGuuFJqbjHwm7sS/nQUIHlLHuiJkHjZ8rt0S33s7TmEkVASYg/y+L0= Received: from BL0PR11MB2946.namprd11.prod.outlook.com (2603:10b6:208:78::15) by MN2PR11MB4566.namprd11.prod.outlook.com (2603:10b6:208:24e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.23; Mon, 22 Jun 2020 02:50:07 +0000 Received: from BL0PR11MB2946.namprd11.prod.outlook.com ([fe80::b4df:a204:fb41:1ff3]) by BL0PR11MB2946.namprd11.prod.outlook.com ([fe80::b4df:a204:fb41:1ff3%4]) with mapi id 15.20.3109.023; Mon, 22 Jun 2020 02:50:07 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "garrett.kirkendall@amd.com" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v5 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass Thread-Topic: [edk2-devel] [PATCH v5 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass Thread-Index: AQHWRlqiiB/HCnVJoE6JIV7swonRiqjj7bhg Date: Mon, 22 Jun 2020 02:50:07 +0000 Message-ID: References: <20200619165629.9545-1-Garrett.Kirkendall@amd.com> <20200619165629.9545-2-Garrett.Kirkendall@amd.com> In-Reply-To: <20200619165629.9545-2-Garrett.Kirkendall@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.196] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 46dadc95-b071-43a6-7826-08d81656f907 x-ms-traffictypediagnostic: MN2PR11MB4566: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-forefront-prvs: 0442E569BC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lhlDSGuOb8zFRkYX3d4LnrS/oFQsD2e071L6UPteAMR2xiSYB1iWpirR8PN/ThaJyUMiSLNBFg1iXVp+XV+a/fD1KgGVR21g7x9ng8raQObi/h82FH0OFHBuHPucS1bsHsQKZt5W0NEPAKQwDwDLvVGxaAxoZ4jIMYnBjz4Xf75ErzdHkAGQP4+VgP5FMELgTl4lWSh6gvTnUl8AU5a9bQwaPQ29wjTzUr8nxz1U3kQ7HSJS+EjzuHM69zrBeBmuB81YUphhu1iXNqUF2aob1KwykuE0yLiQlGP8vC6pJLnd75732DtPM4hNMynSKe7Vv2T4aQkPspjvVufzXJpOWQGeekOOXWbOBW432FMbK/EjGuUWg8S0Be5g8JZ/quDeo4W9JCUUulsg9P8xJCV/fg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB2946.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(4636009)(376002)(346002)(39860400002)(396003)(136003)(366004)(71200400001)(9686003)(66946007)(26005)(66446008)(66476007)(186003)(64756008)(83380400001)(66556008)(7696005)(52536014)(5660300002)(4326008)(55016002)(110136005)(33656002)(86362001)(53546011)(966005)(8936002)(76116006)(6506007)(8676002)(2906002)(316002)(107886003)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: k2jQwtII8/vssV5Ar33qj9+z5vDqvBrzDbmBxBFAsI9WlNd3Bg0UzFsNm/ngPV697e+zDw4bGseUI6cBNtQaHkixLWW1DlWooZnDbwYwtonTHGAdsjv3q4v9qMxoBu0Eq9Iq0lJ5mm7n5YUG01m+M4atmyjP2QTRcoqKzhB1bA0ysz2jt+w9VcG5Xmx6s/gDtO9zkyLYBUXt2aGj6c5NxUjX/emr3eP1EWED8+dX+A7Bo4qIZ0C5qbtOtlsXh9C3edTmkwMpFZv2CTOQNeWQIe6PoSHeGO9kkf2jpvrOY4zgocFNMi+R2bj1ujlqjcQEw/39AdWO9p0Zr9wM4wyI/zQKSfaXG+zLNe2YwH2CaQnTG65CMYFy0KijguVtaQdg38ANQ+f94QFJF6vorIHr1G7I6kq33VTNdjQAZkIp5s52EcF0LcX3u+TocaQS7WWjm0fltlV51DDVChvx4ugIboaEJEkIlcBVJUdH+kBMLncifv8Kyl+ofDG4sFy1lwSi MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 46dadc95-b071-43a6-7826-08d81656f907 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2020 02:50:07.2360 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ST67zKHgq/8jRL5z1eH4qQDxmo0FYEKA7qLYqrT9hzaXJ4j33usIxRwhgHwu2KEmhHcvxC4setaau1kkX+d8kQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4566 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Garrett, I encounter below error when build UefiCpuPkg\Library\BaseUefiCpuLib\BaseUefiCpuLib.c: warning C4335: Mac fil= e format detected: please convert the source file to either DOS or UNIX for= mat' I encounter the issue ever, it result by mail encoding. To resolve this issue, you can run [BaseTools\ Scripts\SetupGit.py] first,= and then send the patch again. Could you try it and send the patch again? Best Regards Guomin > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Kirkendall, Garrett > Sent: Saturday, June 20, 2020 12:56 AM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [edk2-devel] [PATCH v5 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc > add UefiCpuLib LibraryClass >=20 > In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib > in UefiCpuPkg, PcAtChipset/PcAtChipsetPkg.dsc needs LibraryClass > UefiCpuLib. > LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need > UefiCpuLib LibraryClass. Likely most "real" platforms will be using > BaseX2XApicLib instance which already required UefiCpuLib. >=20 > Cc: Ray Ni > Signed-off-by: Garrett Kirkendall > --- > PcAtChipsetPkg/PcAtChipsetPkg.dsc | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dsc > b/PcAtChipsetPkg/PcAtChipsetPkg.dsc > index 01a3ee716a98..b61b7d1f528e 100644 > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dsc > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dsc > @@ -2,6 +2,7 @@ > # PC/AT Chipset Package > # > # Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved. > +# Copyright (c) 2020, AMD Incorporated. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -39,6 +40,7 @@ > [LibraryClasses] >=20 > ResetSystemLib|PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.in > f > IoApicLib|PcAtChipsetPkg/Library/BaseIoApicLib/BaseIoApicLib.inf > LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > + UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf >=20 > ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseR > eportStatusCodeLibNull.inf > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf >=20 > -- > 2.27.0 >=20 >=20 >=20