public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guomin Jiang" <guomin.jiang@intel.com>
To: Michael Kubacki <michael.kubacki@outlook.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Justen, Jordan L" <jordan.l.justen@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [edk2-wiki][PATCH v1 0/2] Add OVMF WinDbg Source Debug Page
Date: Fri, 31 Jul 2020 05:27:43 +0000	[thread overview]
Message-ID: <BL0PR11MB2946CD6835A981188E780EF59D4E0@BL0PR11MB2946.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR07MB3440E1FD143EBDABBF45F202E9710@MWHPR07MB3440.namprd07.prod.outlook.com>

I follow the step and test it, it work and thanks for your efforts.

Some suggestion:
1. Can we add the QEMU link and clarify the 32bit or 64bit version? For example, I use the https://qemu.weilnetz.de/w64/2020/qemu-w64-setup-20200201.exe
2. Can we add the PUTTY link so the new person can practice it directly.
2. It seem that you just send the wiki for review and it will merge into github.io wiki eventually, am I right?

Anyway, it's very good.
Tested-by: Guomin Jiang <guomin.jiang@intel.com>
Acked-by: Guomin Jiang <guomin.jiang@intel.com>

> -----Original Message-----
> From: Michael Kubacki <michael.kubacki@outlook.com>
> Sent: Thursday, July 30, 2020 8:09 AM
> To: Jiang, Guomin <guomin.jiang@intel.com>; devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek
> <lersek@redhat.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [edk2-wiki][PATCH v1 0/2] Add OVMF WinDbg
> Source Debug Page
> 
> For your convenience, you can find a rendered version of the markdown
> here:
> 
> https://github.com/makubacki/tianocore.github.io/blob/add_ovmf_windbg
> _instructions/How-to-debug-OVMF-with-QEMU-using-WinDbg.md
> 
> Thanks,
> Michael
> 
> On 7/29/2020 5:08 PM, Jiang, Guomin wrote:
> > Good Job!
> >
> > I will test it this week and update my test not late than next weekend.
> >
> > Best Regards
> > Guomin
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> >> Michael Kubacki
> >> Sent: Thursday, July 30, 2020 6:53 AM
> >> To: devel@edk2.groups.io
> >> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek
> >> <lersek@redhat.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>;
> Kinney,
> >> Michael D <michael.d.kinney@intel.com>
> >> Subject: [edk2-devel] [edk2-wiki][PATCH v1 0/2] Add OVMF WinDbg
> >> Source Debug Page
> >>
> >> From: Michael Kubacki <michael.kubacki@microsoft.com>
> >>
> >> This patch series provides basic information about setting up a
> >> source debug session using OvmfPkg with WinDbg and QEMU.
> >>
> >> Cc: Jordan Justen <jordan.l.justen@intel.com>
> >> Cc: Laszlo Ersek <lersek@redhat.com>
> >> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >>
> >> Michael Kubacki (2):
> >>    Add OVMF WinDbg source debug enabling instructions
> >>    Update OVMF FAQ to include WinDbg enabling instructions
> >>
> >>   How-to-debug-OVMF-with-QEMU-using-WinDbg.md                          | 161
> >> ++++++++++++++++++++
> >>   OVMF-FAQ.md                                                          |   5 +-
> >>   images/ovmf-qemu-windbg/intel_udk_installer_windbg_dialog.png
> |
> >> Bin 0 -> 48098 bytes
> >>   images/ovmf-qemu-
> >> windbg/unable_to_locate_windbg_error_dialog_box.png | Bin 0 -> 10852
> >> bytes
> >>   images/ovmf-qemu-windbg/windbg-example-locals.png                    | Bin 0
> ->
> >> 37876 bytes
> >>   images/ovmf-qemu-windbg/windbg-example-locals2.png                   | Bin
> 0 ->
> >> 17826 bytes
> >>   images/ovmf-qemu-windbg/windbg-example-multiple-panels.png
> |
> >> Bin 0 -> 320149 bytes
> >>   images/ovmf-qemu-
> >> windbg/windows_sdk_debugging_tools_8_1_install.png  | Bin 0 -> 45900
> >> bytes
> >>   8 files changed, 165 insertions(+), 1 deletion(-)  create mode
> >> 100644 How-to- debug-OVMF-with-QEMU-using-WinDbg.md
> >>   create mode 100644 images/ovmf-qemu-
> >> windbg/intel_udk_installer_windbg_dialog.png
> >>   create mode 100644 images/ovmf-qemu-
> >> windbg/unable_to_locate_windbg_error_dialog_box.png
> >>   create mode 100644 images/ovmf-qemu-windbg/windbg-example-
> >> locals.png
> >>   create mode 100644 images/ovmf-qemu-windbg/windbg-example-
> >> locals2.png
> >>   create mode 100644 images/ovmf-qemu-windbg/windbg-example-
> multiple-
> >> panels.png
> >>   create mode 100644 images/ovmf-qemu-
> >> windbg/windows_sdk_debugging_tools_8_1_install.png
> >>
> >> --
> >> 2.27.0.windows.1
> >>
> >>
> >> 
> >

  reply	other threads:[~2020-07-31  5:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 22:52 [edk2-wiki][PATCH v1 0/2] Add OVMF WinDbg Source Debug Page Michael Kubacki
2020-07-30  0:08 ` [edk2-devel] " Guomin Jiang
2020-07-30  0:09   ` Michael Kubacki
2020-07-31  5:27     ` Guomin Jiang [this message]
2020-07-31  0:00 ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL0PR11MB2946CD6835A981188E780EF59D4E0@BL0PR11MB2946.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox