From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: 'Sean Brogan' <sean.brogan@microsoft.com>,
'Bret Barkelew' <Bret.Barkelew@microsoft.com>,
'Andrew Fish' <afish@apple.com>,
"'Laszlo Ersek'" <lersek@redhat.com>,
'Leif Lindholm' <leif@nuviainc.com>,
"Wang, Nickle (HPS SW)" <nickle.wang@hpe.com>,
"O'Hanley, Peter (EXL)" <peter.ohanley@hpe.com>
Subject: Re: [edk2-devel] [PATCH v5 0/6] jansson edk2 port
Date: Thu, 10 Dec 2020 02:33:21 +0000 [thread overview]
Message-ID: <BL0PR11MB323623A97340D80726B8E5B7D2CB0@BL0PR11MB3236.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CS1PR8401MB1144808D574AEDD0FBDB8282FFCB0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM>
Abner,
Some questions included below.
Mike
> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Sent: Wednesday, December 9, 2020 6:14 PM
> To: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Andrew Fish'
> <afish@apple.com>; 'Laszlo Ersek' <lersek@redhat.com>; 'Leif Lindholm' <leif@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> Subject: RE: [edk2-devel] [PATCH v5 0/6] jansson edk2 port
>
>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > gaoliming
> > Sent: Tuesday, December 8, 2020 2:40 PM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> > <Bret.Barkelew@microsoft.com>; 'Andrew Fish' <afish@apple.com>; 'Laszlo
> > Ersek' <lersek@redhat.com>; 'Leif Lindholm' <leif@nuviainc.com>; 'Michael
> > D Kinney' <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> > <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> > Subject: 回复: [edk2-devel] [PATCH v5 0/6] jansson edk2 port
> >
> > Abner:
> > I have minor comments on the library header file.
> >
> > 1. JasonLib.h & BaseUcs2Utf8Lib.h. They don't need to include the additional
> > header files, such as Uefi.h and BaseLib.h, because the library header file
> > doesn't depend on the definitions from BaseLib.
> > 2. CrtLib.inf needs to list the required library class: BaseMemoryLib & PrintLib.
>
> OK, I will wait couple days for other comments and address that all together.
>
> Thanks
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: bounce+27952+68426+4905953+8761045@groups.io
> > > <bounce+27952+68426+4905953+8761045@groups.io> 代表 Abner Chang
> > > 发送时间: 2020年12月8日 10:11
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew@microsoft.com>; Andrew Fish <afish@apple.com>; Laszlo
> > > Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Michael
> > > D Kinney <michael.d.kinney@intel.com>; Liming Gao
> > > <gaoliming@byosoft.com.cn>; Nickle Wang <nickle.wang@hpe.com>;
> > Peter
> > > O'Hanley <peter.ohanley@hpe.com>
> > > 主题: [edk2-devel] [PATCH v5 0/6] jansson edk2 port
> > >
> > > In v5, move BaseUcs2Utf8Lib to under RedfishPkg.
> > > In v4,
> > > - Address review comments
> > > - Seperate CRT functions to a individule library CrtLib under
> > > RedfishPkg.
> > > - Seperate UCS2-UTF8 functions to a individule library
> > > BaseUcs2Utf8Lib under MdeModulePkg.
> > >
> > > In v3, Add jansson library as the required submoudle in
> > > CiSettings.py for CI test.
> > > In v2, JsonLib is moved to under RedfishPkg.
> > >
> > > edk2 JSON library is based on jansson open source
> > > (https://github.com/akheron/jansson) and wrapped as an edk2 library.
> > > edk2 JsonLib will be used by edk2 Redfish feature drivers (not
> > > contributed yet) and the edk2 port of libredfish library (not
> > > contributed yet) based on DMTF GitHub
> > > (https://github.com/DMTF/libredfish).
> > >
> > > Jansson is licensed under the MIT license(refer to ReadMe.rst under edk2).
> > > It is used in production and its API is stable. In UEFI/EDKII
> > > environment, Redfish project consumes jansson to achieve JSON
> > operations.
> > >
> > > * Jansson version on edk2: 2.13.1
> > >
> > > * EDKII jansson library wrapper:
> > > - JsonLib.h:
> > > This is the denifitions of EDKII JSON APIs which are mapped to
> > > jannson funcitons accordingly.
> > >
> > > - JanssonJsonLibMapping.h:
> > > This is the wrapper file to map funcitons and definitions used in
> > > native jannson applications to edk2 JsonLib. This avoids the
> > > modifications on native jannson applications to be built under
> > > edk2 environment.
Can you explain the use case for this in more detail?
What are these native jannson applications and why do we need to build them in edk2?
If we have the jannson submodule, why can't these apps just use the standard jannson services?
I ask because this is a new concept for edk2 and I want to make sure it is really required.
> > >
> > > *Known issue:
> > > Build fail with jansson/src/load.c, overrride and add code in load.c
> > > to conditionally use stdin according to HAVE_UNISTD_H macro.
> > > The PR is submitted to jansson open source community.
> > > https://github.com/akheron/jansson/pull/558
> > >
> > > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > >
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > Cc: Andrew Fish <afish@apple.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Nickle Wang <nickle.wang@hpe.com>
> > > Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> > >
> > > Abner Chang (6):
> > > RedfishPkg/Ucs2Utf8lib: UCS2 to UFT8 manipulation library
> > > edk2: jansson submodule for edk2 JSON library
> > > RedfishPkg/CrtLib: C runtime library
> > > RedfishPkg/library: EDK2 port of jansson library
> > > RedfishPkg: Add EDK2 port of jansson library to build
> > > .pytool: Add required submodule for JsonLib
> > >
> > > .gitmodules | 3 +
> > > .pytool/CISettings.py | 2 +
> > > ReadMe.rst | 1 +
> > > RedfishPkg/Include/JanssonJsonMapping.h | 63 +
> > > RedfishPkg/Include/Library/BaseUcs2Utf8Lib.h | 69 +
> > > RedfishPkg/Include/Library/CrtLib.h | 195 +++
> > > RedfishPkg/Include/Library/JsonLib.h | 768 ++++++++++++
> > > .../Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.c | 417 +++++++
> > > .../BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf | 31 +
> > > RedfishPkg/Library/CrtLib/CrtLib.c | 705 +++++++++++
> > > RedfishPkg/Library/CrtLib/CrtLib.inf | 37 +
> > > RedfishPkg/Library/JsonLib/JsonLib.c | 961 ++++++++++++++
> > > RedfishPkg/Library/JsonLib/JsonLib.inf | 101 ++
> > > RedfishPkg/Library/JsonLib/Readme.rst | 40 +
> > > RedfishPkg/Library/JsonLib/assert.h | 16 +
> > > RedfishPkg/Library/JsonLib/errno.h | 16 +
> > > RedfishPkg/Library/JsonLib/jansson | 1 +
> > > RedfishPkg/Library/JsonLib/jansson_config.h | 46 +
> > > .../Library/JsonLib/jansson_private_config.h | 19 +
> > > RedfishPkg/Library/JsonLib/limits.h | 16 +
> > > RedfishPkg/Library/JsonLib/load.c | 1111
> > > +++++++++++++++++
> > > RedfishPkg/Library/JsonLib/math.h | 16 +
> > > RedfishPkg/Library/JsonLib/stdarg.h | 15 +
> > > RedfishPkg/Library/JsonLib/stddef.h | 16 +
> > > RedfishPkg/Library/JsonLib/stdio.h | 15 +
> > > RedfishPkg/Library/JsonLib/stdlib.h | 16 +
> > > RedfishPkg/Library/JsonLib/string.h | 16 +
> > > RedfishPkg/Library/JsonLib/sys/time.h | 15 +
> > > RedfishPkg/Library/JsonLib/sys/types.h | 15 +
> > > RedfishPkg/Library/JsonLib/time.h | 15 +
> > > RedfishPkg/RedfishLibs.dsc.inc | 3 +
> > > RedfishPkg/RedfishPkg.ci.yaml | 33 +
> > > RedfishPkg/RedfishPkg.dec | 15 +
> > > RedfishPkg/RedfishPkg.dsc | 3 +
> > > 34 files changed, 4811 insertions(+)
> > > create mode 100644 RedfishPkg/Include/JanssonJsonMapping.h
> > > create mode 100644 RedfishPkg/Include/Library/BaseUcs2Utf8Lib.h
> > > create mode 100644 RedfishPkg/Include/Library/CrtLib.h
> > > create mode 100644 RedfishPkg/Include/Library/JsonLib.h
> > > create mode 100644
> > > RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.c
> > > create mode 100644
> > > RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> > > create mode 100644 RedfishPkg/Library/CrtLib/CrtLib.c
> > > create mode 100644 RedfishPkg/Library/CrtLib/CrtLib.inf
> > > create mode 100644 RedfishPkg/Library/JsonLib/JsonLib.c
> > > create mode 100644 RedfishPkg/Library/JsonLib/JsonLib.inf
> > > create mode 100644 RedfishPkg/Library/JsonLib/Readme.rst
> > > create mode 100644 RedfishPkg/Library/JsonLib/assert.h
> > > create mode 100644 RedfishPkg/Library/JsonLib/errno.h
> > > create mode 160000 RedfishPkg/Library/JsonLib/jansson
> > > create mode 100644 RedfishPkg/Library/JsonLib/jansson_config.h
> > > create mode 100644
> > > RedfishPkg/Library/JsonLib/jansson_private_config.h
> > > create mode 100644 RedfishPkg/Library/JsonLib/limits.h
> > > create mode 100644 RedfishPkg/Library/JsonLib/load.c create mode
> > > 100644 RedfishPkg/Library/JsonLib/math.h create mode 100644
> > > RedfishPkg/Library/JsonLib/stdarg.h
> > > create mode 100644 RedfishPkg/Library/JsonLib/stddef.h
> > > create mode 100644 RedfishPkg/Library/JsonLib/stdio.h
> > > create mode 100644 RedfishPkg/Library/JsonLib/stdlib.h
> > > create mode 100644 RedfishPkg/Library/JsonLib/string.h
> > > create mode 100644 RedfishPkg/Library/JsonLib/sys/time.h
> > > create mode 100644 RedfishPkg/Library/JsonLib/sys/types.h
> > > create mode 100644 RedfishPkg/Library/JsonLib/time.h
> > >
> > > --
> > > 2.17.1
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> >
> >
>
next prev parent reply other threads:[~2020-12-10 2:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 2:10 [PATCH v5 0/6] jansson edk2 port Abner Chang
2020-12-08 2:10 ` [PATCH v5 1/6] RedfishPkg/Ucs2Utf8lib: UCS2 to UFT8 manipulation library Abner Chang
2020-12-10 2:48 ` Nickle Wang
2020-12-10 13:49 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-12-10 14:27 ` Abner Chang
2020-12-10 16:43 ` Samer El-Haj-Mahmoud
2020-12-11 0:37 ` Abner Chang
2020-12-08 2:10 ` [PATCH v5 2/6] edk2: jansson submodule for edk2 JSON library Abner Chang
2020-12-10 2:50 ` Nickle Wang
2020-12-08 2:10 ` [PATCH v5 3/6] RedfishPkg/CrtLib: C runtime library Abner Chang
2020-12-10 2:54 ` Nickle Wang
2020-12-08 2:10 ` [PATCH v5 4/6] RedfishPkg/library: EDK2 port of jansson library Abner Chang
2020-12-10 2:58 ` Nickle Wang
2020-12-08 2:10 ` [PATCH v5 5/6] RedfishPkg: Add EDK2 port of jansson library to build Abner Chang
2020-12-10 2:59 ` Nickle Wang
2020-12-08 2:10 ` [PATCH v5 6/6] .pytool: Add required submodule for JsonLib Abner Chang
2020-12-08 6:39 ` 回复: [edk2-devel] [PATCH v5 0/6] jansson edk2 port gaoliming
2020-12-10 2:13 ` Abner Chang
2020-12-10 2:33 ` Michael D Kinney [this message]
2020-12-10 4:02 ` Abner Chang
2020-12-11 19:22 ` Michael D Kinney
2020-12-13 4:01 ` Abner Chang
2020-12-14 1:29 ` 回复: " gaoliming
2020-12-14 1:58 ` Abner Chang
2020-12-16 2:08 ` Abner Chang
2020-12-16 2:57 ` Michael D Kinney
2020-12-16 15:04 ` Abner Chang
2020-12-14 16:10 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB323623A97340D80726B8E5B7D2CB0@BL0PR11MB3236.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox