Re: EDK II CI Status - Failed

["Michael D Kinney" <michael.d.kinney@intel.com>]

Hi Zhichao,

I have a proposed fix here that passed unit tests using local CI.

    https://github.com/mdkinney/edk2/commit/9fc657752337c1e2acb3bed9ecd4561611aeb03f

I am running it through EDK II CI with the other 3 patches to see if
everything passes.

    https://github.com/tianocore/edk2/pull/1144

Mike

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Tuesday, November 24, 2020 8:15 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: EDK II CI Status - Failed
> 
> Zhichao,
> 
> I can reproduce the CI failure when I setup a python venv and run the following
> sequence of commands:
> 
>     stuart_setup -c .pytool/CISettings.py TOOL_CHAIN_TAG=VS2019
> 
>     stuart_update -c .pytool/CISettings.py TOOL_CHAIN_TAG=VS2019
> 
>     stuart_ci_build -c .pytool/CISettings.py TOOL_CHAIN_TAG=VS2019 -p CryptoPkg -a X64 -t NOOPT
> 
> The last one only runs the NOOPT target for X64 for the CryptoPkg that limits the checks
> to the unit tests.
> 
> Mike
> 
> > -----Original Message-----
> > From: Gao, Zhichao <zhichao.gao@intel.com>
> > Sent: Tuesday, November 24, 2020 1:05 AM
> > To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: RE: EDK II CI Status - Failed
> >
> > I have tested on my local. The new build options is required for " CryptoPkg\TestC\CryptoPkgHostUnitTest.dsc"
> > But I still get other failure:
> > One is:
> > ERROR -
> > ERROR - EFI coding style error
> > ERROR - *Error code: 8003
> > ERROR - *The #ifndef at the start of an include file should use both prefix and postfix underscore characters, '_'
> > ERROR - *file: D:\Code\Edk2\trunk\edk2\CryptoPkg\Include\Library\BaseCryptLib.h
> > ERROR - *Line number: 75
> > ERROR - *The #ifndef name [DISABLE_MD5_DEPRECATED_INTERFACES] does not follow the rules
> > ERROR -
> > ERROR -
> > ERROR -
> > ERROR - --->Test Failed: EccCheck Test NO-TARGET returned 1
> >
> > The other is:
> > ERROR - Linker #2005 from BaseCryptLib.lib(UnitTestHostCrtWrapper.obj) :   tolower already defined in
> > libucrtd.lib(tolower_toupper.obj)
> > ERROR - Linker #1169 from d:\code\edk2\trunk\edk2\Build\CryptoPkg\HostTest\NOOPT_VS2017\X64\BaseCryptLibUnitTestHost.exe
> :
> > fatal   one or more multiply defined symbols found
> > ERROR - Compiler #1077 from NMAKE : fatal   '"C:\Program Files (x86)\Microsoft Visual
> > Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\Hostx86\x64\link.exe"' : return code '0x491'
> > ERROR - Compiler #7000 from :   Failed to execute command
> > ERROR - EDK2 #002 from :   Failed to build module
> >
> > Thanks,
> > Zhichao
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D
> > > Kinney
> > > Sent: Tuesday, November 24, 2020 9:20 AM
> > > To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> > > Subject: [edk2-devel] EDK II CI Status - Failed
> > >
> > > Hello,
> > >
> > > The current EDK II CI status for post commit checks is currently showing failed.
> > >
> > > 	https://github.com/tianocore/edk2#core-ci-build-status
> > >
> > > Please hold off on PRs with a 'push' label until this is resolved.
> > >
> > > Early analysis shows this may be a cascade of 2 issues.  One related to the CI
> > > step that evaluates what checks are run based on the files changed, and a
> > > second one related to the commit that disabled MD5 services that is causing
> > > some MD5 unit tests to fail.
> > >
> > > We are investigating and will keep everyone updated on status.
> > >
> > > Thanks,
> > >
> > > Mike
> > >
> > >
> > > 
> > >