Re: [edk2-CCodingStandardsSpecification PATCH 1/1] Update the Name Space Rules page examples to follow the coding standard

["Michael D Kinney" <michael.d.kinney@intel.com>]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Sunday, December 6, 2020 6:25 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm
> <leif@nuviainc.com>; Laszlo Ersek <lersek@redhat.com>; Andrew Fish <afish@apple.com>
> Subject: [edk2-CCodingStandardsSpecification PATCH 1/1] Update the Name Space Rules page examples to follow the coding
> standard
> 
> The examples in the 45_name_space_rules.md files doesn't follow the
> coding standard in the following ways:
> 
> - Only use UEFI data types. Use of standard C data types is prohibited.
> - Identifiers shall contain mixed upper- and lower-case text.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> ---
>  4_naming_conventions/45_name_space_rules.md | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/4_naming_conventions/45_name_space_rules.md b/4_naming_conventions/45_name_space_rules.md
> index 1234250756cc..ecdebbe28339 100644
> --- a/4_naming_conventions/45_name_space_rules.md
> +++ b/4_naming_conventions/45_name_space_rules.md
> @@ -53,9 +53,9 @@ tags may be reused only for union types.
> 
>  ```c
>  typedef struct MyStruct {
> -  int  one;
> -  int  two;
> -  int  three;
> +  UINT32  One;
> +  UINT32  Two;
> +  UINT32  Three;
>  } MY_STRUCT;
>  ```
> 
> @@ -68,14 +68,14 @@ Exceptions are structure member and union member names.
> 
>  ```c
>  typedef struct StructOne {
> -  INT32             one;
> -  INT16             two;
> +  INT32             One;
> +  INT16             Two;
>    struct StructOne  *MySelf;
>  } STRUCT_ONE;
> 
>  typedef struct StructTwo {
> -  INT16             one;
> -  INT8              *two;
> +  INT16             One;
> +  INT8              *Two;
>    struct StructTwo  *MySelf;
>  } STRUCT_TWO;
> 
> --
> 2.26.2