public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "rfc@edk2.groups.io" <rfc@edk2.groups.io>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	'Bret Barkelew' <Bret.Barkelew@microsoft.com>,
	"Laszlo Ersek <lersek@redhat.com> (lersek@redhat.com)"
	<lersek@redhat.com>, "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [RFC] UnitTestFrameworkPkg cmocka submodule alternatives
Date: Sat, 19 Dec 2020 18:58:52 +0000	[thread overview]
Message-ID: <BL0PR11MB32369F11D4CE1EA929DBF69CD2C20@BL0PR11MB3236.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BL0PR11MB323609CCD293B8B11C3FE8B2D2C50@BL0PR11MB3236.namprd11.prod.outlook.com>

Hello,

There have been a few suggestions to create a mirror of cmocka in TianoCore
org in GitHub.

I have found a GitHub action that can do a repo sync.

    https://github.com/marketplace/actions/github-repo-sync

I have created a temporary mirror of cmocka in my personal GitHub area that
uses this GitHub action to sync all branches and all tags once a day.

    https://github.com/mdkinney/mirror-cmocka

Here is the GitHub workflow file.  It must be in the default branch for the
repo using a branch name that is not present in the repo being mirrored.
In this case, I used a branch name of 'repo-sync'.

    https://github.com/mdkinney/mirror-cmocka/blob/repo-sync/.github/workflows/repo-sync.yml

Please provide feedback on this approach.  If we like this approach, then
I suggest we create a new repo in TianoCore called edk2-cmocka that is a 
mirror that is synced once a day and we update the cmocka submodule in the
edk2 repo to use edk2-cmocka.

Best regards,

Mike

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, December 16, 2020 10:46 AM
> To: rfc@edk2.groups.io; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>
> Subject: [RFC] UnitTestFrameworkPkg cmocka submodule alternatives
> 
> Hello,
> 
> We have had at least three incidents in the last year where the link to the
> cmocka submodule in the UnitTestFrameworkPkg has not been available, and this
> impacted the EDK II CI system.  The following submodule link is the one that
> is not reliable:
> 
> 	https://git.cryptomilk.org/projects/cmocka.git
> 
> We have identified two potential mirrors of this repo:
> 
> 	https://github.com/neverware-mirrors/cmocka.git
> 	https://gitlab.com/cmocka/cmocka.git
> 
> The following patch provided a temporary fix for the EDK II CI agents, but
> does not help other consumers of the edk2 repository.
> 
> 	https://github.com/tianocore/edk2/commit/be746104d1766a8c363e74d6063144657820d688
> 
> I have seen one suggestion that TianoCore create its own
> mirror of cmocka.  This does require monitoring and maintenance
> by the  TianoCore community.  I would prefer to use a well
> maintained mirror in github as long as we do not observe any
> issues with the support of that mirror.
> 
> I propose we update the submodule in the UnitTestFrameworkPkg
> to use the https://github.com/neverware-mirrors/cmocka.git mirror.
> By using a mirror in github, we remove one external dependency.
> 
> Please provide feedback and comments on this proposal.  If there
> are no objections, then we will proceed with a patch review for
> this update.
> 
> Thanks,
> 
> Mike

  parent reply	other threads:[~2020-12-19 18:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 18:45 [RFC] UnitTestFrameworkPkg cmocka submodule alternatives Michael D Kinney
2020-12-17  0:58 ` 回复: [edk2-devel] " gaoliming
2020-12-17 14:48 ` [edk2-rfc] " Laszlo Ersek
2020-12-17 15:54   ` Laszlo Ersek
2020-12-17 16:01     ` Rebecca Cran
2020-12-17 18:44       ` [EXTERNAL] " Bret Barkelew
2020-12-19 18:58 ` Michael D Kinney [this message]
2020-12-19 19:07   ` Bret Barkelew
2020-12-20  1:06   ` [edk2-rfc] " Rebecca Cran
2020-12-21  1:18     ` 回复: [edk2-devel] " gaoliming
2020-12-21 20:14       ` Michael D Kinney
2020-12-21 20:42         ` Rebecca Cran
     [not found]         ` <1652D609A7BB8C97.24251@groups.io>
2020-12-21 20:44           ` Rebecca Cran
2020-12-22  0:41             ` 回复: " gaoliming
2021-02-15  0:43   ` [edk2-devel] " Rebecca Cran
2021-04-06 20:22     ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL0PR11MB32369F11D4CE1EA929DBF69CD2C20@BL0PR11MB3236.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox