From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Abner Chang <abner.chang@hpe.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
Andrew Fish <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
Leif Lindholm <leif@nuviainc.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Nickle Wang <nickle.wang@hpe.com>,
Peter O'Hanley <peter.ohanley@hpe.com>
Subject: Re: [PATCH v13 0/6] jansson edk2 port
Date: Fri, 8 Jan 2021 19:33:54 +0000 [thread overview]
Message-ID: <BL0PR11MB3236DB63E98E2743ED065CACD2AE0@BL0PR11MB3236.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210108063713.8853-1-abner.chang@hpe.com>
Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: Abner Chang <abner.chang@hpe.com>
> Sent: Thursday, January 7, 2021 10:37 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Andrew Fish <afish@apple.com>;
> Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Liming Gao <gaoliming@byosoft.com.cn>; Nickle Wang <nickle.wang@hpe.com>; Peter O'Hanley <peter.ohanley@hpe.com>
> Subject: [PATCH v13 0/6] jansson edk2 port
>
> In v13, - Replace %s with %a and handle "%[flags][width][.precision][length]s"
> string formating.
> Tested with "%.4s", "%-20s", "%+20s", "%.*s", "%#s" and
> "%a%.3a%.3s".
> In v12, - Convert Ascii(V)SPrint format string to ASCII format.
> In v11, - Move RedfishCrtLib to under /PrivateLibrary
> - Optimize /wdxxxx build options for IA32/X64
> In v10, - Rename CrtLib to RedfishCrtLib
> - Review JsonLib /wd build options for Visual Studio.
> In v9, - Address comments given by Mike Kinney on 12/21
> In v8, - Assigne patch file order
> - Add Acked-by tags
> In v7, - Remove C RTC header files to under [Include.Common.Private]
> in RedfishPkg.dec.
> - address comments given by Mike Kinney.
> In v6, Remove JanssonJsonMapping.h
> In v5, move BaseUcs2Utf8Lib to under RedfishPkg.
> In v4,
> - Address review comments
> - Seperate CRT functions to a individule library CrtLib under
> RedfishPkg.
> - Seperate UCS2-UTF8 functions to a individule library
> BaseUcs2Utf8Lib under MdeModulePkg.
>
> In v3, Add jansson library as the required submoudle in
> CiSettings.py for CI test.
> In v2, JsonLib is moved to under RedfishPkg.
>
> edk2 JSON library is based on jansson open source
> (https://github.com/akheron/jansson) and wrapped as an edk2
> library. edk2 JsonLib will be used by edk2 Redfish feature
> drivers (not contributed yet) and the edk2 port of libredfish
> library (not contributed yet) based on DMTF GitHub
> (https://github.com/DMTF/libredfish).
>
> Jansson is licensed under the MIT license(refer to ReadMe.rst under edk2).
> It is used in production and its API is stable. In UEFI/EDKII environment,
> Redfish project consumes jansson to achieve JSON operations.
>
> * Jansson version on edk2: 2.13.1
>
> * EDKII jansson library wrapper:
> - JsonLib.h:
> This is the denifitions of EDKII JSON APIs which are mapped to
> jannson funcitons accordingly.
>
> - JanssonJsonLibMapping.h:
> This is the wrapper file to map funcitons and definitions used in
> native jannson applications to edk2 JsonLib. This avoids the
> modifications on native jannson applications to be built under
> edk2 environment.
>
> *Known issue:
> Build fail with jansson/src/load.c, overrride and add code in load.c
> to conditionally use stdin according to HAVE_UNISTD_H macro.
> The PR is submitted to jansson open source community.
> https://github.com/akheron/jansson/pull/558
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Peter O'Hanley <peter.ohanley@hpe.com>
>
> Abner Chang (6):
> RedfishPkg/Ucs2Utf8lib: UCS2 to UFT8 manipulation library
> edk2: jansson submodule for edk2 JSON library
> RedfishPkg/CrtLib: C runtime library
> RedfishPkg/library: EDK2 port of jansson library
> RedfishPkg: Add EDK2 port of jansson library to build
> .pytool: Add required submodule for JsonLib
>
> .gitmodules | 3 +
> .pytool/CISettings.py | 2 +
> ReadMe.rst | 1 +
> RedfishPkg/Include/Crt/assert.h | 16 +
> RedfishPkg/Include/Crt/errno.h | 16 +
> RedfishPkg/Include/Crt/limits.h | 16 +
> RedfishPkg/Include/Crt/math.h | 16 +
> RedfishPkg/Include/Crt/stdarg.h | 15 +
> RedfishPkg/Include/Crt/stddef.h | 16 +
> RedfishPkg/Include/Crt/stdio.h | 15 +
> RedfishPkg/Include/Crt/stdlib.h | 16 +
> RedfishPkg/Include/Crt/string.h | 16 +
> RedfishPkg/Include/Crt/sys/time.h | 15 +
> RedfishPkg/Include/Crt/sys/types.h | 15 +
> RedfishPkg/Include/Crt/time.h | 15 +
> RedfishPkg/Include/Library/BaseUcs2Utf8Lib.h | 61 +
> RedfishPkg/Include/Library/CrtLib.h | 191 +++
> RedfishPkg/Include/Library/JsonLib.h | 763 +++++++++++
> .../Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.c | 421 +++++++
> .../BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf | 31 +
> RedfishPkg/Library/CrtLib/CrtLib.c | 595 +++++++++
> RedfishPkg/Library/CrtLib/CrtLib.inf | 38 +
> RedfishPkg/Library/JsonLib/JsonLib.c | 964 ++++++++++++++
> RedfishPkg/Library/JsonLib/JsonLib.inf | 89 ++
> RedfishPkg/Library/JsonLib/Readme.rst | 40 +
> RedfishPkg/Library/JsonLib/jansson | 1 +
> RedfishPkg/Library/JsonLib/jansson_config.h | 41 +
> .../Library/JsonLib/jansson_private_config.h | 19 +
> RedfishPkg/Library/JsonLib/load.c | 1111 +++++++++++++++++
> RedfishPkg/RedfishLibs.dsc.inc | 3 +
> RedfishPkg/RedfishPkg.ci.yaml | 25 +
> RedfishPkg/RedfishPkg.dec | 25 +
> RedfishPkg/RedfishPkg.dsc | 3 +
> 33 files changed, 4614 insertions(+)
> create mode 100644 RedfishPkg/Include/Crt/assert.h
> create mode 100644 RedfishPkg/Include/Crt/errno.h
> create mode 100644 RedfishPkg/Include/Crt/limits.h
> create mode 100644 RedfishPkg/Include/Crt/math.h
> create mode 100644 RedfishPkg/Include/Crt/stdarg.h
> create mode 100644 RedfishPkg/Include/Crt/stddef.h
> create mode 100644 RedfishPkg/Include/Crt/stdio.h
> create mode 100644 RedfishPkg/Include/Crt/stdlib.h
> create mode 100644 RedfishPkg/Include/Crt/string.h
> create mode 100644 RedfishPkg/Include/Crt/sys/time.h
> create mode 100644 RedfishPkg/Include/Crt/sys/types.h
> create mode 100644 RedfishPkg/Include/Crt/time.h
> create mode 100644 RedfishPkg/Include/Library/BaseUcs2Utf8Lib.h
> create mode 100644 RedfishPkg/Include/Library/CrtLib.h
> create mode 100644 RedfishPkg/Include/Library/JsonLib.h
> create mode 100644 RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.c
> create mode 100644 RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> create mode 100644 RedfishPkg/Library/CrtLib/CrtLib.c
> create mode 100644 RedfishPkg/Library/CrtLib/CrtLib.inf
> create mode 100644 RedfishPkg/Library/JsonLib/JsonLib.c
> create mode 100644 RedfishPkg/Library/JsonLib/JsonLib.inf
> create mode 100644 RedfishPkg/Library/JsonLib/Readme.rst
> create mode 160000 RedfishPkg/Library/JsonLib/jansson
> create mode 100644 RedfishPkg/Library/JsonLib/jansson_config.h
> create mode 100644 RedfishPkg/Library/JsonLib/jansson_private_config.h
> create mode 100644 RedfishPkg/Library/JsonLib/load.c
>
> --
> 2.17.1
prev parent reply other threads:[~2021-01-08 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 6:37 [PATCH v13 0/6] jansson edk2 port Abner Chang
2021-01-08 6:37 ` [PATCH v13 1/6] RedfishPkg/Ucs2Utf8lib: UCS2 to UFT8 manipulation library Abner Chang
2021-01-08 6:37 ` [PATCH v13 2/6] edk2: jansson submodule for edk2 JSON library Abner Chang
2021-01-08 6:37 ` [PATCH v13 3/6] RedfishPkg/RedfishCrtLib: Redfish C runtime library Abner Chang
2021-01-08 6:37 ` [PATCH v13 4/6] RedfishPkg/library: EDK2 port of jansson library Abner Chang
2021-01-08 6:37 ` [PATCH v13 5/6] RedfishPkg: Add EDK2 port of jansson library to build Abner Chang
2021-01-08 6:37 ` [PATCH v13 6/6] .pytool: Add required submodule for JsonLib Abner Chang
2021-01-08 19:33 ` Michael D Kinney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB3236DB63E98E2743ED065CACD2AE0@BL0PR11MB3236.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox