From: "yi1 li" <yi1.li@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"kraxel@redhat.com" <kraxel@redhat.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/3] CryptoPkg: Update process_files.pl to automatically add PCD config option
Date: Mon, 9 May 2022 09:58:59 +0000 [thread overview]
Message-ID: <BL0PR11MB339668A52C08BA027592E1B6C5C69@BL0PR11MB3396.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220509093402.uxt5s3bmzvtcg7zb@sirius.home.kraxel.org>
Sounds good, I like this idea which make openssl generated part and edk2 conditional part more clear.
Thank you,
Yi
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd Hoffmann
Sent: Monday, May 9, 2022 5:34 PM
To: Li, Yi1 <yi1.li@intel.com>
Cc: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/3] CryptoPkg: Update process_files.pl to automatically add PCD config option
Hi,
> +#
> +# Add conditional feature to opensslconf.h #
I'd suggest to write the opensslconf.h created by openssl unmodified to opensslconf-generated.h, then have a opensslconf.h like this:
#include <Library/PcdLib.h>
#include "opensslconf-generated.h"
#if !FixedPcdGetBool(PcdEcEnable)
# define OPENSSL_NO_EC
# [ ... ]
#endif
take care,
Gerd
next prev parent reply other threads:[~2022-05-09 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1652066029.git.yi1.li@intel.com>
2022-05-09 3:19 ` [PATCH 1/3] CryptoPkg: Update process_files.pl to automatically add PCD config option yi1 li
2022-05-09 3:23 ` Yao, Jiewen
2022-05-09 9:34 ` Gerd Hoffmann
2022-05-09 9:58 ` yi1 li [this message]
2022-05-09 3:19 ` [PATCH 2/3] CryptoPkg/openssl: disable codestyle checks for generated files yi1 li
2022-05-09 3:23 ` Yao, Jiewen
2022-05-09 3:19 ` [PATCH 3/3] CryptoPkg/openssl: update " yi1 li
2022-05-09 3:25 ` Yao, Jiewen
2022-05-09 3:34 ` yi1 li
2022-05-09 9:38 ` Gerd Hoffmann
2022-05-09 10:05 ` [edk2-devel] " yi1 li
2022-05-09 10:26 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB339668A52C08BA027592E1B6C5C69@BL0PR11MB3396.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox