Re: [edk2-devel] [PATCH 3/3] CryptoPkg/openssl: update generated files

["yi1 li" <yi1.li@intel.com>]

Yes it does come from running the generated files though uncrustify once last year when uncrustify was introduced:
https://github.com/tianocore/edk2/commit/7c342378317039e632d9a1a5d4cf7c21aec8cb7a
I can remove those change next patch to avoid confusion.

Thank you,
Yi 



-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd Hoffmann
Sent: Monday, May 9, 2022 5:38 PM
To: Yao, Jiewen <jiewen.yao@intel.com>
Cc: Li, Yi1 <yi1.li@intel.com>; devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH 3/3] CryptoPkg/openssl: update generated files

On Mon, May 09, 2022 at 03:25:24AM +0000, Yao, Jiewen wrote:
> Thanks for the update.
> 
>  think some changes are unnecessary.
> 
> > -#define OSSL_CRYPTO_DSO_CONF_H
> > -#define DSO_NONE
> > -#define DSO_EXTENSION  ".so"
> > +# define OSSL_CRYPTO_DSO_CONF_H
> > +# define DSO_NONE
> > +# define DSO_EXTENSION ".so"
> 
> Why you add a space ' ' ?
> 
> Can we make it unchanged? 

Not sure where this comes from, either it's a upstream openssl change, or it comes from running the generated files though uncrustify once last year when uncrustify was introduced.

take care,
  Gerd