From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.30080.1652090735349713927 for ; Mon, 09 May 2022 03:05:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=gOfS0Kuo; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: yi1.li@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652090735; x=1683626735; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PmZzyny2yMLNpNucy24juweFh4aQrv6rdz23slnaL2Q=; b=gOfS0KuoogYlopraH00nrq4nR/bc181BZhAM1Y6LVvnAT0zbxlSRTSfE LSckmsruy5FoRnim7f2Z1yeG418SochFMWWa7pwZNntULMsSNCx8InFRT CQT6W31c8y7hpqbbz2k++jTdLdeTFk/f2dC+H2j5hk9Dpi/xY8/Vb4Htj sY9WpgBxcdG6a94eaWnbmMChgQ7TxtzbKo407q9vOlDzogeV4rOYmhPOn A7Emi3I2mh4L8EmV0mc4bWhpEy86aLW8vYaBt/QJNwXDvT591BBiJas7d xS+OB866G67EcnNDnZLcVV71y9+ecrtgpYjtcqmKvn2kTpBqvDMR9VM7M w==; X-IronPort-AV: E=McAfee;i="6400,9594,10341"; a="269141251" X-IronPort-AV: E=Sophos;i="5.91,211,1647327600"; d="scan'208";a="269141251" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2022 03:05:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,211,1647327600"; d="scan'208";a="564979194" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 09 May 2022 03:05:34 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 9 May 2022 03:05:33 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 9 May 2022 03:05:33 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 9 May 2022 03:05:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YRfYFygmBdHYkbXgnvxrwZVfuktLQzi2vZbhKgIsHJ29cH6fVpLVYG1x/55vYef7hnZJwafW56F9RuHKO3eH7EmsAxTgBWz50W6SCmON7FpkxCy2z+fGietIfTCU5SiRzD7VJLaGXfnACnzNejdyWBq14wvfWXoqPTnErzY34wRpvxvmvaUpOs1ci/gHs+zKj0C6TjFu9FLHzL9CGD+17AbnFV/ST2YD9WBnRJxRw2Dz9iy4lEq0R6T9EwP1VjFuxmjdPbnVuV2cosQirID883IqFkgyucGZ8b3xAs7mVJiOiuVQfHSPfIGpa02oIQTenXEjLOVO7bkk79xudeHYLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eT7FGE8dxeBgEQwIJ0hifPy1XG2YCExHrgIzZy31D34=; b=i3GRnvAWFybqn0mFummYYLitFrP9pkXEM1oGp26ZOHkg7QPDhG08k0Ndh4VQO10kKzpwNgeQLC8TAnXsrOyjAG2n9GZkS/3/7tx5ZHsMfEoVd0Y79sDciXZPgQPwdAsaTGTketKnXdXbAlX78rQCsPdnv/ios1yuYnhiDXySz2z9AJSSDsFXx5ynMmJ0T/kSM0Dj6i8yZg2ne5k3xDBQ79DMvkX2Pd3ghe1Ce8KE7mPX6wxtU9JgwshSE0u5/SNlrkax8ThrK7IKWSZFU3eTM0rF4x6i7vP2gZqrA9c2NVCB4Oc/7BsCpyZ+Y1ccpnNAxpvimnIR8Y5m9TQhFlZdGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL0PR11MB3396.namprd11.prod.outlook.com (2603:10b6:208:6d::11) by CY4PR11MB1509.namprd11.prod.outlook.com (2603:10b6:910:11::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 10:05:23 +0000 Received: from BL0PR11MB3396.namprd11.prod.outlook.com ([fe80::c9a9:ec23:2f4d:b272]) by BL0PR11MB3396.namprd11.prod.outlook.com ([fe80::c9a9:ec23:2f4d:b272%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 10:05:22 +0000 From: "yi1 li" To: "devel@edk2.groups.io" , "kraxel@redhat.com" , "Yao, Jiewen" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [edk2-devel] [PATCH 3/3] CryptoPkg/openssl: update generated files Thread-Topic: [edk2-devel] [PATCH 3/3] CryptoPkg/openssl: update generated files Thread-Index: AQHYY1OloSIzMWwp4U+8bM8/RWMEGK0V4i8AgABoNoCAAAXNcA== Date: Mon, 9 May 2022 10:05:21 +0000 Message-ID: References: <234d9edcf3f78cc3046e43241a76c4faf2592ea9.1652066029.git.yi1.li@intel.com> <20220509093823.2rrjcfib4y2rrnal@sirius.home.kraxel.org> In-Reply-To: <20220509093823.2rrjcfib4y2rrnal@sirius.home.kraxel.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 970ca458-1f80-4623-f345-08da31a36de9 x-ms-traffictypediagnostic: CY4PR11MB1509:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TR0jPZiSlhnKFuKB6wCVnTaLUMywvOkWBwTJlFMiMzS/8wTwO+LTfErvHuwtBWWUuxe5tszPv5KJqQa+lJXp+e5qUKExQyAS28kF0XxAkt7+wRzxfpyDn4AmN+32TS0sVBZkCfXhQZh4Dj0uiJlSe8fMC301tggLZ1+Qi1LolXH5ElYizblXPsmS372fW9KGXHiBdeDXviYFoB82oUnlDRZwxE3q0YLhcGNci5w9JIKn2d1lHGsi/aEy6ZV5Ovco/hYCv/NSNWojPIUWKtM1zMCfNOKgXLMq00/3ogXb8a5gv5t74jszomwfK5CN2c3QpXnnFmqcj2iV5phjd5+Vp7Kel1YABBv+AAIQzAvbzRHGilo12cbWudVh47E26EqQM0AMr90sh3HO2Vpaox1rwtJ0GU91NJc/I3cDsfZ2AyLwqdjkV75/cnVqpVmQETHpCXAhmauumfjjvdGBKEz3KZKJKSOZv1/22SnzYyEQqGn2hu7Blea6Pc73rrnAVX7L2Tu0Wqs3xy0TdHg2lY5Ueidf5TDCpzkcxzC9twkQyWDfC6TNAG15vfbUWdl+ojwMHQGM1RLD+Z/menV1v3pLfxCs/frYxZAYyLtqKRtwJ9psKkddobdHtdKOGe5V90mQFeUk2URP3Whlfj4rtXJ03Y8G4nDzeKzkeztr/UEN7lodNVyry6oCe+zmb+v9RegH39XF+de8SD5aS7J0aOdjUdez5E1aNv9XgoLh9Wusst8WlnuRol9g3Nd25oIE5da36xNG1gYAHtx+QZhtH/w6YkaBwBPHEX4OnIwwQGW60wD4GaFamFjGTAULGNJvwZyZY37m9/1NK0hAvtE2GRSvUg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR11MB3396.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(8936002)(71200400001)(86362001)(38070700005)(966005)(82960400001)(122000001)(5660300002)(508600001)(9686003)(53546011)(316002)(6506007)(6636002)(66446008)(66946007)(66476007)(64756008)(66556008)(76116006)(54906003)(4326008)(8676002)(52536014)(110136005)(7696005)(83380400001)(33656002)(186003)(55016003)(15650500001)(107886003)(26005)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eNcVQFGGpmUMckt4rIgn7BOGT3CjTXC3Kd5b/5sSwpDLuQCVxqqXg5vJdEWF?= =?us-ascii?Q?D9qKD3oemMJmTQd71W4xz/rebr0uj/2m+R4hUbz6b1+7SyNRDEgcfe9AXrdH?= =?us-ascii?Q?WGKsXmKUYIBzCERJdhPp3j/ibZgAjiLLsX8ejGZoITIXkX064xasRbYpbaA7?= =?us-ascii?Q?Bgx4vd70A+VfJiqMvonNInNMDCSL3Z/KG2s+Zy7IIEXfgl8ANhz6jHnuHK4B?= =?us-ascii?Q?U9Po0ffU+InaFKk9NeuTAnX3uRGB9HOqvC59/ZUUjHbleJ+dZ/J1JTOVIZHU?= =?us-ascii?Q?J4vMTOhjBeCj2MjrRmPybCDFHtWmKi470w8oEFSdHDtV396ETAGzK3slCpCS?= =?us-ascii?Q?egP8FJX6+dliv78uUMmXtSnHAp4/iWL4BEy5oCwTRAdfEh1cJHBanZ9/TJfR?= =?us-ascii?Q?QAHB/3UTnZ3Ai3iWEWuDsuuhVV4sqGQPCdn1d+LnT1iziqXCj/TQmg7NkqEw?= =?us-ascii?Q?lGCeO3b0fzU5WBxki+Duaz5qZGIErFWPJw4qIvcUJdi8I3lV8pua12qYS4OQ?= =?us-ascii?Q?SBLXVfNOSc0h5ErN7jks2KVet4l0c+lceiHp7nLQqqYeTFuTOIbYFX3UALrl?= =?us-ascii?Q?anGmWpzj4r0OqmIuyZgmZkdZkcAB73W1xLueS2Id63g+/P20nxyeArLRRJhN?= =?us-ascii?Q?apJGOHhfjT4NrxxG6F5Qrfev6d1f+2uHSWv8pSoWrNeO7ldG4zeG5vV9BK+Z?= =?us-ascii?Q?w7cNRU53LYEs1WgcCPNjqvx/InC7NVTZdQvcbdINgdi2D0B+XkienFtsFz8q?= =?us-ascii?Q?mVU36ciNrthd5F2kCKdD10Egpl4xaXWXhxzypVlPsKo/XHOSSKjvsGsBCnzf?= =?us-ascii?Q?XS2qQ144YOaVcAMWorLZGufyQuOOswX9X9cMIwzEywm8cWdqX+Q1mM3YtjfN?= =?us-ascii?Q?imhMti4AQYM0D9cmQMf6Dg9Cf986/RCgjr9vsvWFEO+0Rn9uOcMwZlgW98PM?= =?us-ascii?Q?dSmx2eyKlSXd30cGjkfyuxKZmrvH7Uk3R8C48RMQdnnIW2WBMNMBmBgs+qs0?= =?us-ascii?Q?dvIbgtMN9fl8E3YAlGMpE2pgLuSLUGdf3XYw+6NmjGtWglOf8jtGUyejHpuL?= =?us-ascii?Q?XDhuH/7O96lTcjpwiaskEKx2eZih8JtHAz8sWVdtATaIrvZ1zIn1zD7d281A?= =?us-ascii?Q?8A4aRT7lDiTmoBnKiKLYaxrEWgHismmbW0tnVC/ix8C5T/aoLfPpicqoFKy9?= =?us-ascii?Q?C3PCEd2QE4OdyYTGRKjxgGUoD7koWeAf+PtXyFptNKp9Bm9z8nNLKud8d3c0?= =?us-ascii?Q?nCgMKToVNwF8jnE6BdqJDifr+MF6BECCt7e023c7sibpzYdet4ozOcoFaesk?= =?us-ascii?Q?9PnOElI+G3JFptZTLuRLqnZQqoRcmmDhbX4TUvPHyt85+PszdiWy6DZYkYJH?= =?us-ascii?Q?ZOf1TERqjR8rhCZfXueZHA2RBw5PkjBTcegBAl1L7ebc3f2ytJJ/E4WVJ0BV?= =?us-ascii?Q?joJk7LysXxRqjw8jh5pyNsmUwHyaA71EYikyaraVJbmjGyKBVXKPhPVopqZY?= =?us-ascii?Q?RSahAnaxR1zZ4wIn4ylweV8CPdEMF5HUC069Avzj0EzXsiXyPgGBQbn9yISV?= =?us-ascii?Q?Oh4eU68kMIDBKD4LBbxr8p7ff7esoiCqJjkQXLVJFEpJ2z1/iVaxdJeKRx1w?= =?us-ascii?Q?eQ8YpBGm4q600978/RtnuJ6OQEeO/qX2SEodN9YiiEpVKS+sC9U4qRyYsYOX?= =?us-ascii?Q?fu3M3F/bV4zPAU/PTZhS2hHdPOecZ9D5el1IItozAzzZv8IeXMM7SCMFCAug?= =?us-ascii?Q?o6pYew+xtQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3396.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 970ca458-1f80-4623-f345-08da31a36de9 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2022 10:05:21.9356 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PdYVC1C6gyV8o8k+4+YhqJps1GbCh5vgfBw7JrcR3nCzpWAhD9ADmN3rZCCojc/1dySPCqJmn872/156AKG1Sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1509 Return-Path: yi1.li@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes it does come from running the generated files though uncrustify once la= st year when uncrustify was introduced: https://github.com/tianocore/edk2/commit/7c342378317039e632d9a1a5d4cf7c21ae= c8cb7a I can remove those change next patch to avoid confusion. Thank you, Yi=20 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Gerd Hoffman= n Sent: Monday, May 9, 2022 5:38 PM To: Yao, Jiewen Cc: Li, Yi1 ; devel@edk2.groups.io; Wang, Jian J ; Lu, Xiaoyu1 ; Jiang, Guomin Subject: Re: [edk2-devel] [PATCH 3/3] CryptoPkg/openssl: update generated f= iles On Mon, May 09, 2022 at 03:25:24AM +0000, Yao, Jiewen wrote: > Thanks for the update. >=20 > think some changes are unnecessary. >=20 > > -#define OSSL_CRYPTO_DSO_CONF_H > > -#define DSO_NONE > > -#define DSO_EXTENSION ".so" > > +# define OSSL_CRYPTO_DSO_CONF_H > > +# define DSO_NONE > > +# define DSO_EXTENSION ".so" >=20 > Why you add a space ' ' ? >=20 > Can we make it unchanged?=20 Not sure where this comes from, either it's a upstream openssl change, or i= t comes from running the generated files though uncrustify once last year w= hen uncrustify was introduced. take care, Gerd